From: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
To: Robert Bragg <robert@sixbynine.org>,
Matthew Auld <matthew.william.auld@gmail.com>
Cc: Daniel Vetter <daniel.vetter@intel.com>,
Intel Graphics Development <intel-gfx@lists.freedesktop.org>,
Sourab Gupta <sourab.gupta@intel.com>,
ML dri-devel <dri-devel@lists.freedesktop.org>
Subject: Re: [Intel-gfx] [PATCH] drm/i915: Add i915 perf infrastructure
Date: Wed, 12 Oct 2016 14:41:17 +0300 [thread overview]
Message-ID: <1476272477.2817.21.camel@linux.intel.com> (raw)
In-Reply-To: <CAMou1-3uOz5aJn+2mS0TbEnUYoNUVxwm_AqQ3k5+Kqc-D5LfJA@mail.gmail.com>
On ti, 2016-10-11 at 12:03 -0700, Robert Bragg wrote:
> > > + case DRM_I915_PERF_PROP_MAX:
> > > + BUG();
> >
> > We already handle this case above, but I guess we still need this in
> > order to silence gcc...
>
> right, and preferable to having a default: case, for the future compiler warning to handle any new properties here.
Please, do use MISSING_CASE instead. Daniel is known to get upset for
far less ;)
Generally consensus is that BUG() is used only when there're no other options to back out.
Regards, Joonas
--
Joonas Lahtinen
Open Source Technology Center
Intel Corporation
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2016-10-12 11:41 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-14 14:19 [PATCH v5 00/11] Enable i915 perf stream for Haswell OA unit Robert Bragg
2016-09-14 14:19 ` [PATCH v5 01/11] drm/i915: Add i915 perf infrastructure Robert Bragg
2016-09-14 14:42 ` [Intel-gfx] " Emil Velikov
2016-09-14 15:02 ` Robert Bragg
2016-09-14 15:32 ` [PATCH] " Robert Bragg
2016-10-07 17:10 ` Matthew Auld
2016-10-11 19:03 ` [Intel-gfx] " Robert Bragg
2016-10-12 11:41 ` Joonas Lahtinen [this message]
2016-10-19 16:35 ` Robert Bragg
2016-10-20 15:19 ` [Intel-gfx] " Joonas Lahtinen
2016-09-14 14:19 ` [PATCH v5 02/11] drm/i915: rename OACONTROL GEN7_OACONTROL Robert Bragg
2016-10-07 17:11 ` Matthew Auld
2016-09-14 14:19 ` [PATCH v5 03/11] drm/i915: return EACCES for check_cmd() failures Robert Bragg
2016-09-14 14:19 ` [PATCH v5 04/11] drm/i915: don't whitelist oacontrol in cmd parser Robert Bragg
2016-09-14 14:19 ` [PATCH v5 05/11] drm/i915: Add 'render basic' Haswell OA unit config Robert Bragg
2016-10-07 17:15 ` Matthew Auld
2016-09-14 14:19 ` [PATCH v5 06/11] drm/i915: Enable i915 perf stream for Haswell OA unit Robert Bragg
2016-10-07 17:19 ` Matthew Auld
2016-10-12 0:55 ` Robert Bragg
2016-09-14 14:19 ` [PATCH v5 07/11] drm/i915: advertise available metrics via sysfs Robert Bragg
2016-10-07 17:20 ` Matthew Auld
2016-09-14 14:19 ` [PATCH v5 08/11] drm/i915: Add dev.i915.perf_event_paranoid sysctl option Robert Bragg
2016-10-07 17:21 ` Matthew Auld
2016-09-14 14:19 ` [PATCH v5 09/11] drm/i915: add oa_event_min_timer_exponent sysctl Robert Bragg
2016-10-07 17:21 ` Matthew Auld
2016-09-14 14:19 ` [PATCH v5 10/11] drm/i915: Add more Haswell OA metric sets Robert Bragg
2016-10-07 17:22 ` Matthew Auld
2016-09-14 14:19 ` [PATCH v5 11/11] drm/i915: Add a kerneldoc summary for i915_perf.c Robert Bragg
2016-10-07 17:24 ` Matthew Auld
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1476272477.2817.21.camel@linux.intel.com \
--to=joonas.lahtinen@linux.intel.com \
--cc=daniel.vetter@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=matthew.william.auld@gmail.com \
--cc=robert@sixbynine.org \
--cc=sourab.gupta@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).