From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paulo Zanoni Subject: Re: [PATCH 09/10] drm/i915/gen9: Actually verify WM levels in verify_wm_state() Date: Thu, 13 Oct 2016 18:15:25 -0300 Message-ID: <1476393325.2478.48.camel@intel.com> References: <1475885497-6094-1-git-send-email-cpaul@redhat.com> <1475885497-6094-10-git-send-email-cpaul@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <1475885497-6094-10-git-send-email-cpaul@redhat.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Lyude , intel-gfx@lists.freedesktop.org Cc: David Airlie , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Daniel Vetter List-Id: dri-devel@lists.freedesktop.org RW0gU2V4LCAyMDE2LTEwLTA3IMOgcyAyMDoxMSAtMDQwMCwgTHl1ZGUgZXNjcmV2ZXU6Cj4gVGhh bmtzIHRvIFBhdWxvIFphbm9uaSBmb3IgaW5kaXJlY3RseSBwb2ludGluZyB0aGlzIG91dC4KPiAK PiBMb29rcyBsaWtlIHdlIG5ldmVyIGFjdHVhbGx5IGFkZGVkIGFueSBjb2RlIGZvciBjaGVja2lu ZyB3aGV0aGVyIG9yCj4gbm90Cj4gd2UgYWN0dWFsbHkgd3JvdGUgd2F0ZXJtYXJrIGxldmVscyBw cm9wZXJseS4gTGV0J3MgZml4IHRoYXQuCgpUaGFua3MgZm9yIGRvaW5nIHRoaXMhCgpSZXZpZXdl ZC1ieTogUGF1bG8gWmFub25pIDxwYXVsby5yLnphbm9uaUBpbnRlbC5jb20+CgpBIGNoZWNrIHRo YXQgd291bGQgaGF2ZSBwcmV2ZW50ZWQgb25lIG9mIHRoZSBidWdzIEkgc29sdmVkIHdvdWxkIGJl ICJpZgpwbGFuZSBpcyBhY3RpdmUsIHRoZW4gbGV2ZWwgMCBtdXN0IGJlIGVuYWJsZWQsIGFuZCBE REIgcGFydGl0aW9uaW5nCnNpemUgbXVzdCBiZSBub24temVybyIuIEknbGwgcHV0IHRoaXMgaW4g bXkgVE9ETyBsaXN0LCBidXQgSSB3b24ndApjb21wbGFpbiBpZiBzb21lYm9keSBkb2VzIGl0IGZp cnN0IDopCgo+IAo+IFNpZ25lZC1vZmYtYnk6IEx5dWRlIDxjcGF1bEByZWRoYXQuY29tPgo+IENj OiBNYWFydGVuIExhbmtob3JzdCA8bWFhcnRlbi5sYW5raG9yc3RAbGludXguaW50ZWwuY29tPgo+ IENjOiBWaWxsZSBTeXJqw6Rsw6QgPHZpbGxlLnN5cmphbGFAbGludXguaW50ZWwuY29tPgo+IENj OiBQYXVsbyBaYW5vbmkgPHBhdWxvLnIuemFub25pQGludGVsLmNvbT4KPiAtLS0KPiDCoGRyaXZl cnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rpc3BsYXkuYyB8IDEwMAo+ICsrKysrKysrKysrKysrKysr KysrKysrKysrKysrLS0tLS0tCj4gwqAxIGZpbGUgY2hhbmdlZCwgODQgaW5zZXJ0aW9ucygrKSwg MTYgZGVsZXRpb25zKC0pCj4gCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2lu dGVsX2Rpc3BsYXkuYwo+IGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5jCj4g aW5kZXggMzk0MDBhMC4uMmM2ODJiYyAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkx NS9pbnRlbF9kaXNwbGF5LmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kaXNw bGF5LmMKPiBAQCAtMTM0NDQsMzAgKzEzNDQ0LDY2IEBAIHN0YXRpYyB2b2lkIHZlcmlmeV93bV9z dGF0ZShzdHJ1Y3QgZHJtX2NydGMKPiAqY3J0YywKPiDCoAlzdHJ1Y3QgZHJtX2RldmljZSAqZGV2 ID0gY3J0Yy0+ZGV2Owo+IMKgCXN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiA9IHRv X2k5MTUoZGV2KTsKPiDCoAlzdHJ1Y3Qgc2tsX2RkYl9hbGxvY2F0aW9uIGh3X2RkYiwgKnN3X2Rk YjsKPiAtCXN0cnVjdCBza2xfZGRiX2VudHJ5ICpod19lbnRyeSwgKnN3X2VudHJ5Owo+ICsJc3Ry dWN0IHNrbF9waXBlX3dtIGh3X3dtLCAqc3dfd207Cj4gKwlzdHJ1Y3Qgc2tsX3BsYW5lX3dtICpo d19wbGFuZV93bSwgKnN3X3BsYW5lX3dtOwo+ICsJc3RydWN0IHNrbF9kZGJfZW50cnkgKmh3X2Rk Yl9lbnRyeSwgKnN3X2RkYl9lbnRyeTsKPiDCoAlzdHJ1Y3QgaW50ZWxfY3J0YyAqaW50ZWxfY3J0 YyA9IHRvX2ludGVsX2NydGMoY3J0Yyk7Cj4gwqAJY29uc3QgZW51bSBwaXBlIHBpcGUgPSBpbnRl bF9jcnRjLT5waXBlOwo+IC0JaW50IHBsYW5lOwo+ICsJaW50IHBsYW5lLCBsZXZlbCwgbWF4X2xl dmVsID0gaWxrX3dtX21heF9sZXZlbChkZXYpOwo+IMKgCj4gwqAJaWYgKElOVEVMX0lORk8oZGV2 KS0+Z2VuIDwgOSB8fCAhbmV3X3N0YXRlLT5hY3RpdmUpCj4gwqAJCXJldHVybjsKPiDCoAo+ICsJ c2tsX3BpcGVfd21fZ2V0X2h3X3N0YXRlKGNydGMsICZod193bSk7Cj4gKwlzd193bSA9ICZpbnRl bF9jcnRjLT53bS5hY3RpdmUuc2tsOwo+ICsKPiDCoAlza2xfZGRiX2dldF9od19zdGF0ZShkZXZf cHJpdiwgJmh3X2RkYik7Cj4gwqAJc3dfZGRiID0gJmRldl9wcml2LT53bS5za2xfaHcuZGRiOwo+ IMKgCj4gwqAJLyogcGxhbmVzICovCj4gwqAJZm9yX2VhY2hfcGxhbmUoZGV2X3ByaXYsIHBpcGUs IHBsYW5lKSB7Cj4gLQkJaHdfZW50cnkgPSAmaHdfZGRiLnBsYW5lW3BpcGVdW3BsYW5lXTsKPiAt CQlzd19lbnRyeSA9ICZzd19kZGItPnBsYW5lW3BpcGVdW3BsYW5lXTsKPiArCQlod19wbGFuZV93 bSA9ICZod193bS5wbGFuZXNbcGxhbmVdOwo+ICsJCXN3X3BsYW5lX3dtID0gJnN3X3dtLT5wbGFu ZXNbcGxhbmVdOwo+IMKgCj4gLQkJaWYgKHNrbF9kZGJfZW50cnlfZXF1YWwoaHdfZW50cnksIHN3 X2VudHJ5KSkKPiAtCQkJY29udGludWU7Cj4gKwkJLyogV2F0ZXJtYXJrcyAqLwo+ICsJCWZvciAo bGV2ZWwgPSAwOyBsZXZlbCA8PSBtYXhfbGV2ZWw7IGxldmVsKyspIHsKPiArCQkJaWYgKHNrbF93 bV9sZXZlbF9lcXVhbHMoJmh3X3BsYW5lX3dtLQo+ID53bVtsZXZlbF0sCj4gKwkJCQkJCSZzd19w bGFuZV93bS0KPiA+d21bbGV2ZWxdKSkKPiArCQkJCWNvbnRpbnVlOwo+ICsKPiArCQkJRFJNX0VS Uk9SKCJtaXNtYXRjaCBpbiBXTSBwaXBlICVjIHBsYW5lICVkCj4gbGV2ZWwgJWQgKGV4cGVjdGVk IGU9JWQgYj0lZCBsPSVkLCBnb3QgZT0lZCBiPSVkIGw9JWQpXG4iLAo+ICsJCQkJwqDCoHBpcGVf bmFtZShwaXBlKSwgcGxhbmUgKyAxLCBsZXZlbCwKPiArCQkJCcKgwqBzd19wbGFuZV93bS0+d21b bGV2ZWxdLnBsYW5lX2VuLAo+ICsJCQkJwqDCoHN3X3BsYW5lX3dtLQo+ID53bVtsZXZlbF0ucGxh bmVfcmVzX2IsCj4gKwkJCQnCoMKgc3dfcGxhbmVfd20tCj4gPndtW2xldmVsXS5wbGFuZV9yZXNf bCwKPiArCQkJCcKgwqBod19wbGFuZV93bS0+d21bbGV2ZWxdLnBsYW5lX2VuLAo+ICsJCQkJwqDC oGh3X3BsYW5lX3dtLQo+ID53bVtsZXZlbF0ucGxhbmVfcmVzX2IsCj4gKwkJCQnCoMKgaHdfcGxh bmVfd20tCj4gPndtW2xldmVsXS5wbGFuZV9yZXNfbCk7Cj4gKwkJfQo+IMKgCj4gLQkJRFJNX0VS Uk9SKCJtaXNtYXRjaCBpbiBEREIgc3RhdGUgcGlwZSAlYyBwbGFuZSAlZCAiCj4gLQkJCcKgwqAi KGV4cGVjdGVkICgldSwldSksIGZvdW5kICgldSwldSkpXG4iLAo+IC0JCQnCoMKgcGlwZV9uYW1l KHBpcGUpLCBwbGFuZSArIDEsCj4gLQkJCcKgwqBzd19lbnRyeS0+c3RhcnQsIHN3X2VudHJ5LT5l bmQsCj4gLQkJCcKgwqBod19lbnRyeS0+c3RhcnQsIGh3X2VudHJ5LT5lbmQpOwo+ICsJCWlmICgh c2tsX3dtX2xldmVsX2VxdWFscygmaHdfcGxhbmVfd20tPnRyYW5zX3dtLAo+ICsJCQkJCcKgJnN3 X3BsYW5lX3dtLT50cmFuc193bSkpIHsKPiArCQkJRFJNX0VSUk9SKCJtaXNtYXRjaCBpbiB0cmFu cyBXTSBwaXBlICVjCj4gcGxhbmUgJWQgKGV4cGVjdGVkIGU9JWQgYj0lZCBsPSVkLCBnb3QgZT0l ZCBiPSVkIGw9JWQpXG4iLAo+ICsJCQkJwqDCoHBpcGVfbmFtZShwaXBlKSwgcGxhbmUgKyAxLAo+ ICsJCQkJwqDCoHN3X3BsYW5lX3dtLT50cmFuc193bS5wbGFuZV9lbiwKPiArCQkJCcKgwqBzd19w bGFuZV93bS0+dHJhbnNfd20ucGxhbmVfcmVzX2IsCj4gKwkJCQnCoMKgc3dfcGxhbmVfd20tPnRy YW5zX3dtLnBsYW5lX3Jlc19sLAo+ICsJCQkJwqDCoGh3X3BsYW5lX3dtLT50cmFuc193bS5wbGFu ZV9lbiwKPiArCQkJCcKgwqBod19wbGFuZV93bS0+dHJhbnNfd20ucGxhbmVfcmVzX2IsCj4gKwkJ CQnCoMKgaHdfcGxhbmVfd20tCj4gPnRyYW5zX3dtLnBsYW5lX3Jlc19sKTsKPiArCQl9Cj4gKwo+ ICsJCS8qIEREQiAqLwo+ICsJCWh3X2RkYl9lbnRyeSA9ICZod19kZGIucGxhbmVbcGlwZV1bcGxh bmVdOwo+ICsJCXN3X2RkYl9lbnRyeSA9ICZzd19kZGItPnBsYW5lW3BpcGVdW3BsYW5lXTsKPiAr Cj4gKwkJaWYgKCFza2xfZGRiX2VudHJ5X2VxdWFsKGh3X2RkYl9lbnRyeSwKPiBzd19kZGJfZW50 cnkpKSB7Cj4gKwkJCURSTV9FUlJPUigibWlzbWF0Y2ggaW4gRERCIHN0YXRlIHBpcGUgJWMKPiBw bGFuZSAlZCAiCj4gKwkJCQnCoMKgIihleHBlY3RlZCAoJXUsJXUpLCBmb3VuZAo+ICgldSwldSkp XG4iLAo+ICsJCQkJwqDCoHBpcGVfbmFtZShwaXBlKSwgcGxhbmUgKyAxLAo+ICsJCQkJwqDCoHN3 X2RkYl9lbnRyeS0+c3RhcnQsIHN3X2RkYl9lbnRyeS0KPiA+ZW5kLAo+ICsJCQkJwqDCoGh3X2Rk Yl9lbnRyeS0+c3RhcnQsIGh3X2RkYl9lbnRyeS0KPiA+ZW5kKTsKPiArCQl9Cj4gwqAJfQo+IMKg Cj4gwqAJLyoKPiBAQCAtMTM0NzcsMTUgKzEzNTEzLDQ3IEBAIHN0YXRpYyB2b2lkIHZlcmlmeV93 bV9zdGF0ZShzdHJ1Y3QgZHJtX2NydGMKPiAqY3J0YywKPiDCoAnCoCogb25jZSB0aGUgcGxhbmUg YmVjb21lcyB2aXNpYmxlLCB3ZSBjYW4gc2tpcCB0aGlzIGNoZWNrCj4gwqAJwqAqLwo+IMKgCWlm IChpbnRlbF9jcnRjLT5jdXJzb3JfYWRkcikgewo+IC0JCWh3X2VudHJ5ID0gJmh3X2RkYi5wbGFu ZVtwaXBlXVtQTEFORV9DVVJTT1JdOwo+IC0JCXN3X2VudHJ5ID0gJnN3X2RkYi0+cGxhbmVbcGlw ZV1bUExBTkVfQ1VSU09SXTsKPiArCQlod19wbGFuZV93bSA9ICZod193bS5wbGFuZXNbUExBTkVf Q1VSU09SXTsKPiArCQlzd19wbGFuZV93bSA9ICZzd193bS0+cGxhbmVzW1BMQU5FX0NVUlNPUl07 Cj4gKwo+ICsJCS8qIFdhdGVybWFya3MgKi8KPiArCQlmb3IgKGxldmVsID0gMDsgbGV2ZWwgPD0g bWF4X2xldmVsOyBsZXZlbCsrKSB7Cj4gKwkJCWlmIChza2xfd21fbGV2ZWxfZXF1YWxzKCZod19w bGFuZV93bS0KPiA+d21bbGV2ZWxdLAo+ICsJCQkJCQkmc3dfcGxhbmVfd20tCj4gPndtW2xldmVs XSkpCj4gKwkJCQljb250aW51ZTsKPiArCj4gKwkJCURSTV9FUlJPUigibWlzbWF0Y2ggaW4gV00g cGlwZSAlYyBjdXJzb3IKPiBsZXZlbCAlZCAoZXhwZWN0ZWQgZT0lZCBiPSVkIGw9JWQsIGdvdCBl PSVkIGI9JWQgbD0lZClcbiIsCj4gKwkJCQnCoMKgcGlwZV9uYW1lKHBpcGUpLCBsZXZlbCwKPiAr CQkJCcKgwqBzd19wbGFuZV93bS0+d21bbGV2ZWxdLnBsYW5lX2VuLAo+ICsJCQkJwqDCoHN3X3Bs YW5lX3dtLQo+ID53bVtsZXZlbF0ucGxhbmVfcmVzX2IsCj4gKwkJCQnCoMKgc3dfcGxhbmVfd20t Cj4gPndtW2xldmVsXS5wbGFuZV9yZXNfbCwKPiArCQkJCcKgwqBod19wbGFuZV93bS0+d21bbGV2 ZWxdLnBsYW5lX2VuLAo+ICsJCQkJwqDCoGh3X3BsYW5lX3dtLQo+ID53bVtsZXZlbF0ucGxhbmVf cmVzX2IsCj4gKwkJCQnCoMKgaHdfcGxhbmVfd20tCj4gPndtW2xldmVsXS5wbGFuZV9yZXNfbCk7 Cj4gKwkJfQo+ICsKPiArCQlpZiAoIXNrbF93bV9sZXZlbF9lcXVhbHMoJmh3X3BsYW5lX3dtLT50 cmFuc193bSwKPiArCQkJCQnCoCZzd19wbGFuZV93bS0+dHJhbnNfd20pKSB7Cj4gKwkJCURSTV9F UlJPUigibWlzbWF0Y2ggaW4gdHJhbnMgV00gcGlwZSAlYwo+IGN1cnNvciAoZXhwZWN0ZWQgZT0l ZCBiPSVkIGw9JWQsIGdvdCBlPSVkIGI9JWQgbD0lZClcbiIsCj4gKwkJCQnCoMKgcGlwZV9uYW1l KHBpcGUpLAo+ICsJCQkJwqDCoHN3X3BsYW5lX3dtLT50cmFuc193bS5wbGFuZV9lbiwKPiArCQkJ CcKgwqBzd19wbGFuZV93bS0+dHJhbnNfd20ucGxhbmVfcmVzX2IsCj4gKwkJCQnCoMKgc3dfcGxh bmVfd20tPnRyYW5zX3dtLnBsYW5lX3Jlc19sLAo+ICsJCQkJwqDCoGh3X3BsYW5lX3dtLT50cmFu c193bS5wbGFuZV9lbiwKPiArCQkJCcKgwqBod19wbGFuZV93bS0+dHJhbnNfd20ucGxhbmVfcmVz X2IsCj4gKwkJCQnCoMKgaHdfcGxhbmVfd20tCj4gPnRyYW5zX3dtLnBsYW5lX3Jlc19sKTsKPiAr CQl9Cj4gKwo+ICsJCS8qIEREQiAqLwo+ICsJCWh3X2RkYl9lbnRyeSA9ICZod19kZGIucGxhbmVb cGlwZV1bUExBTkVfQ1VSU09SXTsKPiArCQlzd19kZGJfZW50cnkgPSAmc3dfZGRiLT5wbGFuZVtw aXBlXVtQTEFORV9DVVJTT1JdOwo+IMKgCj4gLQkJaWYgKCFza2xfZGRiX2VudHJ5X2VxdWFsKGh3 X2VudHJ5LCBzd19lbnRyeSkpIHsKPiArCQlpZiAoIXNrbF9kZGJfZW50cnlfZXF1YWwoaHdfZGRi X2VudHJ5LAo+IHN3X2RkYl9lbnRyeSkpIHsKPiDCoAkJCURSTV9FUlJPUigibWlzbWF0Y2ggaW4g RERCIHN0YXRlIHBpcGUgJWMKPiBjdXJzb3IgIgo+IMKgCQkJCcKgwqAiKGV4cGVjdGVkICgldSwl dSksIGZvdW5kCj4gKCV1LCV1KSlcbiIsCj4gwqAJCQkJwqDCoHBpcGVfbmFtZShwaXBlKSwKPiAt CQkJCcKgwqBzd19lbnRyeS0+c3RhcnQsIHN3X2VudHJ5LT5lbmQsCj4gLQkJCQnCoMKgaHdfZW50 cnktPnN0YXJ0LCBod19lbnRyeS0+ZW5kKTsKPiArCQkJCcKgwqBzd19kZGJfZW50cnktPnN0YXJ0 LCBzd19kZGJfZW50cnktCj4gPmVuZCwKPiArCQkJCcKgwqBod19kZGJfZW50cnktPnN0YXJ0LCBo d19kZGJfZW50cnktCj4gPmVuZCk7Cj4gwqAJCX0KPiDCoAl9Cj4gwqB9Cl9fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QK SW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9w Lm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo=