From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paulo Zanoni Subject: Re: [PATCH 09/10] drm/i915/gen9: Actually verify WM levels in verify_wm_state() Date: Thu, 13 Oct 2016 18:20:04 -0300 Message-ID: <1476393604.2478.51.camel@intel.com> References: <1475885497-6094-1-git-send-email-cpaul@redhat.com> <1475885497-6094-10-git-send-email-cpaul@redhat.com> <1476393325.2478.48.camel@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <1476393325.2478.48.camel@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Lyude , intel-gfx@lists.freedesktop.org Cc: David Airlie , Daniel Vetter , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org RW0gUXVpLCAyMDE2LTEwLTEzIMOgcyAxODoxNSAtMDMwMCwgUGF1bG8gWmFub25pIGVzY3JldmV1 Ogo+IEVtIFNleCwgMjAxNi0xMC0wNyDDoHMgMjA6MTEgLTA0MDAsIEx5dWRlIGVzY3JldmV1Ogo+ ID4gCj4gPiBUaGFua3MgdG8gUGF1bG8gWmFub25pIGZvciBpbmRpcmVjdGx5IHBvaW50aW5nIHRo aXMgb3V0Lgo+ID4gCj4gPiBMb29rcyBsaWtlIHdlIG5ldmVyIGFjdHVhbGx5IGFkZGVkIGFueSBj b2RlIGZvciBjaGVja2luZyB3aGV0aGVyIG9yCj4gPiBub3QKPiA+IHdlIGFjdHVhbGx5IHdyb3Rl IHdhdGVybWFyayBsZXZlbHMgcHJvcGVybHkuIExldCdzIGZpeCB0aGF0Lgo+IAo+IFRoYW5rcyBm b3IgZG9pbmcgdGhpcyEKPiAKPiBSZXZpZXdlZC1ieTogUGF1bG8gWmFub25pIDxwYXVsby5yLnph bm9uaUBpbnRlbC5jb20+Cj4gCj4gQSBjaGVjayB0aGF0IHdvdWxkIGhhdmUgcHJldmVudGVkIG9u ZSBvZiB0aGUgYnVncyBJIHNvbHZlZCB3b3VsZCBiZQo+ICJpZgo+IHBsYW5lIGlzIGFjdGl2ZSwg dGhlbiBsZXZlbCAwIG11c3QgYmUgZW5hYmxlZCwgYW5kIEREQiBwYXJ0aXRpb25pbmcKPiBzaXpl IG11c3QgYmUgbm9uLXplcm8iLiBJJ2xsIHB1dCB0aGlzIGluIG15IFRPRE8gbGlzdCwgYnV0IEkg d29uJ3QKPiBjb21wbGFpbiBpZiBzb21lYm9keSBkb2VzIGl0IGZpcnN0IDopCgpBbHNvLCBiaWtl c2hlZDogdXNlICV1IGluc3RlYWQgb2YgJWQgZm9yIHRoZSB1bnNpZ25lZCB0eXBlcwoocGxhbmVf cmVzX2IsIHBsYW5lX3Jlc19sKS4KCj4gCj4gPiAKPiA+IAo+ID4gU2lnbmVkLW9mZi1ieTogTHl1 ZGUgPGNwYXVsQHJlZGhhdC5jb20+Cj4gPiBDYzogTWFhcnRlbiBMYW5raG9yc3QgPG1hYXJ0ZW4u bGFua2hvcnN0QGxpbnV4LmludGVsLmNvbT4KPiA+IENjOiBWaWxsZSBTeXJqw6Rsw6QgPHZpbGxl LnN5cmphbGFAbGludXguaW50ZWwuY29tPgo+ID4gQ2M6IFBhdWxvIFphbm9uaSA8cGF1bG8uci56 YW5vbmlAaW50ZWwuY29tPgo+ID4gLS0tCj4gPiDCoGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVs X2Rpc3BsYXkuYyB8IDEwMAo+ID4gKysrKysrKysrKysrKysrKysrKysrKysrKysrKystLS0tLS0K PiA+IMKgMSBmaWxlIGNoYW5nZWQsIDg0IGluc2VydGlvbnMoKyksIDE2IGRlbGV0aW9ucygtKQo+ ID4gCj4gPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5j Cj4gPiBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rpc3BsYXkuYwo+ID4gaW5kZXggMzk0 MDBhMC4uMmM2ODJiYyAxMDA2NDQKPiA+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVs X2Rpc3BsYXkuYwo+ID4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5j Cj4gPiBAQCAtMTM0NDQsMzAgKzEzNDQ0LDY2IEBAIHN0YXRpYyB2b2lkIHZlcmlmeV93bV9zdGF0 ZShzdHJ1Y3QKPiA+IGRybV9jcnRjCj4gPiAqY3J0YywKPiA+IMKgCXN0cnVjdCBkcm1fZGV2aWNl ICpkZXYgPSBjcnRjLT5kZXY7Cj4gPiDCoAlzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3By aXYgPSB0b19pOTE1KGRldik7Cj4gPiDCoAlzdHJ1Y3Qgc2tsX2RkYl9hbGxvY2F0aW9uIGh3X2Rk YiwgKnN3X2RkYjsKPiA+IC0Jc3RydWN0IHNrbF9kZGJfZW50cnkgKmh3X2VudHJ5LCAqc3dfZW50 cnk7Cj4gPiArCXN0cnVjdCBza2xfcGlwZV93bSBod193bSwgKnN3X3dtOwo+ID4gKwlzdHJ1Y3Qg c2tsX3BsYW5lX3dtICpod19wbGFuZV93bSwgKnN3X3BsYW5lX3dtOwo+ID4gKwlzdHJ1Y3Qgc2ts X2RkYl9lbnRyeSAqaHdfZGRiX2VudHJ5LCAqc3dfZGRiX2VudHJ5Owo+ID4gwqAJc3RydWN0IGlu dGVsX2NydGMgKmludGVsX2NydGMgPSB0b19pbnRlbF9jcnRjKGNydGMpOwo+ID4gwqAJY29uc3Qg ZW51bSBwaXBlIHBpcGUgPSBpbnRlbF9jcnRjLT5waXBlOwo+ID4gLQlpbnQgcGxhbmU7Cj4gPiAr CWludCBwbGFuZSwgbGV2ZWwsIG1heF9sZXZlbCA9IGlsa193bV9tYXhfbGV2ZWwoZGV2KTsKPiA+ IMKgCj4gPiDCoAlpZiAoSU5URUxfSU5GTyhkZXYpLT5nZW4gPCA5IHx8ICFuZXdfc3RhdGUtPmFj dGl2ZSkKPiA+IMKgCQlyZXR1cm47Cj4gPiDCoAo+ID4gKwlza2xfcGlwZV93bV9nZXRfaHdfc3Rh dGUoY3J0YywgJmh3X3dtKTsKPiA+ICsJc3dfd20gPSAmaW50ZWxfY3J0Yy0+d20uYWN0aXZlLnNr bDsKPiA+ICsKPiA+IMKgCXNrbF9kZGJfZ2V0X2h3X3N0YXRlKGRldl9wcml2LCAmaHdfZGRiKTsK PiA+IMKgCXN3X2RkYiA9ICZkZXZfcHJpdi0+d20uc2tsX2h3LmRkYjsKPiA+IMKgCj4gPiDCoAkv KiBwbGFuZXMgKi8KPiA+IMKgCWZvcl9lYWNoX3BsYW5lKGRldl9wcml2LCBwaXBlLCBwbGFuZSkg ewo+ID4gLQkJaHdfZW50cnkgPSAmaHdfZGRiLnBsYW5lW3BpcGVdW3BsYW5lXTsKPiA+IC0JCXN3 X2VudHJ5ID0gJnN3X2RkYi0+cGxhbmVbcGlwZV1bcGxhbmVdOwo+ID4gKwkJaHdfcGxhbmVfd20g PSAmaHdfd20ucGxhbmVzW3BsYW5lXTsKPiA+ICsJCXN3X3BsYW5lX3dtID0gJnN3X3dtLT5wbGFu ZXNbcGxhbmVdOwo+ID4gwqAKPiA+IC0JCWlmIChza2xfZGRiX2VudHJ5X2VxdWFsKGh3X2VudHJ5 LCBzd19lbnRyeSkpCj4gPiAtCQkJY29udGludWU7Cj4gPiArCQkvKiBXYXRlcm1hcmtzICovCj4g PiArCQlmb3IgKGxldmVsID0gMDsgbGV2ZWwgPD0gbWF4X2xldmVsOyBsZXZlbCsrKSB7Cj4gPiAr CQkJaWYgKHNrbF93bV9sZXZlbF9lcXVhbHMoJmh3X3BsYW5lX3dtLQo+ID4gPiAKPiA+ID4gd21b bGV2ZWxdLAo+ID4gKwkJCQkJCSZzd19wbGFuZV93bS0KPiA+ID4gCj4gPiA+IHdtW2xldmVsXSkp Cj4gPiArCQkJCWNvbnRpbnVlOwo+ID4gKwo+ID4gKwkJCURSTV9FUlJPUigibWlzbWF0Y2ggaW4g V00gcGlwZSAlYyBwbGFuZSAlZAo+ID4gbGV2ZWwgJWQgKGV4cGVjdGVkIGU9JWQgYj0lZCBsPSVk LCBnb3QgZT0lZCBiPSVkIGw9JWQpXG4iLAo+ID4gKwkJCQnCoMKgcGlwZV9uYW1lKHBpcGUpLCBw bGFuZSArIDEsCj4gPiBsZXZlbCwKPiA+ICsJCQkJwqDCoHN3X3BsYW5lX3dtLT53bVtsZXZlbF0u cGxhbmVfZW4sCj4gPiArCQkJCcKgwqBzd19wbGFuZV93bS0KPiA+ID4gCj4gPiA+IHdtW2xldmVs XS5wbGFuZV9yZXNfYiwKPiA+ICsJCQkJwqDCoHN3X3BsYW5lX3dtLQo+ID4gPiAKPiA+ID4gd21b bGV2ZWxdLnBsYW5lX3Jlc19sLAo+ID4gKwkJCQnCoMKgaHdfcGxhbmVfd20tPndtW2xldmVsXS5w bGFuZV9lbiwKPiA+ICsJCQkJwqDCoGh3X3BsYW5lX3dtLQo+ID4gPiAKPiA+ID4gd21bbGV2ZWxd LnBsYW5lX3Jlc19iLAo+ID4gKwkJCQnCoMKgaHdfcGxhbmVfd20tCj4gPiA+IAo+ID4gPiB3bVts ZXZlbF0ucGxhbmVfcmVzX2wpOwo+ID4gKwkJfQo+ID4gwqAKPiA+IC0JCURSTV9FUlJPUigibWlz bWF0Y2ggaW4gRERCIHN0YXRlIHBpcGUgJWMgcGxhbmUgJWQKPiA+ICIKPiA+IC0JCQnCoMKgIihl eHBlY3RlZCAoJXUsJXUpLCBmb3VuZCAoJXUsJXUpKVxuIiwKPiA+IC0JCQnCoMKgcGlwZV9uYW1l KHBpcGUpLCBwbGFuZSArIDEsCj4gPiAtCQkJwqDCoHN3X2VudHJ5LT5zdGFydCwgc3dfZW50cnkt PmVuZCwKPiA+IC0JCQnCoMKgaHdfZW50cnktPnN0YXJ0LCBod19lbnRyeS0+ZW5kKTsKPiA+ICsJ CWlmICghc2tsX3dtX2xldmVsX2VxdWFscygmaHdfcGxhbmVfd20tPnRyYW5zX3dtLAo+ID4gKwkJ CQkJwqAmc3dfcGxhbmVfd20tPnRyYW5zX3dtKSkKPiA+IHsKPiA+ICsJCQlEUk1fRVJST1IoIm1p c21hdGNoIGluIHRyYW5zIFdNIHBpcGUgJWMKPiA+IHBsYW5lICVkIChleHBlY3RlZCBlPSVkIGI9 JWQgbD0lZCwgZ290IGU9JWQgYj0lZCBsPSVkKVxuIiwKPiA+ICsJCQkJwqDCoHBpcGVfbmFtZShw aXBlKSwgcGxhbmUgKyAxLAo+ID4gKwkJCQnCoMKgc3dfcGxhbmVfd20tPnRyYW5zX3dtLnBsYW5l X2VuLAo+ID4gKwkJCQnCoMKgc3dfcGxhbmVfd20tCj4gPiA+dHJhbnNfd20ucGxhbmVfcmVzX2Is Cj4gPiArCQkJCcKgwqBzd19wbGFuZV93bS0KPiA+ID50cmFuc193bS5wbGFuZV9yZXNfbCwKPiA+ ICsJCQkJwqDCoGh3X3BsYW5lX3dtLT50cmFuc193bS5wbGFuZV9lbiwKPiA+ICsJCQkJwqDCoGh3 X3BsYW5lX3dtLQo+ID4gPnRyYW5zX3dtLnBsYW5lX3Jlc19iLAo+ID4gKwkJCQnCoMKgaHdfcGxh bmVfd20tCj4gPiA+IAo+ID4gPiB0cmFuc193bS5wbGFuZV9yZXNfbCk7Cj4gPiArCQl9Cj4gPiAr Cj4gPiArCQkvKiBEREIgKi8KPiA+ICsJCWh3X2RkYl9lbnRyeSA9ICZod19kZGIucGxhbmVbcGlw ZV1bcGxhbmVdOwo+ID4gKwkJc3dfZGRiX2VudHJ5ID0gJnN3X2RkYi0+cGxhbmVbcGlwZV1bcGxh bmVdOwo+ID4gKwo+ID4gKwkJaWYgKCFza2xfZGRiX2VudHJ5X2VxdWFsKGh3X2RkYl9lbnRyeSwK PiA+IHN3X2RkYl9lbnRyeSkpIHsKPiA+ICsJCQlEUk1fRVJST1IoIm1pc21hdGNoIGluIEREQiBz dGF0ZSBwaXBlICVjCj4gPiBwbGFuZSAlZCAiCj4gPiArCQkJCcKgwqAiKGV4cGVjdGVkICgldSwl dSksIGZvdW5kCj4gPiAoJXUsJXUpKVxuIiwKPiA+ICsJCQkJwqDCoHBpcGVfbmFtZShwaXBlKSwg cGxhbmUgKyAxLAo+ID4gKwkJCQnCoMKgc3dfZGRiX2VudHJ5LT5zdGFydCwKPiA+IHN3X2RkYl9l bnRyeS0KPiA+ID4gCj4gPiA+IGVuZCwKPiA+ICsJCQkJwqDCoGh3X2RkYl9lbnRyeS0+c3RhcnQs Cj4gPiBod19kZGJfZW50cnktCj4gPiA+IAo+ID4gPiBlbmQpOwo+ID4gKwkJfQo+ID4gwqAJfQo+ ID4gwqAKPiA+IMKgCS8qCj4gPiBAQCAtMTM0NzcsMTUgKzEzNTEzLDQ3IEBAIHN0YXRpYyB2b2lk IHZlcmlmeV93bV9zdGF0ZShzdHJ1Y3QKPiA+IGRybV9jcnRjCj4gPiAqY3J0YywKPiA+IMKgCcKg KiBvbmNlIHRoZSBwbGFuZSBiZWNvbWVzIHZpc2libGUsIHdlIGNhbiBza2lwIHRoaXMgY2hlY2sK PiA+IMKgCcKgKi8KPiA+IMKgCWlmIChpbnRlbF9jcnRjLT5jdXJzb3JfYWRkcikgewo+ID4gLQkJ aHdfZW50cnkgPSAmaHdfZGRiLnBsYW5lW3BpcGVdW1BMQU5FX0NVUlNPUl07Cj4gPiAtCQlzd19l bnRyeSA9ICZzd19kZGItPnBsYW5lW3BpcGVdW1BMQU5FX0NVUlNPUl07Cj4gPiArCQlod19wbGFu ZV93bSA9ICZod193bS5wbGFuZXNbUExBTkVfQ1VSU09SXTsKPiA+ICsJCXN3X3BsYW5lX3dtID0g JnN3X3dtLT5wbGFuZXNbUExBTkVfQ1VSU09SXTsKPiA+ICsKPiA+ICsJCS8qIFdhdGVybWFya3Mg Ki8KPiA+ICsJCWZvciAobGV2ZWwgPSAwOyBsZXZlbCA8PSBtYXhfbGV2ZWw7IGxldmVsKyspIHsK PiA+ICsJCQlpZiAoc2tsX3dtX2xldmVsX2VxdWFscygmaHdfcGxhbmVfd20tCj4gPiA+IAo+ID4g PiB3bVtsZXZlbF0sCj4gPiArCQkJCQkJJnN3X3BsYW5lX3dtLQo+ID4gPiAKPiA+ID4gd21bbGV2 ZWxdKSkKPiA+ICsJCQkJY29udGludWU7Cj4gPiArCj4gPiArCQkJRFJNX0VSUk9SKCJtaXNtYXRj aCBpbiBXTSBwaXBlICVjIGN1cnNvcgo+ID4gbGV2ZWwgJWQgKGV4cGVjdGVkIGU9JWQgYj0lZCBs PSVkLCBnb3QgZT0lZCBiPSVkIGw9JWQpXG4iLAo+ID4gKwkJCQnCoMKgcGlwZV9uYW1lKHBpcGUp LCBsZXZlbCwKPiA+ICsJCQkJwqDCoHN3X3BsYW5lX3dtLT53bVtsZXZlbF0ucGxhbmVfZW4sCj4g PiArCQkJCcKgwqBzd19wbGFuZV93bS0KPiA+ID4gCj4gPiA+IHdtW2xldmVsXS5wbGFuZV9yZXNf YiwKPiA+ICsJCQkJwqDCoHN3X3BsYW5lX3dtLQo+ID4gPiAKPiA+ID4gd21bbGV2ZWxdLnBsYW5l X3Jlc19sLAo+ID4gKwkJCQnCoMKgaHdfcGxhbmVfd20tPndtW2xldmVsXS5wbGFuZV9lbiwKPiA+ ICsJCQkJwqDCoGh3X3BsYW5lX3dtLQo+ID4gPiAKPiA+ID4gd21bbGV2ZWxdLnBsYW5lX3Jlc19i LAo+ID4gKwkJCQnCoMKgaHdfcGxhbmVfd20tCj4gPiA+IAo+ID4gPiB3bVtsZXZlbF0ucGxhbmVf cmVzX2wpOwo+ID4gKwkJfQo+ID4gKwo+ID4gKwkJaWYgKCFza2xfd21fbGV2ZWxfZXF1YWxzKCZo d19wbGFuZV93bS0+dHJhbnNfd20sCj4gPiArCQkJCQnCoCZzd19wbGFuZV93bS0+dHJhbnNfd20p KQo+ID4gewo+ID4gKwkJCURSTV9FUlJPUigibWlzbWF0Y2ggaW4gdHJhbnMgV00gcGlwZSAlYwo+ ID4gY3Vyc29yIChleHBlY3RlZCBlPSVkIGI9JWQgbD0lZCwgZ290IGU9JWQgYj0lZCBsPSVkKVxu IiwKPiA+ICsJCQkJwqDCoHBpcGVfbmFtZShwaXBlKSwKPiA+ICsJCQkJwqDCoHN3X3BsYW5lX3dt LT50cmFuc193bS5wbGFuZV9lbiwKPiA+ICsJCQkJwqDCoHN3X3BsYW5lX3dtLQo+ID4gPnRyYW5z X3dtLnBsYW5lX3Jlc19iLAo+ID4gKwkJCQnCoMKgc3dfcGxhbmVfd20tCj4gPiA+dHJhbnNfd20u cGxhbmVfcmVzX2wsCj4gPiArCQkJCcKgwqBod19wbGFuZV93bS0+dHJhbnNfd20ucGxhbmVfZW4s Cj4gPiArCQkJCcKgwqBod19wbGFuZV93bS0KPiA+ID50cmFuc193bS5wbGFuZV9yZXNfYiwKPiA+ ICsJCQkJwqDCoGh3X3BsYW5lX3dtLQo+ID4gPiAKPiA+ID4gdHJhbnNfd20ucGxhbmVfcmVzX2wp Owo+ID4gKwkJfQo+ID4gKwo+ID4gKwkJLyogRERCICovCj4gPiArCQlod19kZGJfZW50cnkgPSAm aHdfZGRiLnBsYW5lW3BpcGVdW1BMQU5FX0NVUlNPUl07Cj4gPiArCQlzd19kZGJfZW50cnkgPSAm c3dfZGRiLT5wbGFuZVtwaXBlXVtQTEFORV9DVVJTT1JdOwo+ID4gwqAKPiA+IC0JCWlmICghc2ts X2RkYl9lbnRyeV9lcXVhbChod19lbnRyeSwgc3dfZW50cnkpKSB7Cj4gPiArCQlpZiAoIXNrbF9k ZGJfZW50cnlfZXF1YWwoaHdfZGRiX2VudHJ5LAo+ID4gc3dfZGRiX2VudHJ5KSkgewo+ID4gwqAJ CQlEUk1fRVJST1IoIm1pc21hdGNoIGluIEREQiBzdGF0ZSBwaXBlICVjCj4gPiBjdXJzb3IgIgo+ ID4gwqAJCQkJwqDCoCIoZXhwZWN0ZWQgKCV1LCV1KSwgZm91bmQKPiA+ICgldSwldSkpXG4iLAo+ ID4gwqAJCQkJwqDCoHBpcGVfbmFtZShwaXBlKSwKPiA+IC0JCQkJwqDCoHN3X2VudHJ5LT5zdGFy dCwgc3dfZW50cnktPmVuZCwKPiA+IC0JCQkJwqDCoGh3X2VudHJ5LT5zdGFydCwgaHdfZW50cnkt PmVuZCk7Cj4gPiArCQkJCcKgwqBzd19kZGJfZW50cnktPnN0YXJ0LAo+ID4gc3dfZGRiX2VudHJ5 LQo+ID4gPiAKPiA+ID4gZW5kLAo+ID4gKwkJCQnCoMKgaHdfZGRiX2VudHJ5LT5zdGFydCwKPiA+ IGh3X2RkYl9lbnRyeS0KPiA+ID4gCj4gPiA+IGVuZCk7Cj4gPiDCoAkJfQo+ID4gwqAJfQo+ID4g wqB9Cj4gX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KPiBJ bnRlbC1nZnggbWFpbGluZyBsaXN0Cj4gSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwo+ IGh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4 Cl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkludGVsLWdm eCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xp c3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo=