dri-devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Philipp Zabel <p.zabel@pengutronix.de>
To: Ying Liu <gnuiyl@gmail.com>
Cc: kernel@pengutronix.de, DRI Development <dri-devel@lists.freedesktop.org>
Subject: Re: [PATCH 7/9] gpu: ipu-v3: add YUV 4:4:4 support
Date: Wed, 19 Oct 2016 11:30:37 +0200	[thread overview]
Message-ID: <1476869437.3054.19.camel@pengutronix.de> (raw)
In-Reply-To: <CAOcKUNUirROvFGnd4VNMjjtK95Q=oFqcqWZMFFDUDdWfvtzhSA@mail.gmail.com>

Am Mittwoch, den 19.10.2016, 15:47 +0800 schrieb Ying Liu:
> On Wed, Oct 19, 2016 at 12:07 AM, Philipp Zabel <p.zabel@pengutronix.de> wrote:
> > The IDMAC does support reading and writing DRM_FORMAT_YUV444 and
> > DRM_FORMAT_YVU444.
> >
> > Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
> > ---
> >  drivers/gpu/ipu-v3/ipu-common.c |  2 ++
> >  drivers/gpu/ipu-v3/ipu-cpmem.c  | 17 +++++++++++++++++
> >  2 files changed, 19 insertions(+)
> >
> > diff --git a/drivers/gpu/ipu-v3/ipu-common.c b/drivers/gpu/ipu-v3/ipu-common.c
> > index b9539f7..b7d7bd6 100644
> > --- a/drivers/gpu/ipu-v3/ipu-common.c
> > +++ b/drivers/gpu/ipu-v3/ipu-common.c
> > @@ -88,6 +88,8 @@ enum ipu_color_space ipu_drm_fourcc_to_colorspace(u32 drm_fourcc)
> >         case DRM_FORMAT_YVU420:
> >         case DRM_FORMAT_YUV422:
> >         case DRM_FORMAT_YVU422:
> > +       case DRM_FORMAT_YUV444:
> > +       case DRM_FORMAT_YVU444:
> >         case DRM_FORMAT_NV12:
> >         case DRM_FORMAT_NV21:
> >         case DRM_FORMAT_NV16:
> > diff --git a/drivers/gpu/ipu-v3/ipu-cpmem.c b/drivers/gpu/ipu-v3/ipu-cpmem.c
> > index e6b8bae..4db7475 100644
> > --- a/drivers/gpu/ipu-v3/ipu-cpmem.c
> > +++ b/drivers/gpu/ipu-v3/ipu-cpmem.c
> > @@ -445,6 +445,16 @@ void ipu_cpmem_set_yuv_planar(struct ipuv3_channel *ch,
> >                 v_offset = stride * height;
> >                 u_offset = v_offset + (uv_stride * height);
> >                 break;
> > +       case DRM_FORMAT_YUV444:
> > +               uv_stride = stride;
> > +               u_offset = stride * height;
> > +               v_offset = u_offset + (uv_stride * height);
> > +               break;
> > +       case DRM_FORMAT_YVU444:
> > +               uv_stride = stride;
> > +               v_offset = stride * height;
> > +               u_offset = v_offset + (uv_stride * height);
> > +               break;
> 
> This function can be removed probably as I mentioned in comments
> for patch 6/9.
> 
> With that addressed:
> Acked-by: Liu Ying <gnuiyl@gmail.com>
> 
> Regards,
> Liu Ying

I'll remove the unused function.

regards
Philipp

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

  reply	other threads:[~2016-10-19  9:30 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-18 16:07 [PATCH 1/9] drm/imx: ipuv3-plane: make sure x/y offsets are even in case of chroma subsampling Philipp Zabel
2016-10-18 16:07 ` [PATCH 2/9] drm/imx: ipuv3-plane: disable local alpha for planes without alpha channel Philipp Zabel
2016-10-19  7:17   ` Ying Liu
2016-10-18 16:07 ` [PATCH 3/9] drm/imx: ipuv3-plane: request modeset if plane offsets changed Philipp Zabel
2016-10-19  7:19   ` Ying Liu
2016-10-18 16:07 ` [PATCH 4/9] drm/imx: ipuv3-plane: merge ipu_plane_atomic_set_base into atomic_update Philipp Zabel
2016-10-19  7:20   ` Ying Liu
2016-10-18 16:07 ` [PATCH 5/9] drm/imx: ipuv3-plane: let drm_plane_state_to_ubo/vbo handle chroma subsampling other than 4:2:0 Philipp Zabel
2016-10-19  7:42   ` Ying Liu
2016-10-18 16:07 ` [PATCH 6/9] gpu: ipu-cpmem: Add missing YVU422 case to ipu_cpmem_set_yuv_planar Philipp Zabel
2016-10-19  7:44   ` Ying Liu
2016-10-18 16:07 ` [PATCH 7/9] gpu: ipu-v3: add YUV 4:4:4 support Philipp Zabel
2016-10-19  7:47   ` Ying Liu
2016-10-19  9:30     ` Philipp Zabel [this message]
2016-10-18 16:07 ` [PATCH 8/9] drm/imx: ipuv3-plane: add support for YUV 4:2:2 and 4:4:4, NV12, and NV16 formats Philipp Zabel
2016-10-19  7:49   ` Ying Liu
2016-10-19  9:33     ` Philipp Zabel
2016-10-18 16:07 ` [PATCH 9/9] gpu: ipu-v3: initially clear all interrupts Philipp Zabel
2016-10-19  7:50   ` Ying Liu
2016-10-19  7:12 ` [PATCH 1/9] drm/imx: ipuv3-plane: make sure x/y offsets are even in case of chroma subsampling Ying Liu
2016-10-19  9:30   ` Philipp Zabel
2016-10-19  7:58 ` Ville Syrjälä
2016-10-19  9:30   ` Philipp Zabel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1476869437.3054.19.camel@pengutronix.de \
    --to=p.zabel@pengutronix.de \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=gnuiyl@gmail.com \
    --cc=kernel@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox