dri-devel.lists.freedesktop.org archive mirror
 help / color / mirror / Atom feed
From: Stefan Christ <contact@stefanchrist.eu>
To: dri-devel@lists.freedesktop.org
Subject: [PATCH v2 18/18] drm/gma500: use DRM_FB_HELPER_DEFAULT_OPS for fb_ops
Date: Mon, 14 Nov 2016 00:03:28 +0100	[thread overview]
Message-ID: <1479078208-25221-19-git-send-email-contact@stefanchrist.eu> (raw)
In-Reply-To: <1479078208-25221-1-git-send-email-contact@stefanchrist.eu>

This refactoring leads to real functional changes in the driver.

Now the struct psbfb_ops implements two additional members:

       .fb_setcmap     = drm_fb_helper_setcmap,
       .fb_pan_display = drm_fb_helper_pan_display,

and the struct psbfb_roll_ops implements one additional member:

       .fb_setcmap     = drm_fb_helper_setcmap,

and the struct psbfb_unaccel_ops implements two additional members:

       .fb_setcmap     = drm_fb_helper_setcmap,
       .fb_pan_display = drm_fb_helper_pan_display,

These changes are not tested.

Cc: Patrik Jakobsson <patrik.r.jakobsson@gmail.com>
Signed-off-by: Stefan Christ <contact@stefanchrist.eu>
---
 drivers/gpu/drm/gma500/framebuffer.c | 12 +++---------
 1 file changed, 3 insertions(+), 9 deletions(-)

diff --git a/drivers/gpu/drm/gma500/framebuffer.c b/drivers/gpu/drm/gma500/framebuffer.c
index 3a44e70..1bd156e 100644
--- a/drivers/gpu/drm/gma500/framebuffer.c
+++ b/drivers/gpu/drm/gma500/framebuffer.c
@@ -185,9 +185,7 @@ static int psbfb_mmap(struct fb_info *info, struct vm_area_struct *vma)
 
 static struct fb_ops psbfb_ops = {
 	.owner = THIS_MODULE,
-	.fb_check_var = drm_fb_helper_check_var,
-	.fb_set_par = drm_fb_helper_set_par,
-	.fb_blank = drm_fb_helper_blank,
+	DRM_FB_HELPER_DEFAULT_OPS,
 	.fb_setcolreg = psbfb_setcolreg,
 	.fb_fillrect = drm_fb_helper_cfb_fillrect,
 	.fb_copyarea = psbfb_copyarea,
@@ -198,9 +196,7 @@ static struct fb_ops psbfb_ops = {
 
 static struct fb_ops psbfb_roll_ops = {
 	.owner = THIS_MODULE,
-	.fb_check_var = drm_fb_helper_check_var,
-	.fb_set_par = drm_fb_helper_set_par,
-	.fb_blank = drm_fb_helper_blank,
+	DRM_FB_HELPER_DEFAULT_OPS,
 	.fb_setcolreg = psbfb_setcolreg,
 	.fb_fillrect = drm_fb_helper_cfb_fillrect,
 	.fb_copyarea = drm_fb_helper_cfb_copyarea,
@@ -211,9 +207,7 @@ static struct fb_ops psbfb_roll_ops = {
 
 static struct fb_ops psbfb_unaccel_ops = {
 	.owner = THIS_MODULE,
-	.fb_check_var = drm_fb_helper_check_var,
-	.fb_set_par = drm_fb_helper_set_par,
-	.fb_blank = drm_fb_helper_blank,
+	DRM_FB_HELPER_DEFAULT_OPS,
 	.fb_setcolreg = psbfb_setcolreg,
 	.fb_fillrect = drm_fb_helper_cfb_fillrect,
 	.fb_copyarea = drm_fb_helper_cfb_copyarea,
-- 
2.7.3

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

  parent reply	other threads:[~2016-11-13 23:24 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-13 23:03 [PATCH v2 00/18] Introduce DRM_FB_HELPER_DEFAULT_OPS for struct fb_ops Stefan Christ
2016-11-13 23:03 ` [PATCH v2 01/18] drm/fb-helper: fix segfaults in drm_fb_helper_debug_* Stefan Christ
2016-11-13 23:03 ` [PATCH v2 02/18] drm/fb-helper: add fb_debug_* to DRM_FB_HELPER_DEFAULT_OPS Stefan Christ
2016-11-13 23:03 ` [PATCH v2 03/18] drm/amdgpu: use DRM_FB_HELPER_DEFAULT_OPS for fb_ops Stefan Christ
2016-11-13 23:03 ` [PATCH v2 04/18] drm/armada: " Stefan Christ
2016-11-13 23:03 ` [PATCH v2 05/18] drm/bochs: " Stefan Christ
2016-11-13 23:03 ` [PATCH v2 06/18] drm/fb_cma_helper: " Stefan Christ
2016-11-13 23:03 ` [PATCH v2 07/18] drm/exynos: " Stefan Christ
2016-11-13 23:03 ` [PATCH v2 08/18] drm/nouveau: " Stefan Christ
2016-11-13 23:03 ` [PATCH v2 09/18] drm/qxl: " Stefan Christ
2016-11-13 23:03 ` [PATCH v2 10/18] drm/rockchip: " Stefan Christ
2016-11-13 23:03 ` [PATCH v2 11/18] drm/radeon: " Stefan Christ
2016-11-13 23:03 ` [PATCH v2 12/18] drm/tegra: " Stefan Christ
2016-11-13 23:03 ` [PATCH v2 13/18] drm/udl: " Stefan Christ
2016-11-13 23:03 ` [PATCH v2 14/18] drm/msm: " Stefan Christ
2016-11-13 23:03 ` [PATCH v2 15/18] drm/virtio: " Stefan Christ
2016-11-13 23:03 ` [PATCH v2 16/18] drm/omapdrm: " Stefan Christ
2016-11-13 23:03 ` [PATCH v2 17/18] drm/i915: " Stefan Christ
2016-11-13 23:03 ` Stefan Christ [this message]
2016-11-14  7:02 ` [PATCH v2 00/18] Introduce DRM_FB_HELPER_DEFAULT_OPS for struct fb_ops Daniel Vetter
2016-11-14  9:43 ` Christian König
2016-11-14 12:37   ` Stefan Christ

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1479078208-25221-19-git-send-email-contact@stefanchrist.eu \
    --to=contact@stefanchrist.eu \
    --cc=dri-devel@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).