From: Lucas Stach <l.stach@pengutronix.de>
To: Dave Jiang <dave.jiang@intel.com>
Cc: daniel.vetter@ffwll.ch, linux@armlinux.org.uk,
dri-devel@lists.freedesktop.org,
Fabio Estevam <fabio.estevam@nxp.com>,
akpm@linux-foundation.org
Subject: Re: [PATCH] drm: Fix the .fault functions
Date: Thu, 26 Jan 2017 17:36:19 +0100 [thread overview]
Message-ID: <1485448579.28751.6.camel@pengutronix.de> (raw)
In-Reply-To: <f16181c3-333f-abd2-0338-32a785ec78e9@intel.com>
Am Donnerstag, den 26.01.2017, 09:29 -0700 schrieb Dave Jiang:
>
> On 01/26/2017 06:36 AM, Fabio Estevam wrote:
> > Commit 25d3db7600b87a4 ("mm, fs: reduce fault, page_mkwrite, and
> > pfn_mkwrite to take only vmf") causes the following build failure with
> > arm allmodconfig:
> >
> > drivers/gpu/drm/armada/armada_gem.c:38:11: error: initialization from incompatible pointer type [-Werror=incompatible-pointer-types]
> > drivers/gpu/drm/etnaviv/etnaviv_drv.c:474:11: error: initialization from incompatible pointer type [-Werror=incompatible-pointer-types]
> > drivers/gpu/drm/etnaviv/etnaviv_gem.c:178:5: error: conflicting types for 'etnaviv_gem_fault'
> > drivers/gpu/drm/omapdrm/omap_drv.c:787:11: error: initialization from incompatible pointer type [-Werror=incompatible-pointer-types]
> > drivers/gpu/drm/omapdrm/omap_gem.c:531:5: error: conflicting types for 'omap_gem_fault'
> >
> > Fix the conversion in some drm drivers.
> >
> > Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>
>
> Thanks for catching!
>
> Acked-by: Dave Jiang <dave.jiang@intel.com>
NACK, there is already a more complete fix from Arnd:
"[PATCH] fixup! mm, fs: reduce fault, page_mkwrite, and pfn_mkwrite to take only vmf"
Regards,
Lucas
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
prev parent reply other threads:[~2017-01-26 16:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-26 13:36 [PATCH] drm: Fix the .fault functions Fabio Estevam
2017-01-26 16:29 ` Dave Jiang
2017-01-26 16:36 ` Lucas Stach [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1485448579.28751.6.camel@pengutronix.de \
--to=l.stach@pengutronix.de \
--cc=akpm@linux-foundation.org \
--cc=daniel.vetter@ffwll.ch \
--cc=dave.jiang@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=fabio.estevam@nxp.com \
--cc=linux@armlinux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox