From: Philipp Zabel <p.zabel@pengutronix.de>
To: Shawn Guo <shawnguo@kernel.org>
Cc: Neil Armstrong <narmstrong@baylibre.com>,
Daniel Vetter <daniel.vetter@ffwll.ch>,
Liviu Dudau <liviu.dudau@arm.com>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Daniel Vetter <daniel.vetter@intel.com>,
Marek Vasut <marex@denx.de>,
Alexey Brodkin <abrodkin@synopsys.com>,
Russell King <linux@armlinux.org.uk>,
Xinliang Liu <z.liuxinliang@hisilicon.com>,
Tomi Valkeinen <tomi.valkeinen@ti.com>,
Mali DP Maintainers <malidp@foss.arm.com>,
Ben Skeggs <bskeggs@redhat.com>, Jyri Sarha <jsarha@ti.com>,
dri-devel@lists.freedesktop.org,
Maxime Ripard <maxime.ripard@free-electrons.com>
Subject: Re: [PATCH v3 12/23] drm: imx: remove struct imx_drm_crtc and imx_drm_crtc_helper_funcs
Date: Tue, 07 Feb 2017 11:10:04 +0100 [thread overview]
Message-ID: <1486462204.2277.56.camel@pengutronix.de> (raw)
In-Reply-To: <1486458995-31018-13-git-send-email-shawnguo@kernel.org>
Hi Shawn,
On Tue, 2017-02-07 at 17:16 +0800, Shawn Guo wrote:
> From: Shawn Guo <shawn.guo@linaro.org>
>
> With the vblank hooks in struct drm_crtc_funcs, we do not need to
> maintain the CRTC specific vblank callbacks with struct
> imx_drm_crtc_helper_funcs any more. By moving the stuff that we
> currently do in imx_drm_add_crtc(), like of_node setting and
> drm_crtc_helper_add()/drm_crtc_init_with_planes() invoking, we can kill
> things like struct imx_drm_crtc, imx_drm_crtc_helper_funcs and related
> functions completely.
Thanks for removing the imx_drm_crtc indirection.
> Functions ipu_enable_vblank() and ipu_disable_vblank() are moved around
> without changes, only for saving the forward declarations.
>
> Signed-off-by: Shawn Guo <shawn.guo@linaro.org>
> Cc: Philipp Zabel <p.zabel@pengutronix.de>
Acked-by: Philipp Zabel <p.zabel@pengutronix.de>
regards
Philipp
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2017-02-07 10:11 UTC|newest]
Thread overview: 68+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-07 9:16 [PATCH v3 00/23] Add vblank hooks to struct drm_crtc_funcs Shawn Guo
2017-02-07 9:16 ` [PATCH v3 01/23] drm: add " Shawn Guo
2017-02-07 10:38 ` Andrzej Hajda
2017-02-07 10:52 ` Daniel Vetter
2017-02-07 11:50 ` Thierry Reding
2017-02-07 11:04 ` Thierry Reding
2017-02-07 14:01 ` Laurent Pinchart
2017-02-07 9:16 ` [PATCH v3 02/23] drm: remove drm_vblank_no_hw_counter assignment from driver code Shawn Guo
2017-02-07 9:27 ` Maxime Ripard
2017-02-07 9:46 ` Boris Brezillon
2017-02-07 10:09 ` Neil Armstrong
2017-02-07 10:22 ` Russell King - ARM Linux
2017-02-07 10:42 ` Laurent Pinchart
2017-02-07 10:44 ` Russell King - ARM Linux
2017-02-07 10:58 ` Laurent Pinchart
2017-02-07 11:01 ` Thierry Reding
2017-02-07 11:54 ` Alexey Brodkin
2017-02-07 15:21 ` Liviu Dudau
2017-02-08 19:58 ` Eric Anholt
2017-02-07 9:16 ` [PATCH v3 03/23] drm: unexport function drm_vblank_no_hw_counter() Shawn Guo
2017-02-07 10:56 ` Laurent Pinchart
2017-02-07 9:16 ` [PATCH v3 04/23] drm: hdlcd: use vblank hooks in struct drm_crtc_funcs Shawn Guo
2017-02-07 9:16 ` [PATCH v3 05/23] drm: malidp: " Shawn Guo
2017-02-07 15:22 ` Liviu Dudau
2017-02-07 9:16 ` [PATCH v3 06/23] drm: armada: " Shawn Guo
2017-02-07 10:23 ` Russell King - ARM Linux
2017-02-07 9:16 ` [PATCH v3 07/23] drm: atmel: " Shawn Guo
2017-02-07 9:46 ` Boris Brezillon
2017-02-07 9:16 ` [PATCH v3 08/23] drm: exynos: " Shawn Guo
2017-02-07 10:47 ` Andrzej Hajda
2017-02-07 9:16 ` [PATCH v3 09/23] drm: fsl-dcu: " Shawn Guo
2017-02-08 5:01 ` Stefan Agner
2017-02-08 12:04 ` Daniel Vetter
2017-02-07 9:16 ` [PATCH v3 10/23] drm: hibmc: " Shawn Guo
2017-02-08 15:39 ` Sean Paul
2017-02-16 3:28 ` Xinliang Liu
2017-02-07 9:16 ` [PATCH v3 11/23] drm: kirin: " Shawn Guo
2017-02-16 3:23 ` Xinliang Liu
2017-02-21 16:20 ` Sean Paul
2017-02-07 9:16 ` [PATCH v3 12/23] drm: imx: remove struct imx_drm_crtc and imx_drm_crtc_helper_funcs Shawn Guo
2017-02-07 10:10 ` Philipp Zabel [this message]
2017-02-07 9:16 ` [PATCH v3 13/23] drm: mediatek: use vblank hooks in struct drm_crtc_funcs Shawn Guo
2017-02-21 16:21 ` Sean Paul
2017-02-07 9:16 ` [PATCH v3 14/23] drm: meson: " Shawn Guo
2017-02-07 10:09 ` Neil Armstrong
2017-02-07 9:16 ` [PATCH v3 15/23] drm: qxl: " Shawn Guo
2017-02-21 16:21 ` Sean Paul
2017-02-07 9:16 ` [PATCH v3 16/23] drm: rcar-du: " Shawn Guo
2017-02-07 14:03 ` Laurent Pinchart
2017-02-07 9:16 ` [PATCH v3 17/23] drm: rockchip: remove struct rockchip_crtc_funcs Shawn Guo
2017-02-07 15:35 ` Sean Paul
2017-02-07 9:16 ` [PATCH v3 18/23] drm: shmobile: use vblank hooks in struct drm_crtc_funcs Shawn Guo
2017-02-07 14:05 ` Laurent Pinchart
2017-02-07 9:16 ` [PATCH v3 19/23] drm: sun4i: " Shawn Guo
2017-02-07 9:28 ` Maxime Ripard
2017-02-07 9:16 ` [PATCH v3 20/23] drm: tegra: " Shawn Guo
2017-02-07 11:02 ` Thierry Reding
2017-02-07 9:16 ` [PATCH v3 21/23] drm: tilcdc: " Shawn Guo
2017-02-07 9:38 ` Jyri Sarha
2017-02-07 9:16 ` [PATCH v3 22/23] drm: vc4: " Shawn Guo
2017-02-08 19:56 ` Eric Anholt
2017-02-07 9:16 ` [PATCH v3 23/23] drm: zte: " Shawn Guo
2017-02-07 15:34 ` Sean Paul
2017-02-08 11:30 ` [PATCH v3 00/23] Add vblank hooks to " Tomi Valkeinen
2017-02-08 18:10 ` Laurent Pinchart
2017-02-08 18:24 ` Daniel Vetter
2017-02-08 15:49 ` Sean Paul
2017-02-09 8:36 ` Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1486462204.2277.56.camel@pengutronix.de \
--to=p.zabel@pengutronix.de \
--cc=abrodkin@synopsys.com \
--cc=bskeggs@redhat.com \
--cc=daniel.vetter@ffwll.ch \
--cc=daniel.vetter@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=jsarha@ti.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux@armlinux.org.uk \
--cc=liviu.dudau@arm.com \
--cc=malidp@foss.arm.com \
--cc=marex@denx.de \
--cc=maxime.ripard@free-electrons.com \
--cc=narmstrong@baylibre.com \
--cc=shawnguo@kernel.org \
--cc=tomi.valkeinen@ti.com \
--cc=z.liuxinliang@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).