From: Philipp Zabel <p.zabel@pengutronix.de>
To: Fabio Estevam <fabio.estevam@nxp.com>
Cc: "# 4 . 8+" <stable@vger.kernel.org>, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH v2] drm/imx: imx-tve: Do not set the regulator voltage
Date: Thu, 09 Feb 2017 12:10:58 +0100 [thread overview]
Message-ID: <1486638658.2284.27.camel@pengutronix.de> (raw)
In-Reply-To: <1486558069-22421-1-git-send-email-fabio.estevam@nxp.com>
On Wed, 2017-02-08 at 10:47 -0200, Fabio Estevam wrote:
> Commit deb65870b5d9d ("drm/imx: imx-tve: check the value returned by
> regulator_set_voltage()") exposes the following probe issue:
>
> 63ff0000.tve supply dac not found, using dummy regulator
> imx-drm display-subsystem: failed to bind 63ff0000.tve (ops imx_tve_ops): -22
>
> When the 'dac-supply' is not passed in the device tree a dummy regulator is
> used and setting its voltage is not allowed.
>
> To fix this issue, do not set the dac-supply voltage inside the driver
> and let its voltage be specified in the device tree.
>
> Print a warning if the the 'dac-supply' voltage has a value different
> from 2.75V.
>
> Fixes: deb65870b5d9d ("drm/imx: imx-tve: check the value returned by regulator_set_voltage()")
> Cc: <stable@vger.kernel.org> # 4.8+
> Suggested-by: Lucas Stach <l.stach@pengutronix.de>
> Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>
Thanks, I've applied this instead of the devm_regulator_get_optional
patch.
regards
Philipp
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
prev parent reply other threads:[~2017-02-09 11:11 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-08 12:47 [PATCH v2] drm/imx: imx-tve: Do not set the regulator voltage Fabio Estevam
2017-02-09 11:10 ` Philipp Zabel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1486638658.2284.27.camel@pengutronix.de \
--to=p.zabel@pengutronix.de \
--cc=dri-devel@lists.freedesktop.org \
--cc=fabio.estevam@nxp.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).