Re: [PATCH 2/2] drm/i915: Avoid decomposing a signal-on-any fence-array

From: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>,
	intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH 2/2] drm/i915: Avoid decomposing a signal-on-any fence-array
Date: Mon, 20 Feb 2017 13:32:42 +0200	[thread overview]
Message-ID: <1487590362.3454.34.camel@linux.intel.com> (raw)
In-Reply-To: <20170217183536.26100-2-chris@chris-wilson.co.uk>

On pe, 2017-02-17 at 18:35 +0000, Chris Wilson wrote:
> The code currently assumes that all fence arrays it sees are the normal
> signal-on-all variety, and decomposes the array into its individual
> fences so that it can extract the native i915 fences. If the fence array
> is using signal-on-any, we should not decompose as we must not wait on
> them all, just the first in *that* set.
> 
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> CC: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
> Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>

<SNIP>

> 
> @@ -696,7 +696,8 @@ i915_gem_request_await_dma_fence(struct drm_i915_gem_request *req,
>  	if (dma_fence_is_i915(fence))
>  		return i915_gem_request_await_request(req, to_request(fence));
>  
> -	if (!dma_fence_is_array(fence)) {
> +	if (!dma_fence_is_array(fence) ||
> +	    test_bit(DMA_FENCE_ARRAY_SIGNAL_ANY, &fence->flags)) {

Smells like a helper function? While that helper is finding the way
upstream;

Reviewed-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>

Regards, Joonas
-- 
Joonas Lahtinen
Open Source Technology Center
Intel Corporation
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx