From: Lucas Stach <l.stach@pengutronix.de>
To: Philipp Zabel <p.zabel@pengutronix.de>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>,
Russell King <linux@arm.linux.org.uk>,
kernel@pengutronix.de, dri-devel@lists.freedesktop.org,
Dan MacDonald <allcoms@gmail.com>
Subject: Re: [PATCH v3 3/4] drm/imx: don't wait for vblank and stop calling cleanup_planes in commit_tail
Date: Tue, 07 Mar 2017 18:57:21 +0100 [thread overview]
Message-ID: <1488909441.32329.24.camel@pengutronix.de> (raw)
In-Reply-To: <20170228141837.22949-4-p.zabel@pengutronix.de>
Am Dienstag, den 28.02.2017, 15:18 +0100 schrieb Philipp Zabel:
> drm_atomic_helper_cleanup_planes only calls the cleanup_fb plane
> helpers, which we don't implement as a CMA framebuffer based driver.
> There is no reason to wait for vblanks in commit_tail only to do nothing
> afterwards.
>
> Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
Reviewed-by: Lucas Stach <l.stach@pengutronix.de>
> ---
> Changes since v2:
> - New patch that removes wait_for_vblanks and cleanup_planes instead
> of reordering commit_hw_done and wait_for_vblanks.
> ---
> drivers/gpu/drm/imx/imx-drm-core.c | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/imx/imx-drm-core.c b/drivers/gpu/drm/imx/imx-drm-core.c
> index f562cb7964b08..0a5e4fbb906bf 100644
> --- a/drivers/gpu/drm/imx/imx-drm-core.c
> +++ b/drivers/gpu/drm/imx/imx-drm-core.c
> @@ -170,10 +170,6 @@ static void imx_drm_atomic_commit_tail(struct drm_atomic_state *state)
> drm_atomic_helper_commit_modeset_enables(dev, state);
>
> drm_atomic_helper_commit_hw_done(state);
> -
> - drm_atomic_helper_wait_for_vblanks(dev, state);
> -
> - drm_atomic_helper_cleanup_planes(dev, state);
> }
>
> static struct drm_mode_config_helper_funcs imx_drm_mode_config_helpers = {
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2017-03-07 17:57 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-28 14:18 [PATCH v3 0/4] Fix DP busy wait and defer disabling overlay plane Philipp Zabel
2017-02-28 14:18 ` [PATCH v3 1/4] gpu: ipu-v3: remove IRQ dance on DC channel disable Philipp Zabel
2017-03-03 19:11 ` Dan MacDonald
2017-02-28 14:18 ` [PATCH v3 2/4] gpu: ipu-v3: add unsynchronised DP channel disabling Philipp Zabel
2017-02-28 14:18 ` [PATCH v3 3/4] drm/imx: don't wait for vblank and stop calling cleanup_planes in commit_tail Philipp Zabel
2017-03-07 17:57 ` Lucas Stach [this message]
2017-02-28 14:18 ` [PATCH v3 4/4] drm/imx: add deferred plane disabling Philipp Zabel
2017-03-07 18:00 ` Lucas Stach
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1488909441.32329.24.camel@pengutronix.de \
--to=l.stach@pengutronix.de \
--cc=allcoms@gmail.com \
--cc=daniel.vetter@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=kernel@pengutronix.de \
--cc=linux@arm.linux.org.uk \
--cc=p.zabel@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).