From: Philipp Zabel <p.zabel@pengutronix.de>
To: Gustavo Padovan <gustavo@padovan.org>
Cc: etnaviv@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
Russell King <linux+etnaviv@armlinux.org.uk>
Subject: Re: [PATCH 3/3] drm/etnaviv: submit support for out-fences
Date: Mon, 13 Mar 2017 11:57:00 +0100 [thread overview]
Message-ID: <1489402620.2288.27.camel@pengutronix.de> (raw)
In-Reply-To: <20170308144845.GC2346@joana>
On Wed, 2017-03-08 at 11:48 -0300, Gustavo Padovan wrote:
[...]
> > @@ -437,10 +447,25 @@ int etnaviv_ioctl_gem_submit(struct drm_device *dev, void *data,
> > goto out;
> > }
> >
> > + if (args->flags & ETNA_SUBMIT_FENCE_FD_OUT) {
> > + sync_file = sync_file_create(submit->fence);
> > + if (!sync_file) {
> > + dma_fence_put(submit->fence);
> > + submit->fence = NULL;
> > + ret = -ENOMEM;
> > + goto out;
> > + }
> > + }
> > +
> > ret = etnaviv_gpu_submit(gpu, submit, cmdbuf);
> > if (ret == 0)
> > cmdbuf = NULL;
> >
> > + if (args->flags & ETNA_SUBMIT_FENCE_FD_OUT) {
> > + fd_install(out_fence_fd, sync_file->file);
> > + }
>
> Extra braces here.
I'll drop those next time.
> Otherwise looks good to me.
>
> Reviewed-by: Gustavo Padovan <gustavo.padovan@collabora.com>
thanks
Philipp
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2017-03-13 10:57 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-08 12:53 [PATCH 1/3] drm/etnaviv: submit support for in-fences Philipp Zabel
2017-03-08 12:53 ` [PATCH 2/3] drm/etnaviv: move fence allocation out of etnaviv_gpu_submit() Philipp Zabel
2017-03-08 14:42 ` Gustavo Padovan
2017-03-08 18:28 ` Russell King - ARM Linux
2017-03-13 11:01 ` Philipp Zabel
2017-03-13 17:30 ` Gustavo Padovan
2017-03-08 12:53 ` [PATCH 3/3] drm/etnaviv: submit support for out-fences Philipp Zabel
2017-03-08 14:48 ` Gustavo Padovan
2017-03-13 10:57 ` Philipp Zabel [this message]
2017-03-08 14:37 ` [PATCH 1/3] drm/etnaviv: submit support for in-fences Gustavo Padovan
2017-03-13 10:56 ` Philipp Zabel
2017-03-13 17:37 ` Gustavo Padovan
2017-03-16 11:05 ` Philipp Zabel
2017-03-17 14:00 ` Gustavo Padovan
2017-03-17 14:07 ` Philipp Zabel
2017-03-20 8:14 ` Daniel Vetter
2017-03-17 14:10 ` Lucas Stach
2017-03-17 14:42 ` Russell King - ARM Linux
2017-03-17 14:58 ` Lucas Stach
2017-03-17 15:07 ` Russell King - ARM Linux
2017-03-17 16:13 ` Chris Healy
2017-03-18 14:19 ` Christian König
2017-03-19 14:14 ` Lucas Stach
2017-03-16 14:03 ` Rob Clark
2017-03-17 13:55 ` Gustavo Padovan
2017-03-17 14:09 ` Philipp Zabel
2017-03-17 14:26 ` Lucas Stach
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1489402620.2288.27.camel@pengutronix.de \
--to=p.zabel@pengutronix.de \
--cc=dri-devel@lists.freedesktop.org \
--cc=etnaviv@lists.freedesktop.org \
--cc=gustavo@padovan.org \
--cc=linux+etnaviv@armlinux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox