From: Alexey Brodkin <Alexey.Brodkin@synopsys.com>
To: "dri-devel@lists.freedesktop.org"
<dri-devel@lists.freedesktop.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Jose Abreu <Jose.Abreu@synopsys.com>
Cc: Carlos Palminha <CARLOS.PALMINHA@synopsys.com>,
"ville.syrjala@linux.intel.com" <ville.syrjala@linux.intel.com>,
"a.hajda@samsung.com" <a.hajda@samsung.com>,
"architt@codeaurora.org" <architt@codeaurora.org>,
"daniel.vetter@ffwll.ch" <daniel.vetter@ffwll.ch>,
"laurent.pinchart@ideasonboard.com"
<laurent.pinchart@ideasonboard.com>,
"airlied@linux.ie" <airlied@linux.ie>
Subject: Re: [PATCH v4 05/10] drm: arc: Use crtc->mode_valid() callback
Date: Mon, 22 May 2017 18:32:02 +0000 [thread overview]
Message-ID: <1495477922.20961.26.camel@synopsys.com> (raw)
In-Reply-To: <1f6db609f035e6183709e3b7364392c770341724.1495091280.git.joabreu@synopsys.com>
Hi Jose,
The only nitpicking note from my side is patch name.
Probably full driver name as "arcpgu" might give a bit more context
especially if later something else from ARC appears in "drm" folder.
But IMHO that doesn't worth another respin.
On Fri, 2017-05-19 at 01:52 +0100, Jose Abreu wrote:
> Now that we have a callback to check if crtc supports a given mode
> we can use it in arcpgu so that we restrict the number of probbed
> modes to the ones we can actually display.
>
> This is specially useful because arcpgu crtc is responsible to set
> a clock value in the commit() stage but unfortunatelly this clock
> does not support all the needed ranges.
>
> Also, remove the atomic_check() callback as mode_valid() callback
> will be called before.
>
> Signed-off-by: Jose Abreu <joabreu@synopsys.com>
> Cc: Carlos Palminha <palminha@synopsys.com>
> Cc: Alexey Brodkin <abrodkin@synopsys.com>
Reviewed-by: Alexey Brodkin <abrodkin@synopsys.com>
next prev parent reply other threads:[~2017-05-22 18:32 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-19 0:52 [PATCH v4 00/10] Introduce new mode validation callbacks Jose Abreu
2017-05-19 0:52 ` [PATCH v4 01/10] drm: Add drm_{crtc/encoder/connector}_mode_valid() Jose Abreu
2017-05-19 0:52 ` [PATCH v4 02/10] drm: Introduce drm_bridge_mode_valid() Jose Abreu
2017-05-19 0:52 ` [PATCH v4 03/10] drm: Use new mode_valid() helpers in connector probe helper Jose Abreu
2017-05-22 7:54 ` Daniel Vetter
2017-05-19 0:52 ` [PATCH v4 04/10] drm: Use mode_valid() in atomic modeset Jose Abreu
2017-05-19 0:52 ` [PATCH v4 05/10] drm: arc: Use crtc->mode_valid() callback Jose Abreu
2017-05-22 18:32 ` Alexey Brodkin [this message]
2017-05-19 0:52 ` [PATCH v4 06/10] drm/bridge: analogix-anx78xx: Use bridge->mode_valid() callback Jose Abreu
2017-05-19 0:52 ` [PATCH v4 07/10] drm/bridge/synopsys: dw-hdmi: " Jose Abreu
2017-05-24 12:30 ` Neil Armstrong
2017-05-19 0:52 ` [PATCH v4 08/10] drm/arm: malidp: Use crtc->mode_valid() callback Jose Abreu
2017-05-19 0:52 ` [PATCH v4 09/10] drm/atmel-hlcdc: " Jose Abreu
2017-05-19 0:52 ` [PATCH v4 10/10] drm: vc4: Use crtc->mode_valid() and encoder->mode_valid() callbacks Jose Abreu
2017-05-22 7:56 ` [PATCH v4 00/10] Introduce new mode validation callbacks Daniel Vetter
2017-05-22 10:01 ` Jose Abreu
2017-05-22 15:31 ` Daniel Vetter
2017-05-23 14:40 ` Jose Abreu
2017-05-24 12:12 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1495477922.20961.26.camel@synopsys.com \
--to=alexey.brodkin@synopsys.com \
--cc=CARLOS.PALMINHA@synopsys.com \
--cc=Jose.Abreu@synopsys.com \
--cc=a.hajda@samsung.com \
--cc=airlied@linux.ie \
--cc=architt@codeaurora.org \
--cc=daniel.vetter@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).