From: Philipp Zabel <p.zabel@pengutronix.de>
To: Archit Taneja <architt@codeaurora.org>
Cc: Jose Abreu <Jose.Abreu@synopsys.com>,
Daniel Vetter <daniel.vetter@ffwll.ch>,
Carlos Palminha <CARLOS.PALMINHA@synopsys.com>,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
Laurent Pinchart <Laurent.pinchart@ideasonboard.com>,
Kevin Hilman <khilman@baylibre.com>,
Carlo Caione <carlo@caione.org>
Subject: Re: [PATCH v5 07/10] drm/bridge/synopsys: dw-hdmi: Use bridge->mode_valid() callback
Date: Tue, 30 May 2017 12:29:01 +0200 [thread overview]
Message-ID: <1496140141.5485.3.camel@pengutronix.de> (raw)
In-Reply-To: <49c4273c-eb14-da5d-f85d-a3a944f8f9cd@codeaurora.org>
Hi Archit,
On Tue, 2017-05-30 at 15:54 +0530, Archit Taneja wrote:
> Hi,
>
> On 05/25/2017 07:49 PM, Jose Abreu wrote:
> > Now that we have a callback to check if bridge supports a given mode
> > we can use it in Synopsys Designware HDMI bridge so that we restrict
> > the number of probbed modes to the ones we can actually display.
> >
> > Also, there is no need to use mode_fixup() callback as mode_valid()
> > will handle the mode validation.
> >
> > NOTE: Only compile tested
> > NOTE 2: I also had to change the pdata declaration of mode_valid
> > custom callback so that the passed modes are const. I also changed
> > in the platforms I found. Not even compiled it though.
>
> This compiles fine and has been tested on Meson by Neil.
>
> Since this also touches rockchip/imx drm driver files, can I get an
> OK from the maintainers to pull the changes via drm-misc?
Of course,
Acked-by: Philipp Zabel <p.zabel@pengutronix.de>
regards
Philipp
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2017-05-30 10:29 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-25 14:19 [PATCH v5 00/10] Introduce new mode validation callbacks Jose Abreu
2017-05-25 14:19 ` [PATCH v5 01/10] drm: Add drm_{crtc/encoder/connector}_mode_valid() Jose Abreu
2017-05-30 6:38 ` Daniel Vetter
2017-05-30 7:26 ` Neil Armstrong
2017-05-25 14:19 ` [PATCH v5 02/10] drm: Introduce drm_bridge_mode_valid() Jose Abreu
2017-05-26 4:25 ` Archit Taneja
2017-05-30 7:27 ` Neil Armstrong
2017-05-25 14:19 ` [PATCH v5 03/10] drm: Use new mode_valid() helpers in connector probe helper Jose Abreu
2017-05-30 7:27 ` Neil Armstrong
2017-05-25 14:19 ` [PATCH v5 04/10] drm: Use mode_valid() in atomic modeset Jose Abreu
2017-05-29 19:38 ` Daniel Vetter
2017-05-30 7:27 ` Neil Armstrong
2017-05-25 14:19 ` [PATCH v5 05/10] drm: arcpgu: Use crtc->mode_valid() callback Jose Abreu
2017-05-30 7:28 ` Neil Armstrong
2017-06-21 9:38 ` Jose Abreu
2017-06-22 8:46 ` Daniel Vetter
2017-05-25 14:19 ` [PATCH v5 06/10] drm/bridge: analogix-anx78xx: Use bridge->mode_valid() callback Jose Abreu
2017-05-26 4:27 ` Archit Taneja
2017-05-30 7:28 ` Neil Armstrong
2017-05-30 10:35 ` Archit Taneja
2017-05-25 14:19 ` [PATCH v5 07/10] drm/bridge/synopsys: dw-hdmi: " Jose Abreu
2017-05-29 9:45 ` Neil Armstrong
2017-05-30 10:24 ` Archit Taneja
2017-05-30 10:29 ` Philipp Zabel [this message]
2017-06-05 7:53 ` Archit Taneja
2017-05-25 14:19 ` [PATCH v5 08/10] drm/arm: malidp: Use crtc->mode_valid() callback Jose Abreu
2017-05-30 7:29 ` Neil Armstrong
2017-05-30 9:37 ` Liviu Dudau
2017-05-31 8:20 ` Daniel Vetter
2017-05-31 10:48 ` Liviu Dudau
2017-05-31 10:56 ` Daniel Vetter
2017-05-31 11:09 ` Liviu Dudau
2017-05-25 14:19 ` [PATCH v5 09/10] drm/atmel-hlcdc: " Jose Abreu
2017-05-30 7:30 ` Neil Armstrong
2017-06-02 9:35 ` Boris Brezillon
2017-05-25 14:19 ` [PATCH v5 10/10] drm: vc4: Use crtc->mode_valid() and encoder->mode_valid() callbacks Jose Abreu
2017-05-30 7:30 ` Neil Armstrong
2017-06-02 20:10 ` Eric Anholt
2017-06-20 8:47 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1496140141.5485.3.camel@pengutronix.de \
--to=p.zabel@pengutronix.de \
--cc=CARLOS.PALMINHA@synopsys.com \
--cc=Jose.Abreu@synopsys.com \
--cc=Laurent.pinchart@ideasonboard.com \
--cc=architt@codeaurora.org \
--cc=carlo@caione.org \
--cc=daniel.vetter@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=khilman@baylibre.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).