From: Leonard Crestez <leonard.crestez@nxp.com>
To: Philipp Zabel <p.zabel@pengutronix.de>
Cc: David Airlie <airlied@linux.ie>,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] drm/imx: imx-ldb: Accept drm_of_find_panel_or_bridge failure
Date: Wed, 7 Jun 2017 13:35:50 +0300 [thread overview]
Message-ID: <1496831750.28352.62.camel@nxp.com> (raw)
In-Reply-To: <1494424550.2422.5.camel@pengutronix.de>
On Wed, 2017-05-10 at 15:55 +0200, Philipp Zabel wrote:
> On Wed, 2017-05-10 at 16:17 +0300, Leonard Crestez wrote:
> >
> > Not having an endpoint bound in DT should not cause a failure here,
> > there are fallbacks. So explicitly accept a missing endpoint.
> >
> > This behavior change was introduced by refactoring in drm_of parsing
> > code and it should not require dts changes.
> >
> > In particular this fixes imx6qdl-sabreauto boards.
> >
> > diff --git a/drivers/gpu/drm/imx/imx-ldb.c b/drivers/gpu/drm/imx/imx-ldb.c
> > index 8fb801f..8b05ecb 100644
> > --- a/drivers/gpu/drm/imx/imx-ldb.c
> > +++ b/drivers/gpu/drm/imx/imx-ldb.c
> > @@ -673,7 +673,7 @@ static int imx_ldb_bind(struct device *dev, struct device *master, void *data)
> > ret = drm_of_find_panel_or_bridge(child,
> > imx_ldb->lvds_mux ? 4 : 2, 0,
> > &channel->panel, &channel->bridge);
> > - if (ret)
> > + if (ret && ret != -ENODEV)
> > return ret;
> >
> > /* panel ddc only if there is no bridge */
> Thank you, applied to imx-drm/fixes.
>
> regards
> Philipp
How are such fixes going to make their way upstream? It's been almost a
month and this patch did not get into either linux-next or
torvalds/master or anywhere other than pza/imx-drm/fixes.
--
Regards,
Leonard
prev parent reply other threads:[~2017-06-07 10:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-10 13:17 [PATCH v2] drm/imx: imx-ldb: Accept drm_of_find_panel_or_bridge failure Leonard Crestez
2017-05-10 13:55 ` Philipp Zabel
2017-06-07 10:35 ` Leonard Crestez [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1496831750.28352.62.camel@nxp.com \
--to=leonard.crestez@nxp.com \
--cc=airlied@linux.ie \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=p.zabel@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).