From mboxrd@z Thu Jan 1 00:00:00 1970 From: Frediano Ziglio Subject: Re: [PATCH drm/qxl v4 6/7] qxl: Don't notify userspace when monitors config is unchanged Date: Tue, 8 Nov 2016 04:44:22 -0500 (EST) Message-ID: <149734078.9836039.1478598262369.JavaMail.zimbra@redhat.com> References: <20161108091209.25568-1-cfergeau@redhat.com> <20161108091209.25568-7-cfergeau@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20161108091209.25568-7-cfergeau@redhat.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: spice-devel-bounces@lists.freedesktop.org Sender: "Spice-devel" To: Christophe Fergeau Cc: spice-devel@lists.freedesktop.org, Gerd Hoffmann , dri-devel@lists.freedesktop.org, airlied@redhat.com List-Id: dri-devel@lists.freedesktop.org Cj4gV2hlbiB0aGUgUVhMIGRyaXZlciByZWNlaXZlcyBhIFFYTF9JTlRFUlJVUFRfQ0xJRU5UX01P TklUT1JTX0NPTkZJRwo+IGludGVycnVwdCwKPiB3ZSBjdXJyZW50bHkgYWx3YXlzIG5vdGlmeSB1 c2Vyc3BhY2UgdGhhdCB0aGVyZSB3YXMgc29tZSBob3RwbHVnIGV2ZW50Lgo+IAo+IEhvd2V2ZXIs IGdub21lLXNoZWxsL211dHRlciBpcyByZWFjdGluZyB0byB0aGlzIGV2ZW50IGJ5IGF0dGVtcHRp bmcgYQo+IHJlc29sdXRpb24gY2hhbmdlLCB3aGljaCBpdCBkb2VzIGJ5IGlzc3VlaW5nIGRybU1v ZGVSbUZCLCBkcm1Nb2RlQWRkRkIsCj4gYW5kIHRoZW4gZHJtTW9kZVNldENydGMuIFRoaXMgaGFz IHRoZSBzaWRlLWVmZmVjdCBvZiBjYXVzaW5nCj4gcXhsX2NydGNfbW9kZV9zZXQoKSB0byB0ZWxs IHRoZSBRWEwgdmlydHVhbCBoYXJkd2FyZSB0aGF0IGEgcHJpbWFyeQo+IHN1cmZhY2Ugd2FzIGRl c3Ryb3llZCBhbmQgY3JlYXRlZC4gQWZ0ZXIgZ29pbmcgdGhyb3VnaCBRRU1VIGFuZCB0aGVuIHRo ZQo+IHJlbW90ZSBTUElDRSBjbGllbnQsIGEgbmV3IGlkZW50aWNhbCBtb25pdG9ycyBjb25maWcg bWVzc2FnZSB3aWxsIGJlCj4gc2VudCwgcmVzdWx0aW5nIGluIGEgUVhMX0lOVEVSUlVQVF9DTElF TlRfTU9OSVRPUlNfQ09ORklHIGludGVycnVwdCB0bwo+IGJlIGVtaXR0ZWQsIGFuZCB0aGUgc2Ft ZSBzY2VuYXJpbyBvY2N1cnJpbmcgYWdhaW4uCj4gCj4gQXMgZGVzdHJveWluZy9jcmVhdGluZyB0 aGUgcHJpbWFyeSBzdXJmYWNlIGNhdXNlcyBhIHZpc2libGUgc2NyZWVuCj4gZmxpY2tlciwgdGhp cyBtYWtlcyB0aGUgZ3Vlc3QgaGFyZCB0byB1c2UgKAo+IGh0dHBzOi8vYnVnemlsbGEucmVkaGF0 LmNvbS9zaG93X2J1Zy5jZ2k/aWQ9MTI2NjQ4NCApLgo+IAo+IFRoaXMgY29tbWl0IGNoZWNrcyBp ZiB0aGUgc2NyZWVuIGNvbmZpZ3VyYXRpb24gd2UgcmVjZWl2ZWQgaXMgdGhlIHNhbWUKPiBvbmUg YXMgdGhlIGN1cnJlbnQgb25lLCBhbmQgZG9lcyBub3Qgbm90aWZ5IHVzZXJzcGFjZSBhYm91dCBp dCBpZiB0aGF0J3MKPiB0aGUgY2FzZS4KPiAKPiBTaWduZWQtb2ZmLWJ5OiBDaHJpc3RvcGhlIEZl cmdlYXUgPGNmZXJnZWF1QHJlZGhhdC5jb20+Cj4gLS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9xeGwv cXhsX2Rpc3BsYXkuYyB8IDYyCj4gICsrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrLS0t LS0tLQo+ICAxIGZpbGUgY2hhbmdlZCwgNTIgaW5zZXJ0aW9ucygrKSwgMTAgZGVsZXRpb25zKC0p Cj4gCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9xeGwvcXhsX2Rpc3BsYXkuYwo+IGIv ZHJpdmVycy9ncHUvZHJtL3F4bC9xeGxfZGlzcGxheS5jCj4gaW5kZXggOGNmNTE3Ny4uNTE4MzMz YyAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vcXhsL3F4bF9kaXNwbGF5LmMKPiArKysg Yi9kcml2ZXJzL2dwdS9kcm0vcXhsL3F4bF9kaXNwbGF5LmMKPiBAQCAtNTcsMTEgKzU3LDE4IEBA IHN0YXRpYyB2b2lkIHF4bF9hbGxvY19jbGllbnRfbW9uaXRvcnNfY29uZmlnKHN0cnVjdAo+IHF4 bF9kZXZpY2UgKnFkZXYsIHVuc2lnbmVkIGMKPiAgCXFkZXYtPmNsaWVudF9tb25pdG9yc19jb25m aWctPmNvdW50ID0gY291bnQ7Cj4gIH0KPiAgCj4gK2VudW0gewo+ICsJTU9OSVRPUlNfQ09ORklH X01PRElGSUVELAo+ICsJTU9OSVRPUlNfQ09ORklHX1VOQ0hBTkdFRCwKPiArCU1PTklUT1JTX0NP TkZJR19CQURfQ1JDLAo+ICt9Owo+ICsKPiAgc3RhdGljIGludCBxeGxfZGlzcGxheV9jb3B5X3Jv bV9jbGllbnRfbW9uaXRvcnNfY29uZmlnKHN0cnVjdCBxeGxfZGV2aWNlCj4gICpxZGV2KQo+ICB7 Cj4gIAlpbnQgaTsKPiAgCWludCBudW1fbW9uaXRvcnM7Cj4gIAl1aW50MzJfdCBjcmM7Cj4gKwlp bnQgc3RhdHVzID0gTU9OSVRPUlNfQ09ORklHX1VOQ0hBTkdFRDsKPiAgCj4gIAludW1fbW9uaXRv cnMgPSBxZGV2LT5yb20tPmNsaWVudF9tb25pdG9yc19jb25maWcuY291bnQ7Cj4gIAljcmMgPSBj cmMzMigwLCAoY29uc3QgdWludDhfdCAqKSZxZGV2LT5yb20tPmNsaWVudF9tb25pdG9yc19jb25m aWcsCj4gQEAgLTcwLDcgKzc3LDcgQEAgc3RhdGljIGludAo+IHF4bF9kaXNwbGF5X2NvcHlfcm9t X2NsaWVudF9tb25pdG9yc19jb25maWcoc3RydWN0IHF4bF9kZXZpY2UgKnFkZXYpCj4gIAkJcXhs X2lvX2xvZyhxZGV2LCAiY3JjIG1pc21hdGNoOiBoYXZlICVYICglemQpICE9ICVYXG4iLCBjcmMs Cj4gIAkJCSAgIHNpemVvZihxZGV2LT5yb20tPmNsaWVudF9tb25pdG9yc19jb25maWcpLAo+ICAJ CQkgICBxZGV2LT5yb20tPmNsaWVudF9tb25pdG9yc19jb25maWdfY3JjKTsKPiAtCQlyZXR1cm4g MTsKPiArCQlyZXR1cm4gTU9OSVRPUlNfQ09ORklHX0JBRF9DUkM7Cj4gIAl9Cj4gIAlpZiAobnVt X21vbml0b3JzID4gcWRldi0+bW9uaXRvcnNfY29uZmlnLT5tYXhfYWxsb3dlZCkgewo+ICAJCURS TV9ERUJVR19LTVMoImNsaWVudCBtb25pdG9ycyBsaXN0IHdpbGwgYmUgdHJ1bmNhdGVkOiAlZCA8 ICVkXG4iLAo+IEBAIC03OSw2ICs4NiwxMCBAQCBzdGF0aWMgaW50Cj4gcXhsX2Rpc3BsYXlfY29w eV9yb21fY2xpZW50X21vbml0b3JzX2NvbmZpZyhzdHJ1Y3QgcXhsX2RldmljZSAqcWRldikKPiAg CX0gZWxzZSB7Cj4gIAkJbnVtX21vbml0b3JzID0gcWRldi0+cm9tLT5jbGllbnRfbW9uaXRvcnNf Y29uZmlnLmNvdW50Owo+ICAJfQo+ICsJaWYgKHFkZXYtPmNsaWVudF9tb25pdG9yc19jb25maWcK PiArCSAgICAgICYmIChudW1fbW9uaXRvcnMgIT0gcWRldi0+Y2xpZW50X21vbml0b3JzX2NvbmZp Zy0+Y291bnQpKSB7Cj4gKwkJc3RhdHVzID0gTU9OSVRPUlNfQ09ORklHX01PRElGSUVEOwo+ICsJ fQo+ICAJcXhsX2FsbG9jX2NsaWVudF9tb25pdG9yc19jb25maWcocWRldiwgbnVtX21vbml0b3Jz KTsKPiAgCS8qIHdlIGNvcHkgbWF4IGZyb20gdGhlIGNsaWVudCBidXQgaXQgaXNuJ3QgdXNlZCAq Lwo+ICAJcWRldi0+Y2xpZW50X21vbml0b3JzX2NvbmZpZy0+bWF4X2FsbG93ZWQgPQo+IEBAIC04 OCwxNyArOTksMzkgQEAgc3RhdGljIGludAo+IHF4bF9kaXNwbGF5X2NvcHlfcm9tX2NsaWVudF9t b25pdG9yc19jb25maWcoc3RydWN0IHF4bF9kZXZpY2UgKnFkZXYpCj4gIAkJCSZxZGV2LT5yb20t PmNsaWVudF9tb25pdG9yc19jb25maWcuaGVhZHNbaV07Cj4gIAkJc3RydWN0IHF4bF9oZWFkICpj bGllbnRfaGVhZCA9Cj4gIAkJCSZxZGV2LT5jbGllbnRfbW9uaXRvcnNfY29uZmlnLT5oZWFkc1tp XTsKPiAtCQljbGllbnRfaGVhZC0+eCA9IGNfcmVjdC0+bGVmdDsKPiAtCQljbGllbnRfaGVhZC0+ eSA9IGNfcmVjdC0+dG9wOwo+IC0JCWNsaWVudF9oZWFkLT53aWR0aCA9IGNfcmVjdC0+cmlnaHQg LSBjX3JlY3QtPmxlZnQ7Cj4gLQkJY2xpZW50X2hlYWQtPmhlaWdodCA9IGNfcmVjdC0+Ym90dG9t IC0gY19yZWN0LT50b3A7Cj4gLQkJY2xpZW50X2hlYWQtPnN1cmZhY2VfaWQgPSAwOwo+IC0JCWNs aWVudF9oZWFkLT5pZCA9IGk7Cj4gLQkJY2xpZW50X2hlYWQtPmZsYWdzID0gMDsKPiArCQlpZiAo Y2xpZW50X2hlYWQtPnggIT0gY19yZWN0LT5sZWZ0KSB7Cj4gKwkJCWNsaWVudF9oZWFkLT54ID0g Y19yZWN0LT5sZWZ0Owo+ICsJCQlzdGF0dXMgPSBNT05JVE9SU19DT05GSUdfTU9ESUZJRUQ7Cj4g KwkJfQo+ICsJCWlmIChjbGllbnRfaGVhZC0+eSAhPSBjX3JlY3QtPnRvcCkgewo+ICsJCQljbGll bnRfaGVhZC0+eSA9IGNfcmVjdC0+dG9wOwo+ICsJCQlzdGF0dXMgPSBNT05JVE9SU19DT05GSUdf TU9ESUZJRUQ7Cj4gKwkJfQo+ICsJCWlmIChjbGllbnRfaGVhZC0+d2lkdGggIT0gY19yZWN0LT5y aWdodCAtIGNfcmVjdC0+bGVmdCkgewo+ICsJCQljbGllbnRfaGVhZC0+d2lkdGggPSBjX3JlY3Qt PnJpZ2h0IC0gY19yZWN0LT5sZWZ0Owo+ICsJCQlzdGF0dXMgPSBNT05JVE9SU19DT05GSUdfTU9E SUZJRUQ7Cj4gKwkJfQo+ICsJCWlmIChjbGllbnRfaGVhZC0+aGVpZ2h0ICE9IGNfcmVjdC0+Ym90 dG9tIC0gY19yZWN0LT50b3ApIHsKPiArCQkJY2xpZW50X2hlYWQtPmhlaWdodCA9IGNfcmVjdC0+ Ym90dG9tIC0gY19yZWN0LT50b3A7Cj4gKwkJCXN0YXR1cyA9IE1PTklUT1JTX0NPTkZJR19NT0RJ RklFRDsKPiArCQl9Cj4gKwkJaWYgKGNsaWVudF9oZWFkLT5zdXJmYWNlX2lkICE9IDApIHsKPiAr CQkJY2xpZW50X2hlYWQtPnN1cmZhY2VfaWQgPSAwOwo+ICsJCQlzdGF0dXMgPSBNT05JVE9SU19D T05GSUdfTU9ESUZJRUQ7Cj4gKwkJfQo+ICsJCWlmIChjbGllbnRfaGVhZC0+aWQgIT0gaSkgewo+ ICsJCQljbGllbnRfaGVhZC0+aWQgPSBpOwo+ICsJCQlzdGF0dXMgPSBNT05JVE9SU19DT05GSUdf TU9ESUZJRUQ7Cj4gKwkJfQo+ICsJCWlmIChjbGllbnRfaGVhZC0+ZmxhZ3MgIT0gMCkgewo+ICsJ CQljbGllbnRfaGVhZC0+ZmxhZ3MgPSAwOwo+ICsJCQlzdGF0dXMgPSBNT05JVE9SU19DT05GSUdf TU9ESUZJRUQ7Cj4gKwkJfQo+ICAJCURSTV9ERUJVR19LTVMoInJlYWQgJWR4JWQrJWQrJWRcbiIs IGNsaWVudF9oZWFkLT53aWR0aCwKPiAgCQljbGllbnRfaGVhZC0+aGVpZ2h0LAo+ICAJCQkgIGNs aWVudF9oZWFkLT54LCBjbGllbnRfaGVhZC0+eSk7Cj4gIAl9Cj4gLQlyZXR1cm4gMDsKPiArCj4g KwlyZXR1cm4gc3RhdHVzOwo+ICB9Cj4gIAo+ICBzdGF0aWMgdm9pZCBxeGxfdXBkYXRlX29mZnNl dF9wcm9wcyhzdHJ1Y3QgcXhsX2RldmljZSAqcWRldikKPiBAQCAtMTI0LDkgKzE1NywxOCBAQCB2 b2lkIHF4bF9kaXNwbGF5X3JlYWRfY2xpZW50X21vbml0b3JzX2NvbmZpZyhzdHJ1Y3QKPiBxeGxf ZGV2aWNlICpxZGV2KQo+ICB7Cj4gIAo+ICAJc3RydWN0IGRybV9kZXZpY2UgKmRldiA9IHFkZXYt PmRkZXY7Cj4gLQl3aGlsZSAocXhsX2Rpc3BsYXlfY29weV9yb21fY2xpZW50X21vbml0b3JzX2Nv bmZpZyhxZGV2KSkgewo+ICsJaW50IHN0YXR1czsKPiArCj4gKwlzdGF0dXMgPSBxeGxfZGlzcGxh eV9jb3B5X3JvbV9jbGllbnRfbW9uaXRvcnNfY29uZmlnKHFkZXYpOwo+ICsJd2hpbGUgKHN0YXR1 cyA9PSBNT05JVE9SU19DT05GSUdfQkFEX0NSQykgewo+ICAJCXF4bF9pb19sb2cocWRldiwgImZh aWxlZCBjcmMgY2hlY2sgZm9yIGNsaWVudF9tb25pdG9yc19jb25maWcsIgo+ICAJCQkJICIgcmV0 cnlpbmdcbiIpOwo+ICsJCXN0YXR1cyA9IHF4bF9kaXNwbGF5X2NvcHlfcm9tX2NsaWVudF9tb25p dG9yc19jb25maWcocWRldik7Cj4gKwl9Cj4gKwlpZiAoc3RhdHVzID09IE1PTklUT1JTX0NPTkZJ R19VTkNIQU5HRUQpIHsKPiArCQlxeGxfaW9fbG9nKHFkZXYsICJjb25maWcgdW5jaGFuZ2VkXG4i KTsKPiArCQlEUk1fREVCVUcoImlnbm9yaW5nIHVuY2hhbmdlZCBjbGllbnQgbW9uaXRvcnMgY29u ZmlnIik7Cj4gKwkJcmV0dXJuOwo+ICAJfQo+ICAKPiAgCWRybV9tb2Rlc2V0X2xvY2tfYWxsKGRl dik7CgpBY2tlZC1ieTogRnJlZGlhbm8gWmlnbGlvIDxmemlnbGlvQHJlZGhhdC5jb20+CgpGcmVk aWFubwpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpTcGlj ZS1kZXZlbCBtYWlsaW5nIGxpc3QKU3BpY2UtZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0 dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vc3BpY2UtZGV2ZWwK