From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tomi Valkeinen Subject: Re: [PATCH v3 10/20] drm: omapdrm: Only commit planes on active CRTCs Date: Tue, 13 Dec 2016 09:58:34 +0200 Message-ID: <14d64377-3662-89cd-d910-021a04d7fc9a@ti.com> References: <1474288063-5315-1-git-send-email-laurent.pinchart@ideasonboard.com> <1474288063-5315-11-git-send-email-laurent.pinchart@ideasonboard.com> <9d5edf00-564c-63d6-809f-16cef6f4895c@ti.com> <2445725.dYIyiJ9Mnl@avalon> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1436503289==" Return-path: Received: from fllnx210.ext.ti.com (fllnx210.ext.ti.com [198.47.19.17]) by gabe.freedesktop.org (Postfix) with ESMTPS id BC4616E03A for ; Tue, 13 Dec 2016 07:58:40 +0000 (UTC) In-Reply-To: <2445725.dYIyiJ9Mnl@avalon> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Laurent Pinchart Cc: dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org --===============1436503289== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="P5egofJctn8gsJxF6LRxQlAf3mgIBWhkk" --P5egofJctn8gsJxF6LRxQlAf3mgIBWhkk Content-Type: multipart/mixed; boundary="2CUxchOm7p46RmBXuhr48iwxbGtLgn1U7"; protected-headers="v1" From: Tomi Valkeinen To: Laurent Pinchart Cc: dri-devel@lists.freedesktop.org Message-ID: <14d64377-3662-89cd-d910-021a04d7fc9a@ti.com> Subject: Re: [PATCH v3 10/20] drm: omapdrm: Only commit planes on active CRTCs References: <1474288063-5315-1-git-send-email-laurent.pinchart@ideasonboard.com> <1474288063-5315-11-git-send-email-laurent.pinchart@ideasonboard.com> <9d5edf00-564c-63d6-809f-16cef6f4895c@ti.com> <2445725.dYIyiJ9Mnl@avalon> In-Reply-To: <2445725.dYIyiJ9Mnl@avalon> --2CUxchOm7p46RmBXuhr48iwxbGtLgn1U7 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 13/12/16 00:53, Laurent Pinchart wrote: > Hi Tomi, >=20 > On Tuesday 20 Sep 2016 16:51:11 Tomi Valkeinen wrote: >> On 19/09/16 15:27, Laurent Pinchart wrote: >>> The DRM core supports skipping plane update for inactive CRTCs for >>> hardware that don't need it or can't cope with it. That's our case, s= o >>> use the DRM core infrastructure instead of reinventing it. >> >> I don't follow this desc. What is omapdrm reinventing? At least this >> patch does not remove any of the "reinvention". >=20 > There used to be one, but it got removed when I rebased the patch serie= s. I'll=20 > reword the commit message. >=20 >> What does DRM_PLANE_COMMIT_ACTIVE_ONLY do? Skips plane HW configuratio= n >> for planes on crtcs that are disabled? The plane HW config will still = be >> done when the crtc is about to be enabled, right? >=20 > It skips plane update (atomic_begin, atomic_disable, atomic_flush) for = > disabled CRTCs. The CRTC .begin() operation is still called for those C= RTCs,=20 > only plane update is skipped. I didn't catch that. Skips atomic_begin, but .begin is still called? > Now that I wrote that, I'm not quite sure this change is right. It look= s like=20 > disabling a plane is shadowed, and without an atomic_flush call the GO = bit=20 > will never be set. However, the problem predates this patch, as the GO = bit=20 > will only be set if dispc_mgr_is_enabled() returns true, which shouldn'= t be=20 > the case for disabled CRTCs. >=20 > How is this supposed to work, how is plane disable supposed to be synch= ronized=20 > at the hardware level ? If a crtc is currently disabled (in the HW), all the new settings (including plane enable/disable bit) can be programmed and when the crtc is enabled, those settings are taken into use. GO bit is not necessary. When the crtc is active, you need to set the GO bit to get the new settings into use at next vblank. If a crtc is to be disabled, we can just disable the crtc, GO bit is not necessary. Tomi --2CUxchOm7p46RmBXuhr48iwxbGtLgn1U7-- --P5egofJctn8gsJxF6LRxQlAf3mgIBWhkk Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJYT6oqAAoJEPo9qoy8lh71wxMP/0BI2Gjqm79MuzW5UaFXGwbf AzHdeIKx9+bON3MOBxA5DO9MyiGituJqRhZos4E678Rso3NOFvKJtZJALnDt5h9K b6K0Mjf8O9Y/I31u2aA4Qhfg6YX9gMCOkTibA85mhcN39TUpanvhKPz85jB4YaIt j6/0AHX5sBoaVLeTgPjGU6QqtDNblQ/uNNDNhYROQMstC6Y61/PlBeDlSI1hLVz9 9Or67v4DjUJRZmkxnCYJMIlrylzPs5ntiWLUv/2EmSq7efcsoONnw9c9uPyRp7Rb 5yTL0HkSQ3JcVRDipROq7pAM/EHxj5ffdDhHZMGsn9DG+47eUEWtKa7RoikuGMFd 52Q1B1UiNsqdKH8Xw+BqiyAlAGCimeAfiJd1FXWGxzi9cJ+kaDRoA1/kOumgqAxZ aOdP7aoz6gagOuOQo6gEaBen8I8K4U9hPTnMx57UFHswBPV3yC+xnbH3fBwVw/ZR LgWNSpSubnOp11gumwwPH0z0C0oyqbCXTPI4JUo2z6ziu7/0bY7/5jkkUKkZ8/7R nC5JxCite5dmx1Q8cVenWi2elRMdRxBrA6+jui+heZEo5BKutBfRNsvWHPDZWQvI JU6NnwsklFQBYtEfnkFEnFh3NAOXz2/F/CP/uJ00/8CHe5wXGhTqgSv4VGhtc0sr 2SBYf6oap7OC61zlFaf4 =LpBk -----END PGP SIGNATURE----- --P5egofJctn8gsJxF6LRxQlAf3mgIBWhkk-- --===============1436503289== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== --===============1436503289==--