Re: [PATCH] drm/etnaviv: select CMA and DMA_CMA if available

From: Lucas Stach <l.stach@pengutronix.de>
To: Joshua Clayton <stillcompiling@gmail.com>
Cc: dri-devel@lists.freedesktop.org, etnaviv@lists.freedesktop.org,
	kernel@pengutronix.de,
	Russell King <linux+etnaviv@armlinux.org.uk>
Subject: Re: [PATCH] drm/etnaviv: select CMA and DMA_CMA if available
Date: Mon, 17 Jul 2017 10:52:06 +0200	[thread overview]
Message-ID: <1500281526.6594.26.camel@pengutronix.de> (raw)
In-Reply-To: <2478995.sQ5Mui5ApH@diplodocus>

Am Freitag, den 14.07.2017, 11:32 -0700 schrieb Joshua Clayton:
> On Friday, July 14, 2017 7:38:01 AM PDT Lucas Stach wrote:
> > While this is no build dependency, etnaviv will only work correctly on most
> > systems if CMA and DMA_CMA are enabled. Select both options if available to
> > avoid users ending up with a non-working GPU due to a lacking kernel config.
> > 
> > Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
> > ---
> >  drivers/gpu/drm/etnaviv/Kconfig | 2 ++
> >  1 file changed, 2 insertions(+)
> > 
> > diff --git a/drivers/gpu/drm/etnaviv/Kconfig
> > b/drivers/gpu/drm/etnaviv/Kconfig index 71cee4e9fefb..38b477b5fbf9 100644
> > --- a/drivers/gpu/drm/etnaviv/Kconfig
> > +++ b/drivers/gpu/drm/etnaviv/Kconfig
> > @@ -10,6 +10,8 @@ config DRM_ETNAVIV
> >  	select IOMMU_API
> >  	select IOMMU_SUPPORT
> >  	select WANT_DEV_COREDUMP
> > +	select CMA if HAVE_DMA_CONTIGUOUS
> > +	select DMA_CMA if HAVE_DMA_CONTIGUOUS
> >  	help
> >  	  DRM driver for Vivante GPUs.
> IIRC, This at least half solves it.
> Does the user of systems with > 2 GiB  need to explicitly specify cma size for 
> it to work?

No, we move the linear memory window to the location of the CMA area,
which means as long as the user doesn't explicitly specify a CMA size
> 2GB things will just work.

Regards,
Lucas

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel