From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paul Menzel Subject: Re: [PATCH 11/14] drm/mgag200: Consolidate depth/bpp handling Date: Thu, 20 Jul 2017 13:58:14 +0200 Message-ID: <1500551894.2596.563.camel@users.sourceforge.net> References: <20170718144320.8354-1-tiwai@suse.de> <20170718144320.8354-12-tiwai@suse.de> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1898012641==" Return-path: Received: from mail.gw90.de (mail.gw90.de [IPv6:2a01:4f8:221:2782::3]) by gabe.freedesktop.org (Postfix) with ESMTPS id 4FBBB6E132 for ; Thu, 20 Jul 2017 11:58:31 +0000 (UTC) In-Reply-To: <20170718144320.8354-12-tiwai@suse.de> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Takashi Iwai , dri-devel@lists.freedesktop.org Cc: Egbert Eich , Dave Airlie , Mathieu Larouche , Daniel Vetter List-Id: dri-devel@lists.freedesktop.org --===============1898012641== Content-Type: multipart/signed; micalg="pgp-sha1"; protocol="application/pgp-signature"; boundary="=-ynctPcdpxUM2ZlRz07n2" --=-ynctPcdpxUM2ZlRz07n2 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Dear Takashi, Thank you for posting these patches for review. Am Dienstag, den 18.07.2017, 16:43 +0200 schrieb Takashi Iwai: > From: Egbert Eich >=20 > The depth/bpp handling for chips with limited memory in commit > 918be888d613 ("drm/mgag200: on cards with < 2MB VRAM default to > 16-bit") was incomplete: the bpp limits were applied to mode > validation. >=20 > This consolidates dpeth/bpp handling, adds it to mode validation depth > and moves the code which reads the command line specified depth > into the correct location. >=20 > Fixes: 918be888d613 ("drm/mgag200: on cards with < 2MB VRAM default to 16= -bit") ``` $=C2=A0git tag --contains 918be888d613 | head -1 v3.14 ``` Please mark this as stable then too? Also, could the original commit author time-stamps be preserved if you have them in your SUSE repositories? The `Date` line could be added below the `From` line. That would help to know for how long the changes have been tested. > Signed-off-by: Egbert Eich > Signed-off-by: Takashi Iwai > --- > drivers/gpu/drm/mgag200/mgag200_drv.h | 2 ++ > drivers/gpu/drm/mgag200/mgag200_fb.c | 7 +------ > drivers/gpu/drm/mgag200/mgag200_main.c | 9 ++++++--- > drivers/gpu/drm/mgag200/mgag200_mode.c | 14 +++++++------- > 4 files changed, 16 insertions(+), 16 deletions(-) [=E2=80=A6] Otherwise this looks fine. Thanks, Paul --=-ynctPcdpxUM2ZlRz07n2 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iF0EABECAB0WIQQ8+w9d414FAVARIpk9fVorbA4dWAUCWXCa1gAKCRA9fVorbA4d WHmsAJ0QKZMEyRpQisw72gTMPJyA9n1NHACfUcpxpPRKcJXBdpTWMIC4YK0TZZk= =qeXa -----END PGP SIGNATURE----- --=-ynctPcdpxUM2ZlRz07n2-- --===============1898012641== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== --===============1898012641==--