dri-devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Karsten Wiese <fzuuzf@googlemail.com>
To: dri-devel@lists.freedesktop.org
Cc: Karsten Wiese <fzuuzf@googlemail.com>
Subject: [PATCH] drm: Call sysfs_notify after changing drm_connector::dpms
Date: Tue, 19 Sep 2017 11:53:50 +0200	[thread overview]
Message-ID: <1505814830-8276-1-git-send-email-fzuuzf@googlemail.com> (raw)

This makes poll work for the
/sys/class/drm/cardX/connectorY/dpms attributes.

Tested with i915 suspended by XScreenServer and
suspend to RAM.

Signed-off-by: Karsten Wiese <fzuuzf@googlemail.com>
---
 drivers/gpu/drm/drm_atomic.c        | 4 ++++
 drivers/gpu/drm/drm_atomic_helper.c | 6 +++++-
 2 files changed, 9 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/drm_atomic.c b/drivers/gpu/drm/drm_atomic.c
index 2fd383d..b6fa87b 100644
--- a/drivers/gpu/drm/drm_atomic.c
+++ b/drivers/gpu/drm/drm_atomic.c
@@ -1880,6 +1880,10 @@ int drm_atomic_connector_commit_dpms(struct drm_atomic_state *state,
 out:
 	if (ret != 0)
 		connector->dpms = old_mode;
+	else
+		if (connector->dpms != old_mode)
+			sysfs_notify(&connector->kdev->kobj, NULL, "dpms");
+
 	return ret;
 }
 
diff --git a/drivers/gpu/drm/drm_atomic_helper.c b/drivers/gpu/drm/drm_atomic_helper.c
index 4e53aae..6198772 100644
--- a/drivers/gpu/drm/drm_atomic_helper.c
+++ b/drivers/gpu/drm/drm_atomic_helper.c
@@ -921,12 +921,16 @@ drm_atomic_helper_update_legacy_modeset_state(struct drm_device *dev,
 		crtc = new_conn_state->crtc;
 		if ((!crtc && old_conn_state->crtc) ||
 		    (crtc && drm_atomic_crtc_needs_modeset(crtc->state))) {
-			int mode = DRM_MODE_DPMS_OFF;
+			int old_mode, mode = DRM_MODE_DPMS_OFF;
 
 			if (crtc && crtc->state->active)
 				mode = DRM_MODE_DPMS_ON;
 
+			old_mode = connector->dpms;
 			connector->dpms = mode;
+			if (old_mode != mode)
+				sysfs_notify(&connector->kdev->kobj,
+						NULL, "dpms");
 		}
 	}
 
-- 
2.7.4

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

             reply	other threads:[~2017-09-19  9:54 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-19  9:53 Karsten Wiese [this message]
2017-09-25 13:48 ` [PATCH] drm: Call sysfs_notify after changing drm_connector::dpms Jani Nikula
2017-09-26 22:29   ` Karsten Wiese
2017-09-27  7:18     ` Jani Nikula
2017-09-27 10:20       ` Karsten Wiese
2017-09-27 11:47         ` Daniel Vetter
2017-09-27 12:58           ` Jani Nikula
2017-09-27 15:03             ` Karsten Wiese
2017-09-27 15:16               ` Jani Nikula
2017-09-27  8:45     ` Daniel Vetter
2017-09-27 10:38       ` Karsten Wiese

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1505814830-8276-1-git-send-email-fzuuzf@googlemail.com \
    --to=fzuuzf@googlemail.com \
    --cc=dri-devel@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox