From: Gerd Hoffmann <kraxel@redhat.com>
To: Gabriel Krisman Bertazi <krisman@collabora.co.uk>
Cc: dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] qxl: fix framebuffer unpinning
Date: Fri, 22 Sep 2017 08:25:36 +0200 [thread overview]
Message-ID: <1506061536.17011.6.camel@redhat.com> (raw)
In-Reply-To: <87lgl79vg4.fsf@dilma.collabora.co.uk>
On Fri, 2017-09-22 at 02:03 -0300, Gabriel Krisman Bertazi wrote:
> Gerd Hoffmann <kraxel@redhat.com> writes:
>
> > Hi,
> >
> > > > "removing the device"? qxl can't be hotplugged ...
> > > > Or do you mean "rmmod qxl"?
> > >
> > > rmmod qxl
> >
> > rmmod: ERROR: Module qxl is in use.
> >
> > How do you do that? CONFIG_FBCON=n?
>
> I can simply disable X, lightdm or whatever is using it and then
> rmmod.
Works for me only with CONFIG_FBCON=n, otherwise the fbcon framebuffer
keeps qxl busy. So is most cases (typical distro kernel build with
FBCON=y) you simply can't rmmod qxl.
I agree that "rmmod qxl" should be fixed, but IMHO this is independent
from this bugfix, and I'd like to get it out of the door ASAP. Can I
get your reviewed-by?
cheers,
Gerd
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2017-09-22 6:25 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-18 7:41 [PATCH] qxl: fix framebuffer unpinning Gerd Hoffmann
2017-09-19 14:35 ` Gabriel Krisman Bertazi
2017-09-19 15:29 ` Gerd Hoffmann
2017-09-20 3:48 ` Gabriel Krisman Bertazi
2017-09-20 12:17 ` Gerd Hoffmann
2017-09-22 5:03 ` Gabriel Krisman Bertazi
2017-09-22 6:25 ` Gerd Hoffmann [this message]
2017-09-22 17:37 ` Gabriel Krisman Bertazi
2017-09-25 7:14 ` Gerd Hoffmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1506061536.17011.6.camel@redhat.com \
--to=kraxel@redhat.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=krisman@collabora.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox