From: Robert Foss <robert.foss@collabora.com>
To: Sean Paul <seanpaul@chromium.org>
Cc: Zach Reizner <zachr@chromium.org>, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH hwc v1] drm_hwcomposer: Add CONTRIBUTING file
Date: Fri, 22 Sep 2017 20:22:30 +0200 [thread overview]
Message-ID: <1506104550.2209.2.camel@collabora.com> (raw)
In-Reply-To: <20170922162318.lfsd6lls7t2trsir@art_vandelay>
Pushed!
On Fri, 2017-09-22 at 09:23 -0700, Sean Paul wrote:
> On Fri, Sep 22, 2017 at 02:37:18AM +0200, Robert Foss wrote:
> > Some basic guidelines for contributions could come in handy.
> >
> > These are copied from IGT and modified to be suitable.
> >
> > Signed-off-by: Robert Foss <robert.foss@collabora.com>
> > ---
> > CONTRIBUTING | 31 +++++++++++++++++++++++++++++++
> > 1 file changed, 31 insertions(+)
> > create mode 100644 CONTRIBUTING
> >
> > diff --git a/CONTRIBUTING b/CONTRIBUTING
> > new file mode 100644
> > index 0000000..f1b4775
> > --- /dev/null
> > +++ b/CONTRIBUTING
> > @@ -0,0 +1,31 @@
> > +Patches to drm_hwcomposer are very much welcome, we really want
> > this to be the
> > +universal HW composer implementation for Android and similar
> > platforms
> > +So please bring on porting patches, bugfixes, improvements for
> > documentation
> > +and new features.
> > +
> > +A short list of contribution guidelines:
> > +
> > +- Please submit patches formatted with git send-email/git format-
> > patch or
> > + equivalent to
> > +
> > + dri-devel <dri-devel@lists.freedesktop.org>
> > +
> > + Please use --subject-prefix="PATCH hwc" so that drm_hwcomposer
> > patches are easily
> > + identified in the massive amount mails on dri-devel. To ensure
> > this is always
> > + done, run:
> > +
> > + git config format.subjectprefix "PATCH hwc"
> > +
> > +- drm_hwcomposer is Apache 2.0 Licensed and we require
> > contributions to follow the
> > + developer's certificate of origin: http://developercertificate.o
> > rg/
> > +
> > +- When submitting new code please follow the naming conventions
> > documented
> > + in the generated documentation. Also please make full use of all
> > the helpers and
> > + convenience macros provided by drm_hwcomposer. The below command
> > can help you
> > + with formatting of your patches:
> > + git diff | clang-format-diff-3.5 -p 1 -style=file
> > +
> > +- Harware specific changes should get tested on relevant platforms
>
> *Hardware
>
> With that,
>
> Reviewed-by: Sean Paul <seanpaul@chromium.org>
>
> > + before committing.
> > +
> > +Happy hacking!
> > --
> > 2.11.0
> >
>
>
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2017-09-22 18:22 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-22 0:37 [PATCH hwc v1] drm_hwcomposer: Add CONTRIBUTING file Robert Foss
2017-09-22 16:22 ` Zach Reizner
2017-09-22 16:23 ` Sean Paul
2017-09-22 18:22 ` Robert Foss [this message]
2017-09-27 14:42 ` Emil Velikov
2017-09-27 18:55 ` Robert Foss
2017-09-27 21:16 ` Rob Herring
2017-09-28 10:43 ` Eric Engestrom
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1506104550.2209.2.camel@collabora.com \
--to=robert.foss@collabora.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=seanpaul@chromium.org \
--cc=zachr@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox