Re: [PATCH hwc v2 5/6] drm_hwcomposer: Add GetCrtcCount function

From: Robert Foss <robert.foss@collabora.com>
To: Sean Paul <seanpaul@chromium.org>
Cc: dri-devel <dri-devel@lists.freedesktop.org>,
	Adrian Salido <salidoa@google.com>
Subject: Re: [PATCH hwc v2 5/6] drm_hwcomposer: Add GetCrtcCount function
Date: Thu, 28 Sep 2017 18:21:44 +0200	[thread overview]
Message-ID: <1506615704.2185.2.camel@collabora.com> (raw)
In-Reply-To: <CAOw6vb+-FrWL7M5rT8Hk-j0kGBCmQyB8UNniTHzce+2fXFqxRA@mail.gmail.com>

On Wed, 2017-09-27 at 15:12 -0400, Sean Paul wrote:
> On Wed, Sep 27, 2017 at 7:58 AM, Robert Foss <robert.foss@collabora.c
> om> wrote:
> > This GetCrtrcCount helper functions enables convenient
> > fetching of the number of Crtcs from DrmResources.
> > 
> > Signed-off-by: Robert Foss <robert.foss@collabora.com>
> > ---
> >  drmresources.cpp | 4 ++++
> >  drmresources.h   | 1 +
> >  2 files changed, 5 insertions(+)
> > 
> > diff --git a/drmresources.cpp b/drmresources.cpp
> > index 762f5ef..0578cc6 100644
> > --- a/drmresources.cpp
> > +++ b/drmresources.cpp
> > @@ -241,6 +241,10 @@ DrmPlane *DrmResources::GetPlane(uint32_t id)
> > const {
> >    return NULL;
> >  }
> > 
> > +uint32_t DrmResources::GetCrtcCount() const {
> > +  return (uint32_t) crtcs_.size();
> > +}
> 
> The "blessed" way of doing this would be to add a new function
> 
> const std::vector<std::unique_ptr<DrmCrtc>> &crtcs() const {
>   return crtcs_;
> }
> 
> and then use crtcs()->size() wherever needed.
> 
> 

Yeah, that is nicer and more versatile.

Rob.
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel