From mboxrd@z Thu Jan 1 00:00:00 1970 From: RAHUL SHARMA Subject: Re: Re: [PATCH 00/14] drm: exynos: hdmi: add dt based support for exynos5 hdmi Date: Fri, 05 Oct 2012 03:48:59 +0000 (GMT) Message-ID: <15068238.565301349408939259.JavaMail.weblogic@epml07> Reply-To: rahul.sharma@samsung.com Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mailout2.samsung.com (mailout2.samsung.com [203.254.224.25]) by gabe.freedesktop.org (Postfix) with ESMTP id 2B5769F398 for ; Thu, 4 Oct 2012 20:49:00 -0700 (PDT) Received: from epcpsbge2.samsung.com (epcpsbge2 [203.254.230.12]) by mailout2.samsung.com (Oracle Communications Messaging Server 7u4-24.01(7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0MBE00165IKO8V10@mailout2.samsung.com> for dri-devel@lists.freedesktop.org; Fri, 05 Oct 2012 12:48:59 +0900 (KST) MIME-version: 1.0 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org Errors-To: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org To: Joonyoung Shim Cc: SHIRISH S , Leela Krishna Amudala , SUNIL JOSHI , "dri-devel@lists.freedesktop.org" , Kyungmin Park , FAHAD KUNNATHADI , PRASHANTH GODREHAL List-Id: dri-devel@lists.freedesktop.org Thanks Joonyoung, I have addressed your comments in v1 set. Please have a look at them. regards, Rahul Sharma On Tue, Oct 2, 2012 at 1:01 PM, Joonyoung Shim wrote: > Hi, > > > On 09/28/2012 11:25 PM, Rahul Sharma wrote: >> >> This patch set adds the DT based support for Samsung's Exynos5250 in >> DRM-HDMI. >> It includes disabling of hdmi internal interrupt, suppport for platform >> variants for hdmi and mixer, support to disable video processor based on >> platform type and removal of drm common platform data. > > > Looks good to me overall, i commented a bit. > > Thanks. > > >> Rahul Sharma (9): >> drm: exynos: remove drm hdmi platform data struct >> drm: exynos: hdmi: add support for exynos5 ddc >> drm: exynos: hdmi: add support for exynos5 hdmiphy >> drm: exynos: hdmi: add support for platform variants for mixer >> drm: exynos: hdmi: add support to disable video processor in mixer >> drm: exynos: hdmi: add support for exynos5 mixer >> drm: exynos: hdmi: replace is_v13 with version check in hdmi >> drm: exynos: hdmi: add support for exynos5 hdmi >> drm: exynos: hdmi: remove drm common hdmi platform data struct >> >> Tomasz Stanislawski (5): >> media: s5p-hdmi: add HPD GPIO to platform data >> drm: exynos: hdmi: support for platform variants >> drm: exynos: hdmi: fix interrupt handling >> drm: exynos: hdmi: use s5p-hdmi platform data >> drm: exynos: hdmi: turn off HPD interrupt in HDMI chip >> >> drivers/gpu/drm/exynos/exynos_ddc.c | 22 +++- >> drivers/gpu/drm/exynos/exynos_drm_hdmi.c | 51 ++++---- >> drivers/gpu/drm/exynos/exynos_drm_hdmi.h | 2 + >> drivers/gpu/drm/exynos/exynos_hdmi.c | 196 >> ++++++++++++++++++++------- >> drivers/gpu/drm/exynos/exynos_hdmiphy.c | 12 ++- >> drivers/gpu/drm/exynos/exynos_mixer.c | 219 >> ++++++++++++++++++++++-------- >> drivers/gpu/drm/exynos/regs-mixer.h | 2 + >> include/drm/exynos_drm.h | 27 ---- >> include/media/s5p_hdmi.h | 2 + >> 9 files changed, 369 insertions(+), 164 deletions(-) >> >> >