From: Robert Foss <robert.foss@collabora.com>
To: Thierry Reding <thierry.reding@gmail.com>, Rob Herring <robh@kernel.org>
Cc: dri-devel@lists.freedesktop.org
Subject: Re: [PATCH hwc] drm_hwcomposer: remove NVIDIA importer
Date: Mon, 09 Oct 2017 16:01:16 +0200 [thread overview]
Message-ID: <1507557676.16394.9.camel@collabora.com> (raw)
In-Reply-To: <1507557503.16394.8.camel@collabora.com>
Hey again,
Just pushed this patch.
Rob.
On Mon, 2017-10-09 at 15:58 +0200, Robert Foss wrote:
> Hey Thierry,
>
> On Mon, 2017-10-09 at 15:07 +0200, Thierry Reding wrote:
> > On Fri, Oct 06, 2017 at 05:02:03PM -0500, Rob Herring wrote:
> > > There's no opensource implementation for the NVIDIA gralloc
> > > implementation,
> > > so remove it as it is not testable.
> > >
> > > As all of the gralloc perform() operations are specific to it,
> > > they
> > > can be
> > > removed, too.
> > >
> > > Signed-off-by: Rob Herring <robh@kernel.org>
> > > ---
> > > Android.mk | 5 -
> > > drmhwcgralloc.h | 33 -----
> > > platformnv.cpp | 374 ------------------------------------------
> > > --
> > > ------------
> > > 3 files changed, 412 deletions(-)
> > > delete mode 100644 platformnv.cpp
> >
> > This is in agreement with other parts of the open source graphics
> > stack,
> > so:
> >
> > Acked-by: Thierry Reding <treding@nvidia.com>
> >
> > If anyone wants to revive this, they'd have to provide an open
> > source
> > implementation of gralloc first, and then this commit could always
> > be
> > reverted.
> >
> > Thierry
>
> Excellent, thanks for the quick reply.
>
>
> Rob.
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
prev parent reply other threads:[~2017-10-09 14:01 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-06 22:02 [PATCH hwc] drm_hwcomposer: remove NVIDIA importer Rob Herring
2017-10-09 11:24 ` Robert Foss
2017-10-09 13:07 ` Thierry Reding
2017-10-09 13:58 ` Robert Foss
2017-10-09 14:01 ` Robert Foss [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1507557676.16394.9.camel@collabora.com \
--to=robert.foss@collabora.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=robh@kernel.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox