From: Andrey Gusakov <andrey.gusakov@cogentembedded.com>
To: dri-devel@lists.freedesktop.org
Cc: andrey.gusakov@cogentembedded.com, cphealy@gmail.com
Subject: [PATCH v2 5/7] drm/bridge: tc358767: fix AUXDATAn registers access
Date: Fri, 3 Nov 2017 20:01:32 +0300 [thread overview]
Message-ID: <1509728494-23508-6-git-send-email-andrey.gusakov@cogentembedded.com> (raw)
In-Reply-To: <1509728494-23508-1-git-send-email-andrey.gusakov@cogentembedded.com>
First four bytes should go to DP0_AUXWDATA0. Due to bug if
len > 4 first four bytes was writen to DP0_AUXWDATA1 and all
data get shifted by 4 bytes. Fix it.
---
drivers/gpu/drm/bridge/tc358767.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/bridge/tc358767.c b/drivers/gpu/drm/bridge/tc358767.c
index 319d582..4394131 100644
--- a/drivers/gpu/drm/bridge/tc358767.c
+++ b/drivers/gpu/drm/bridge/tc358767.c
@@ -318,7 +318,7 @@ static ssize_t tc_aux_transfer(struct drm_dp_aux *aux,
tmp = (tmp << 8) | buf[i];
i++;
if (((i % 4) == 0) || (i == size)) {
- tc_write(DP0_AUXWDATA(i >> 2), tmp);
+ tc_write(DP0_AUXWDATA((i - 1) >> 2), tmp);
tmp = 0;
}
}
--
1.7.10.4
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2017-11-03 17:01 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20171103170146epcas2p320108013d3b9c998fc97a7e705c73e15@epcas2p3.samsung.com>
2017-11-03 17:01 ` [PATCH v2 0/7] drm/bridge: tc358767: fixes and improvements (resend) Andrey Gusakov
2017-11-03 17:01 ` [PATCH v2 1/7] drm/bridge: tc358767: do no fail on hi-res displays Andrey Gusakov
2017-11-06 7:25 ` Andrzej Hajda
2017-11-03 17:01 ` [PATCH v2 2/7] drm/bridge: tc358767: filter out too high modes Andrey Gusakov
2017-11-06 7:50 ` Andrzej Hajda
2017-11-03 17:01 ` [PATCH v2 3/7] drm/bridge: tc358767: fix DP0_MISC register set Andrey Gusakov
2017-11-03 17:01 ` [PATCH v2 4/7] drm/bridge: tc358767: fix timing calculations Andrey Gusakov
2017-11-03 17:01 ` Andrey Gusakov [this message]
2017-11-03 17:01 ` [PATCH v2 6/7] drm/bridge: tc358767: fix 1-lane behavior Andrey Gusakov
2017-11-03 17:01 ` [PATCH v2 7/7] drm/bridge: tc358767: add copyright lines Andrey Gusakov
2017-11-06 7:58 ` [PATCH v2 0/7] drm/bridge: tc358767: fixes and improvements (resend) Andrzej Hajda
2017-11-07 4:41 ` Archit Taneja
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1509728494-23508-6-git-send-email-andrey.gusakov@cogentembedded.com \
--to=andrey.gusakov@cogentembedded.com \
--cc=cphealy@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).