From: Andrey Gusakov <andrey.gusakov@cogentembedded.com>
To: dri-devel@lists.freedesktop.org
Cc: andrey.gusakov@cogentembedded.com, cphealy@gmail.com
Subject: [PATCH v3 3/7] drm/bridge: tc358767: fix DP0_MISC register set
Date: Tue, 7 Nov 2017 19:56:21 +0300 [thread overview]
Message-ID: <1510073785-16108-4-git-send-email-andrey.gusakov@cogentembedded.com> (raw)
In-Reply-To: <1510073785-16108-1-git-send-email-andrey.gusakov@cogentembedded.com>
Remove shift from TU_SIZE_RECOMMENDED define as it used to
calculate max_tu_symbols.
Acked-by: Philipp Zabel <p.zabel@pengutronix.de>
Signed-off-by: Andrey Gusakov <andrey.gusakov@cogentembedded.com>
---
drivers/gpu/drm/bridge/tc358767.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/bridge/tc358767.c b/drivers/gpu/drm/bridge/tc358767.c
index 948a486..47e23a2 100644
--- a/drivers/gpu/drm/bridge/tc358767.c
+++ b/drivers/gpu/drm/bridge/tc358767.c
@@ -97,7 +97,7 @@
#define DP0_ACTIVEVAL 0x0650
#define DP0_SYNCVAL 0x0654
#define DP0_MISC 0x0658
-#define TU_SIZE_RECOMMENDED (0x3f << 16) /* LSCLK cycles per TU */
+#define TU_SIZE_RECOMMENDED (63) /* LSCLK cycles per TU */
#define BPC_6 (0 << 5)
#define BPC_8 (1 << 5)
@@ -716,7 +716,8 @@ static int tc_set_video_mode(struct tc_data *tc, struct drm_display_mode *mode)
* Must be less than tu_size.
*/
max_tu_symbol = TU_SIZE_RECOMMENDED - 1;
- tc_write(DP0_MISC, (max_tu_symbol << 23) | TU_SIZE_RECOMMENDED | BPC_8);
+ tc_write(DP0_MISC, (max_tu_symbol << 23) | (TU_SIZE_RECOMMENDED << 16) |
+ BPC_8);
return 0;
err:
--
1.7.10.4
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2017-11-07 16:57 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20171107165655epcas5p2624324a816baaf76db0739bae64ad87e@epcas5p2.samsung.com>
2017-11-07 16:56 ` [PATCH v3 0/7] drm/bridge: tc358767: fixes and improvements Andrey Gusakov
2017-11-07 16:56 ` [PATCH v3 1/7] drm/bridge: tc358767: do no fail on hi-res displays Andrey Gusakov
2017-11-07 16:56 ` [PATCH v3 2/7] drm/bridge: tc358767: filter out too high modes Andrey Gusakov
2017-11-07 16:56 ` Andrey Gusakov [this message]
2017-11-07 16:56 ` [PATCH v3 4/7] drm/bridge: tc358767: fix timing calculations Andrey Gusakov
2017-11-07 16:56 ` [PATCH v3 5/7] drm/bridge: tc358767: fix AUXDATAn registers access Andrey Gusakov
2017-11-07 16:56 ` [PATCH v3 6/7] drm/bridge: tc358767: fix 1-lane behavior Andrey Gusakov
2017-11-07 16:56 ` [PATCH v3 7/7] drm/bridge: tc358767: add copyright lines Andrey Gusakov
2017-11-07 17:12 ` Chris Healy
2017-11-29 11:03 ` [PATCH v3 0/7] drm/bridge: tc358767: fixes and improvements Andrzej Hajda
2017-11-29 14:55 ` Andrey Gusakov
2017-11-30 7:20 ` Andrzej Hajda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1510073785-16108-4-git-send-email-andrey.gusakov@cogentembedded.com \
--to=andrey.gusakov@cogentembedded.com \
--cc=cphealy@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).