dri-devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Philipp Zabel <p.zabel@pengutronix.de>
To: Dave Airlie <airlied@gmail.com>
Cc: kernel@pengutronix.de, dri-devel@lists.freedesktop.org
Subject: [GIT PULL] imx-drm page flip fix for v4.15-rc
Date: Thu, 30 Nov 2017 18:07:51 +0100	[thread overview]
Message-ID: <1512061671.7537.8.camel@pengutronix.de> (raw)

Hi Dave,

this tag contains a fix for a regression introduced in v4.15-rc1 with
commit 080de2e5be2d ("drm/atomic: Check for busy planes/connectors
before setting the commit"), which exposes the fact that the custom
imx-drm commit_tail never had to wait for flip_done to be signalled.

Without this fix, weston fails to page flip after the initial modeset,
returning -EBUSY, because drm_atomic_helper_setup_commit now checks that
previous commits have completed flip_done.

regards
Philipp

The following changes since commit 4fbd8d194f06c8a3fd2af1ce560ddb31f7ec8323:

  Linux 4.15-rc1 (2017-11-26 16:01:47 -0800)

are available in the git repository at:

  git://git.pengutronix.de/git/pza/linux.git tags/imx-drm-fixes-2017-11-30

for you to fetch changes up to a152992062aa3803eeabfda84b5b844721ddf6ed:

  drm/imx: always call wait_for_flip_done in commit_tail (2017-11-30 15:47:40 +0100)

----------------------------------------------------------------
drm/imx: fix commit_tail for new drm_atomic_helper_setup_commit

Since commit 080de2e5be2d ("drm/atomic: Check for busy planes/connectors before
setting the commit"), drm_atomic_helper_setup_commit expects that blocking
commits have completed flipping before the commit_tail returns. Add the missing
wait_for_flip_done to commit_tail to ensure this.

----------------------------------------------------------------
Lucas Stach (1):
      drm/imx: always call wait_for_flip_done in commit_tail

 drivers/gpu/drm/imx/imx-drm-core.c | 11 +++++++++--
 1 file changed, 9 insertions(+), 2 deletions(-)
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

                 reply	other threads:[~2017-11-30 17:07 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1512061671.7537.8.camel@pengutronix.de \
    --to=p.zabel@pengutronix.de \
    --cc=airlied@gmail.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=kernel@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox