From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2434FC07E98 for ; Tue, 28 Nov 2023 08:30:41 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 8129B10E452; Tue, 28 Nov 2023 08:30:40 +0000 (UTC) Received: from gloria.sntech.de (gloria.sntech.de [185.11.138.130]) by gabe.freedesktop.org (Postfix) with ESMTPS id 3745410E454 for ; Tue, 28 Nov 2023 08:30:38 +0000 (UTC) Received: from i53875bf8.versanet.de ([83.135.91.248] helo=diego.localnet) by gloria.sntech.de with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1r7tUD-0002DK-Ck; Tue, 28 Nov 2023 09:30:29 +0100 From: Heiko =?ISO-8859-1?Q?St=FCbner?= To: Andy Yan , Andy Yan Subject: Re: [PATCH v2 04/12] drm/rockchip: vop2: clear afbc en and transform bit for cluster window at linear mode Date: Tue, 28 Nov 2023 09:30:28 +0100 Message-ID: <15178289.EVyyLHbfrO@diego> In-Reply-To: References: <20231122125316.3454268-1-andyshrk@163.com> <3927498.QCnGb9OGeP@diego> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="iso-8859-1" X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, s.hauer@pengutronix.de, chris.obbard@collabora.com, hjc@rock-chips.com, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, kever.yang@rock-chips.com, linux-rockchip@lists.infradead.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, sebastian.reichel@collabora.com Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Am Dienstag, 28. November 2023, 09:03:46 CET schrieb Andy Yan: > Hi Heiko: >=20 > On 11/27/23 23:02, Heiko St=FCbner wrote: > > Am Mittwoch, 22. November 2023, 13:54:25 CET schrieb Andy Yan: > >> From: Andy Yan > >> > >> The enable bit and transform offset of cluster windows should be > >> cleared when it work at linear mode, or we may have a iommu fault > >> issue. > >> > >> Signed-off-by: Andy Yan > > I guess same here? > > > > Fixes: 604be85547ce ("drm/rockchip: Add VOP2 driver") >=20 >=20 > I'm not sure if we need a Fixes tag here, in fact this issue never happe= ns on >=20 > rk3566/8 , because the cluster windows of rk356x only support afbc format, >=20 > they don't have a chance to switch between afbc and linear mode. >=20 > Of course, the lack support of linear mode of rk356x cluster windows is a= thoughtless >=20 > of IC design, if it really support both afbc and linear format, we indeed= need this fix. >=20 > The situation is the same as patch 03/12. >=20 > So I hope follow your advice, if it need a Fixes tag here. ah ok, thanks for the explanation. Then I guess we don't need a fixes tag when the rk3568 is not affected by this. Same for the other patch. If you're re-sending you could add this informati= on to the commit message though. (existing support for rk3568 only supports afbc cluster windows and is therefore not affected) Thanks Heiko