From mboxrd@z Thu Jan  1 00:00:00 1970
From: Joe Perches <joe@perches.com>
Subject: Re: [PATCH] drm/i915/gvt: don't dereference 'workload' before null
 checking it
Date: Wed, 21 Mar 2018 12:09:21 -0700
Message-ID: <1521659361.7999.27.camel@perches.com>
References: <20180321190653.3829-1-colin.king@canonical.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Return-path: <dri-devel-bounces@lists.freedesktop.org>
In-Reply-To: <20180321190653.3829-1-colin.king@canonical.com>
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/dri-devel>,
 <mailto:dri-devel-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/dri-devel>
List-Post: <mailto:dri-devel@lists.freedesktop.org>
List-Help: <mailto:dri-devel-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/dri-devel>,
 <mailto:dri-devel-request@lists.freedesktop.org?subject=subscribe>
Errors-To: dri-devel-bounces@lists.freedesktop.org
Sender: "dri-devel" <dri-devel-bounces@lists.freedesktop.org>
To: Colin King <colin.king@canonical.com>, Zhenyu Wang <zhenyuw@linux.intel.com>, Zhi Wang <zhi.a.wang@intel.com>, Jani Nikula <jani.nikula@linux.intel.com>, Joonas Lahtinen <joonas.lahtinen@linux.intel.com>, Rodrigo Vivi <rodrigo.vivi@intel.com>, David Airlie <airlied@linux.ie>, intel-gvt-dev@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org
Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
List-Id: dri-devel@lists.freedesktop.org

T24gV2VkLCAyMDE4LTAzLTIxIGF0IDE5OjA2ICswMDAwLCBDb2xpbiBLaW5nIHdyb3RlOgo+IEZy
b206IENvbGluIElhbiBLaW5nIDxjb2xpbi5raW5nQGNhbm9uaWNhbC5jb20+Cj4gCj4gVGhlIHBv
aW50ZXIgd29ya2xvYWQgaXMgZGVyZWZlcmVuY2VkIGJlZm9yZSBpdCBpcyBudWxsIGNoZWNrZWQs
IGhlbmNlCj4gdGhlcmUgaXMgYSBwb3RlbnRpYWwgZm9yIGEgbnVsbCBwb2ludGVyIGRlcmVmZXJl
bmNlIG9uIHdvcmtsb2FkLiBGaXgKPiB0aGlzIGJ5IG9ubHkgZGVyZWZlcmVuY2luZyB3b3JrbG9h
ZCBhZnRlciBpdCBpcyBudWxsIGNoZWNrZWQuCj4gCj4gRGV0ZWN0ZWQgYnkgQ292ZXJpdHlTY2Fu
LCBDSUQjMTQ2NjAxNyAoIkRlcmVmZXJlbmNlIGJlZm9yZSBudWxsIGNoZWNrIikKCk1heWJlIHRy
dWUsIGJ1dCBpcyBpdCBwb3NzaWJsZSBmb3Igd29ya2xvYWQgdG8gYmUgbnVsbD8KTWF5YmUgdGhl
IG51bGwgdGVzdCBzaG91bGQgYmUgcmVtb3ZlZCBpbnN0ZWFkLgoKPiBGaXhlczogZmEzZGQ2MjNl
NTU5ICgiZHJtL2k5MTUvZ3Z0OiBrZWVwIG9hIGNvbmZpZyBpbiBzaGFkb3cgY3R4IikKPiBTaWdu
ZWQtb2ZmLWJ5OiBDb2xpbiBJYW4gS2luZyA8Y29saW4ua2luZ0BjYW5vbmljYWwuY29tPgo+IC0t
LQo+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9ndnQvc2NoZWR1bGVyLmMgfCAxMCArKysrKysrLS0t
Cj4gIDEgZmlsZSBjaGFuZ2VkLCA3IGluc2VydGlvbnMoKyksIDMgZGVsZXRpb25zKC0pCj4gCj4g
ZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2d2dC9zY2hlZHVsZXIuYyBiL2RyaXZl
cnMvZ3B1L2RybS9pOTE1L2d2dC9zY2hlZHVsZXIuYwo+IGluZGV4IDA2ODEyNjQwNDE1MS4uZjMw
MTBlMzY1YTQ4IDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2d2dC9zY2hlZHVs
ZXIuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2d2dC9zY2hlZHVsZXIuYwo+IEBAIC02
MCw5ICs2MCw5IEBAIHN0YXRpYyB2b2lkIHNldF9jb250ZXh0X3BkcF9yb290X3BvaW50ZXIoCj4g
IHN0YXRpYyB2b2lkIHNyX29hX3JlZ3Moc3RydWN0IGludGVsX3ZncHVfd29ya2xvYWQgKndvcmts
b2FkLAo+ICAJCXUzMiAqcmVnX3N0YXRlLCBib29sIHNhdmUpCj4gIHsKPiAtCXN0cnVjdCBkcm1f
aTkxNV9wcml2YXRlICpkZXZfcHJpdiA9IHdvcmtsb2FkLT52Z3B1LT5ndnQtPmRldl9wcml2Owo+
IC0JdTMyIGN0eF9vYWN0eGN0cmwgPSBkZXZfcHJpdi0+cGVyZi5vYS5jdHhfb2FjdHhjdHJsX29m
ZnNldDsKPiAtCXUzMiBjdHhfZmxleGV1MCA9IGRldl9wcml2LT5wZXJmLm9hLmN0eF9mbGV4ZXUw
X29mZnNldDsKPiArCXN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdjsKPiArCXUzMiBj
dHhfb2FjdHhjdHJsOwo+ICsJdTMyIGN0eF9mbGV4ZXUwOwo+ICAJaW50IGkgPSAwOwo+ICAJdTMy
IGZsZXhfbW1pb1tdID0gewo+ICAJCWk5MTVfbW1pb19yZWdfb2Zmc2V0KEVVX1BFUkZfQ05UTDAp
LAo+IEBAIC03Nyw2ICs3NywxMCBAQCBzdGF0aWMgdm9pZCBzcl9vYV9yZWdzKHN0cnVjdCBpbnRl
bF92Z3B1X3dvcmtsb2FkICp3b3JrbG9hZCwKPiAgCWlmICghd29ya2xvYWQgfHwgIXJlZ19zdGF0
ZSB8fCB3b3JrbG9hZC0+cmluZ19pZCAhPSBSQ1MpCj4gIAkJcmV0dXJuOwo+ICAKPiArCWRldl9w
cml2ID0gd29ya2xvYWQtPnZncHUtPmd2dC0+ZGV2X3ByaXY7Cj4gKwljdHhfb2FjdHhjdHJsID0g
ZGV2X3ByaXYtPnBlcmYub2EuY3R4X29hY3R4Y3RybF9vZmZzZXQ7Cj4gKwljdHhfZmxleGV1MCA9
IGRldl9wcml2LT5wZXJmLm9hLmN0eF9mbGV4ZXUwX29mZnNldDsKPiArCj4gIAlpZiAoc2F2ZSkg
ewo+ICAJCXdvcmtsb2FkLT5vYWN0eGN0cmwgPSByZWdfc3RhdGVbY3R4X29hY3R4Y3RybCArIDFd
Owo+ICAKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJp
LWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBz
Oi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg==