From mboxrd@z Thu Jan  1 00:00:00 1970
From: Joe Perches <joe@perches.com>
Subject: Re: [PATCH] drm/i915/gvt: don't dereference 'workload'
 before null checking it
Date: Wed, 21 Mar 2018 12:24:10 -0700
Message-ID: <1521660250.7999.29.camel@perches.com>
References: <20180321190653.3829-1-colin.king@canonical.com>
 <1521659361.7999.27.camel@perches.com>
 <a0309d42-a2ab-9270-b486-2325522256b6@canonical.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
In-Reply-To: <a0309d42-a2ab-9270-b486-2325522256b6@canonical.com>
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Colin Ian King <colin.king@canonical.com>, Zhenyu Wang <zhenyuw@linux.intel.com>, Zhi Wang <zhi.a.wang@intel.com>, Jani Nikula <jani.nikula@linux.intel.com>, Joonas Lahtinen <joonas.lahtinen@linux.intel.com>, Rodrigo Vivi <rodrigo.vivi@intel.com>, David Airlie <airlied@linux.ie>, intel-gvt-dev@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org
Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
List-Id: dri-devel@lists.freedesktop.org

T24gV2VkLCAyMDE4LTAzLTIxIGF0IDE5OjE4ICswMDAwLCBDb2xpbiBJYW4gS2luZyB3cm90ZToK
PiBPbiAyMS8wMy8xOCAxOTowOSwgSm9lIFBlcmNoZXMgd3JvdGU6Cj4gPiBPbiBXZWQsIDIwMTgt
MDMtMjEgYXQgMTk6MDYgKzAwMDAsIENvbGluIEtpbmcgd3JvdGU6Cj4gPiA+IEZyb206IENvbGlu
IElhbiBLaW5nIDxjb2xpbi5raW5nQGNhbm9uaWNhbC5jb20+Cj4gPiA+IAo+ID4gPiBUaGUgcG9p
bnRlciB3b3JrbG9hZCBpcyBkZXJlZmVyZW5jZWQgYmVmb3JlIGl0IGlzIG51bGwgY2hlY2tlZCwg
aGVuY2UKPiA+ID4gdGhlcmUgaXMgYSBwb3RlbnRpYWwgZm9yIGEgbnVsbCBwb2ludGVyIGRlcmVm
ZXJlbmNlIG9uIHdvcmtsb2FkLiBGaXgKPiA+ID4gdGhpcyBieSBvbmx5IGRlcmVmZXJlbmNpbmcg
d29ya2xvYWQgYWZ0ZXIgaXQgaXMgbnVsbCBjaGVja2VkLgo+ID4gPiAKPiA+ID4gRGV0ZWN0ZWQg
YnkgQ292ZXJpdHlTY2FuLCBDSUQjMTQ2NjAxNyAoIkRlcmVmZXJlbmNlIGJlZm9yZSBudWxsIGNo
ZWNrIikKPiA+IAo+ID4gTWF5YmUgdHJ1ZSwgYnV0IGlzIGl0IHBvc3NpYmxlIGZvciB3b3JrbG9h
ZCB0byBiZSBudWxsPwo+ID4gTWF5YmUgdGhlIG51bGwgdGVzdCBzaG91bGQgYmUgcmVtb3ZlZCBp
bnN0ZWFkLgo+IAo+IEZyb20gd2hhdCBJIHVuZGVyc3RhbmQgZnJvbSB0aGUgc3RhdGljIGFuYWx5
c2lzLCB0aGVyZSBtYXkgYmUgYQo+IHBvdGVudGlhbCBmb3Igd29ya2xvYWQgdG8gYmUgbnVsbCwg
SSBjb3VsZG4ndCBydWxlIGl0IG91dCBzbyBJIHdlbnQgd2l0aAo+IHRoZSBtb3JlIHBhcmFub2lk
IHN0YW5jZSBvZiBrZWVwaW5nIHRoZSBudWxsIGNoZWNrIGluLgoKd29ya2xvYWQgY2Fubm90IGJl
IG51bGwgaGVyZS4KCkxvb2sgYXQgdGhlIHVzZXMgb2Ygc3Jfb2FfcmVncyBhbmQgc2VlIHRoYXQK
d29ya2xvYWQgaGFzIGFscmVhZHkgYmVlbiBkZXJlZmVyZW5jZWQuCgo+ID4gCj4gPiA+IEZpeGVz
OiBmYTNkZDYyM2U1NTkgKCJkcm0vaTkxNS9ndnQ6IGtlZXAgb2EgY29uZmlnIGluIHNoYWRvdyBj
dHgiKQo+ID4gPiBTaWduZWQtb2ZmLWJ5OiBDb2xpbiBJYW4gS2luZyA8Y29saW4ua2luZ0BjYW5v
bmljYWwuY29tPgo+ID4gPiAtLS0KPiA+ID4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2d2dC9zY2hl
ZHVsZXIuYyB8IDEwICsrKysrKystLS0KPiA+ID4gIDEgZmlsZSBjaGFuZ2VkLCA3IGluc2VydGlv
bnMoKyksIDMgZGVsZXRpb25zKC0pCj4gPiA+IAo+ID4gPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9n
cHUvZHJtL2k5MTUvZ3Z0L3NjaGVkdWxlci5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvZ3Z0L3Nj
aGVkdWxlci5jCj4gPiA+IGluZGV4IDA2ODEyNjQwNDE1MS4uZjMwMTBlMzY1YTQ4IDEwMDY0NAo+
ID4gPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9ndnQvc2NoZWR1bGVyLmMKPiA+ID4gKysr
IGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvZ3Z0L3NjaGVkdWxlci5jCj4gPiA+IEBAIC02MCw5ICs2
MCw5IEBAIHN0YXRpYyB2b2lkIHNldF9jb250ZXh0X3BkcF9yb290X3BvaW50ZXIoCj4gPiA+ICBz
dGF0aWMgdm9pZCBzcl9vYV9yZWdzKHN0cnVjdCBpbnRlbF92Z3B1X3dvcmtsb2FkICp3b3JrbG9h
ZCwKPiA+ID4gIAkJdTMyICpyZWdfc3RhdGUsIGJvb2wgc2F2ZSkKPiA+ID4gIHsKPiA+ID4gLQlz
dHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYgPSB3b3JrbG9hZC0+dmdwdS0+Z3Z0LT5k
ZXZfcHJpdjsKPiA+ID4gLQl1MzIgY3R4X29hY3R4Y3RybCA9IGRldl9wcml2LT5wZXJmLm9hLmN0
eF9vYWN0eGN0cmxfb2Zmc2V0Owo+ID4gPiAtCXUzMiBjdHhfZmxleGV1MCA9IGRldl9wcml2LT5w
ZXJmLm9hLmN0eF9mbGV4ZXUwX29mZnNldDsKPiA+ID4gKwlzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0
ZSAqZGV2X3ByaXY7Cj4gPiA+ICsJdTMyIGN0eF9vYWN0eGN0cmw7Cj4gPiA+ICsJdTMyIGN0eF9m
bGV4ZXUwOwo+ID4gPiAgCWludCBpID0gMDsKPiA+ID4gIAl1MzIgZmxleF9tbWlvW10gPSB7Cj4g
PiA+ICAJCWk5MTVfbW1pb19yZWdfb2Zmc2V0KEVVX1BFUkZfQ05UTDApLAo+ID4gPiBAQCAtNzcs
NiArNzcsMTAgQEAgc3RhdGljIHZvaWQgc3Jfb2FfcmVncyhzdHJ1Y3QgaW50ZWxfdmdwdV93b3Jr
bG9hZCAqd29ya2xvYWQsCj4gPiA+ICAJaWYgKCF3b3JrbG9hZCB8fCAhcmVnX3N0YXRlIHx8IHdv
cmtsb2FkLT5yaW5nX2lkICE9IFJDUykKPiA+ID4gIAkJcmV0dXJuOwo+ID4gPiAgCj4gPiA+ICsJ
ZGV2X3ByaXYgPSB3b3JrbG9hZC0+dmdwdS0+Z3Z0LT5kZXZfcHJpdjsKPiA+ID4gKwljdHhfb2Fj
dHhjdHJsID0gZGV2X3ByaXYtPnBlcmYub2EuY3R4X29hY3R4Y3RybF9vZmZzZXQ7Cj4gPiA+ICsJ
Y3R4X2ZsZXhldTAgPSBkZXZfcHJpdi0+cGVyZi5vYS5jdHhfZmxleGV1MF9vZmZzZXQ7Cj4gPiA+
ICsKPiA+ID4gIAlpZiAoc2F2ZSkgewo+ID4gPiAgCQl3b3JrbG9hZC0+b2FjdHhjdHJsID0gcmVn
X3N0YXRlW2N0eF9vYWN0eGN0cmwgKyAxXTsKPiA+ID4gIAo+IAo+IApfX19fX19fX19fX19fX19f
X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0Cklu
dGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5v
cmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK