dri-devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Lucas Stach <l.stach@pengutronix.de>
To: Daniel Vetter <daniel.vetter@ffwll.ch>,
	DRI Development <dri-devel@lists.freedesktop.org>
Cc: Intel Graphics Development <intel-gfx@lists.freedesktop.org>,
	etnaviv@lists.freedesktop.org,
	Russell King <linux+etnaviv@armlinux.org.uk>
Subject: Re: [PATCH 08/17] drm/etnaviv: Remove unecessary dma_fence_ops
Date: Thu, 03 May 2018 15:43:52 +0200	[thread overview]
Message-ID: <1525355032.3373.5.camel@pengutronix.de> (raw)
In-Reply-To: <20180427061724.28497-9-daniel.vetter@ffwll.ch>

Am Freitag, den 27.04.2018, 08:17 +0200 schrieb Daniel Vetter:
> dma_fence_default_wait is the default now, same for the trivial
> enable_signaling implementation.
> 
> > Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
> > Cc: Lucas Stach <l.stach@pengutronix.de>
> > Cc: Russell King <linux+etnaviv@armlinux.org.uk>
> > Cc: Christian Gmeiner <christian.gmeiner@gmail.com>
> Cc: etnaviv@lists.freedesktop.org

I guess you are going to take the whole series through drm-misc, right?
If so:

Acked-by: Lucas Stach <l.stach@pengutronix.de>

> ---
>  drivers/gpu/drm/etnaviv/etnaviv_gpu.c | 7 -------
>  1 file changed, 7 deletions(-)
> 
> diff --git a/drivers/gpu/drm/etnaviv/etnaviv_gpu.c b/drivers/gpu/drm/etnaviv/etnaviv_gpu.c
> index 8a88799bf79b..b78d9f49aa23 100644
> --- a/drivers/gpu/drm/etnaviv/etnaviv_gpu.c
> +++ b/drivers/gpu/drm/etnaviv/etnaviv_gpu.c
> @@ -1038,11 +1038,6 @@ static const char *etnaviv_fence_get_timeline_name(struct dma_fence *fence)
> >  	return dev_name(f->gpu->dev);
>  }
>  
> -static bool etnaviv_fence_enable_signaling(struct dma_fence *fence)
> -{
> > -	return true;
> -}
> -
>  static bool etnaviv_fence_signaled(struct dma_fence *fence)
>  {
> >  	struct etnaviv_fence *f = to_etnaviv_fence(fence);
> @@ -1060,9 +1055,7 @@ static void etnaviv_fence_release(struct dma_fence *fence)
>  static const struct dma_fence_ops etnaviv_fence_ops = {
> >  	.get_driver_name = etnaviv_fence_get_driver_name,
> >  	.get_timeline_name = etnaviv_fence_get_timeline_name,
> > -	.enable_signaling = etnaviv_fence_enable_signaling,
> >  	.signaled = etnaviv_fence_signaled,
> > -	.wait = dma_fence_default_wait,
> >  	.release = etnaviv_fence_release,
>  };
>  
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2018-05-03 13:43 UTC|newest]

Thread overview: 37+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-27  6:17 [PATCH 00/17] dma-fence doc polish and small cleanup Daniel Vetter
2018-04-27  6:17 ` [PATCH 01/17] dma-fence: Some kerneldoc polish for dma-fence.h Daniel Vetter
2018-04-30 17:49   ` Eric Anholt
2018-05-02  7:38     ` [Intel-gfx] " Daniel Vetter
2018-04-27  6:17 ` [PATCH 02/17] dma-fence: remove fill_driver_data callback Daniel Vetter
2018-04-30 17:49   ` Eric Anholt
2018-05-02  8:23   ` [PATCH] " Daniel Vetter
2018-05-02 16:57     ` Eric Anholt
2018-04-27  6:17 ` [PATCH 03/17] dma-fence: Make ->enable_signaling optional Daniel Vetter
2018-04-27  6:17 ` [PATCH 04/17] dma-fence: Allow wait_any_timeout for all fences Daniel Vetter
2018-04-29  7:11   ` Christian König
2018-04-30 15:35     ` Daniel Vetter
2018-04-27  6:17 ` [PATCH 05/17] dma-fence: Make ->wait callback optional Daniel Vetter
2018-04-27  6:17 ` [PATCH 06/17] drm/amdgpu: Remove unecessary dma_fence_ops Daniel Vetter
2018-04-29  7:12   ` Christian König
2018-04-27  6:17 ` [PATCH 07/17] drm: " Daniel Vetter
2018-04-30 17:51   ` Eric Anholt
2018-04-27  6:17 ` [PATCH 08/17] drm/etnaviv: " Daniel Vetter
2018-05-03 13:43   ` Lucas Stach [this message]
2018-04-27  6:17 ` [PATCH 09/17] drm/i915: " Daniel Vetter
     [not found] ` <20180427061724.28497-1-daniel.vetter-/w4YWyX8dFk@public.gmane.org>
2018-04-27  6:17   ` [PATCH 10/17] drm/msm: " Daniel Vetter
2018-04-27  6:17   ` [PATCH 11/17] drm/nouveau: " Daniel Vetter
2018-04-27  6:17 ` [PATCH 12/17] drm/qxl: " Daniel Vetter
2018-04-30 17:53   ` Eric Anholt
2018-05-02  8:23   ` [PATCH] " Daniel Vetter
2018-04-27  6:17 ` [PATCH 13/17] drm/radeon: Remove custom dma_fence_ops->wait implementation Daniel Vetter
2018-04-29  7:08   ` Christian König
2018-04-30 15:38     ` Daniel Vetter
     [not found]       ` <20180430153854.GR12521-dv86pmgwkMBes7Z6vYuT8azUEOm+Xw19@public.gmane.org>
2018-04-30 18:26         ` Christian König
     [not found]           ` <ba53bdbd-3311-5836-4529-5374ccf6584a-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2018-04-30 19:35             ` Daniel Vetter
2018-04-27  6:17 ` [PATCH 14/17] drm/vc4: Remove unecessary dma_fence_ops Daniel Vetter
2018-04-30 17:50   ` Eric Anholt
2018-04-27  6:17 ` [PATCH 15/17] drm/vgem: " Daniel Vetter
2018-04-27  6:17 ` [PATCH 16/17] drm/virtio: " Daniel Vetter
2018-04-30 17:54   ` Eric Anholt
2018-04-27  6:17 ` [PATCH 17/17] dma-fence: Polish kernel-doc for dma-fence.c Daniel Vetter
2018-04-29  7:15 ` [PATCH 00/17] dma-fence doc polish and small cleanup Christian König

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1525355032.3373.5.camel@pengutronix.de \
    --to=l.stach@pengutronix.de \
    --cc=daniel.vetter@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=etnaviv@lists.freedesktop.org \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=linux+etnaviv@armlinux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox