From: CK Hu <ck.hu@mediatek.com>
To: Daniel Stone <daniels@collabora.com>
Cc: Thierry Reding <treding@nvidia.com>, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH v2 1/3] drm/mtk: Remove impossible internal error
Date: Mon, 21 May 2018 09:50:25 +0800 [thread overview]
Message-ID: <1526867425.3000.2.camel@mtksdaap41> (raw)
In-Reply-To: <20180518134705.12533-1-daniels@collabora.com>
On Fri, 2018-05-18 at 14:47 +0100, Daniel Stone wrote:
> We cannot create a framebuffer with no objects, so there's no point
> testing for it.
>
> v2: Remove the error entirely. (Sean, CK, Thierry)
>
Reviewed-by: CK Hu <ck.hu@mediatek.com>
> Signed-off-by: Daniel Stone <daniels@collabora.com>
> Cc: Sean Paul <seanpaul@chromium.org>
> Cc: Thierry Reding <treding@nvidia.com>
> Cc: CK Hu <ck.hu@mediatek.com>
> Cc: Philipp Zabel <p.zabel@pengutronix.de>
> ---
> drivers/gpu/drm/mediatek/mtk_drm_plane.c | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/drivers/gpu/drm/mediatek/mtk_drm_plane.c b/drivers/gpu/drm/mediatek/mtk_drm_plane.c
> index 2f4b0ffee598..149fc4372917 100644
> --- a/drivers/gpu/drm/mediatek/mtk_drm_plane.c
> +++ b/drivers/gpu/drm/mediatek/mtk_drm_plane.c
> @@ -95,11 +95,6 @@ static int mtk_plane_atomic_check(struct drm_plane *plane,
> if (!fb)
> return 0;
>
> - if (!mtk_fb_get_gem_obj(fb)) {
> - DRM_DEBUG_KMS("buffer is null\n");
> - return -EFAULT;
> - }
> -
> if (!state->crtc)
> return 0;
>
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2018-05-21 1:50 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-18 13:47 [PATCH v2 1/3] drm/mtk: Remove impossible internal error Daniel Stone
2018-05-18 13:47 ` [PATCH v2 2/3] drm/mtk: Move GEM BO to drm_framebuffer Daniel Stone
2018-05-18 13:47 ` [PATCH v2 3/3] drm/mtk: mtk_drm_fb -> drm_framebuffer Daniel Stone
2018-05-18 14:29 ` [PATCH v2 1/3] drm/mtk: Remove impossible internal error Thierry Reding
2018-05-21 1:50 ` CK Hu [this message]
2018-07-02 1:46 ` CK Hu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1526867425.3000.2.camel@mtksdaap41 \
--to=ck.hu@mediatek.com \
--cc=daniels@collabora.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=treding@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).