From: CK Hu <ck.hu@mediatek.com>
To: Bibby Hsieh <bibby.hsieh@mediatek.com>
Cc: linux-kernel@vger.kernel.org,
Sascha Hauer <kernel@pengutronix.de>,
David Airlie <airlied@linux.ie>,
Daniel Vetter <daniel.vetter@ffwll.ch>,
Cawa Cheng <cawa.cheng@mediatek.com>,
dri-devel@lists.freedesktop.org,
Mao Huang <littlecvr@chromium.org>,
Thierry Reding <thierry.reding@gmail.com>,
linux-mediatek@lists.infradead.org,
Matthias Brugger <matthias.bgg@gmail.com>,
Yingjoe Chen <yingjoe.chen@mediatek.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v1 6/7] drm/mediatek: add a error return value when clock driver has been prepared
Date: Mon, 28 May 2018 17:12:42 +0800 [thread overview]
Message-ID: <1527498762.14913.6.camel@mtksdaap41> (raw)
In-Reply-To: <20180514075243.5442-7-bibby.hsieh@mediatek.com>
Hi, Bibby:
On Mon, 2018-05-14 at 15:52 +0800, Bibby Hsieh wrote:
> DRM driver get the comp->clk by of_clk_get(), we only
> assign NULL to comp->clk when error happened, but do
> not return the error number.
>
Reviewed-by: CK Hu <ck.hu@mediatek.com>
> Signed-off-by: Bibby Hsieh <bibby.hsieh@mediatek.com>
> ---
> drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c b/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c
> index 4672317e3ad1..d38a5303f8fc 100644
> --- a/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c
> +++ b/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c
> @@ -283,7 +283,7 @@ int mtk_ddp_comp_init(struct device *dev, struct device_node *node,
> comp->irq = of_irq_get(node, 0);
> comp->clk = of_clk_get(node, 0);
> if (IS_ERR(comp->clk))
> - comp->clk = NULL;
> + return PTR_ERR(comp->clk);
>
> /* Only DMA capable components need the LARB property */
> comp->larb_dev = NULL;
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2018-05-28 9:12 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-14 7:52 [PATCH v1 0/7] drm/mediatek: support hdmi output for mt2701 and mt7623 Bibby Hsieh
2018-05-14 7:52 ` [PATCH v1 1/7] drm/mediatek: move dpi private data to device Bibby Hsieh
2018-05-28 8:25 ` CK Hu
2018-05-14 7:52 ` [PATCH v1 2/7] drm/mediatek: fix to get right bridge for dpi encoder Bibby Hsieh
2018-05-28 8:30 ` CK Hu
2018-05-14 7:52 ` [PATCH v1 3/7] drm/mediatek: add dpi driver for mt2701 and mt7623 Bibby Hsieh
2018-05-28 9:11 ` CK Hu
2018-05-14 7:52 ` [PATCH v1 4/7] drm/mediatek: add hdmi driver for different hardware Bibby Hsieh
2018-05-28 8:32 ` CK Hu
2018-05-14 7:52 ` [PATCH v1 5/7] drm/mediatek: implement connection from BLS to DPI0 Bibby Hsieh
2018-05-28 9:05 ` CK Hu
2018-05-14 7:52 ` [PATCH v1 6/7] drm/mediatek: add a error return value when clock driver has been prepared Bibby Hsieh
2018-05-28 9:12 ` CK Hu [this message]
2018-05-14 7:52 ` [PATCH v1 7/7] drm/mediatek: config component output by device node port Bibby Hsieh
2018-05-28 8:38 ` CK Hu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1527498762.14913.6.camel@mtksdaap41 \
--to=ck.hu@mediatek.com \
--cc=airlied@linux.ie \
--cc=bibby.hsieh@mediatek.com \
--cc=cawa.cheng@mediatek.com \
--cc=daniel.vetter@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=littlecvr@chromium.org \
--cc=matthias.bgg@gmail.com \
--cc=thierry.reding@gmail.com \
--cc=yingjoe.chen@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).