Re: [PATCH v8 3/4] drm/panel: add Innolux TV123WAM panel driver support

Sean Paul
2018-06-05T22:14:48Z

On Tue, Jun 05, 2018 at 11:10:17AM +0530, Sandeep Panda wrote:
> Add support for Innolux TV123WAM, which is a 12.3" eDP
> display panel with 2160x1440 resolution.
>
> Changes in v1:
> - Add the compatibility string, display_mode and panel_desc
> structures in alphabetical order (Sean Paul).
>
> Signed-off-by: Sandeep Panda <spanda@codeaurora.org>

Reviewed-by: Sean Paul <seanpaul@chromium.org>

> ---
> drivers/gpu/drm/panel/panel-simple.c | 27 +++++++++++++++++++++++++++
> 1 file changed, 27 insertions(+)
>
> diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c
> index 234af81..8c72270 100644
> --- a/drivers/gpu/drm/panel/panel-simple.c
> +++ b/drivers/gpu/drm/panel/panel-simple.c
> @@ -1190,6 +1190,30 @@ static void panel_simple_shutdown(struct device *dev)
> },
> };
>
> +static const struct drm_display_mode innolux_tv123wam_mode = {
> + .clock = 206016,
> + .hdisplay = 2160,
> + .hsync_start = 2160 + 48,
> + .hsync_end = 2160 + 48 + 32,
> + .htotal = 2160 + 48 + 32 + 80,
> + .vdisplay = 1440,
> + .vsync_start = 1440 + 3,
> + .vsync_end = 1440 + 3 + 10,
> + .vtotal = 1440 + 3 + 10 + 27,
> + .vrefresh = 60,
> + .flags = DRM_MODE_FLAG_PHSYNC | DRM_MODE_FLAG_PVSYNC,
> +};
> +
> +static const struct panel_desc innolux_tv123wam = {
> + .modes = &innolux_tv123wam_mode,
> + .num_modes = 1,
> + .bpc = 8,
> + .size = {
> + .width = 259,
> + .height = 173,
> + },
> +};
> +
> static const struct drm_display_mode innolux_zj070na_01p_mode = {
> .clock = 51501,
> .hdisplay = 1024,
> @@ -2037,6 +2061,9 @@ static void panel_simple_shutdown(struct device *dev)
> .compatible = "innolux,n156bge-l21",
> .data = &innolux_n156bge_l21,
> }, {
> + .compatible = "innolux,tv123wam",
> + .data = &innolux_tv123wam,
> + }, {
> .compatible = "innolux,zj070na-01p",
> .data = &innolux_zj070na_01p,
> }, {
> --
> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
> a Linux Foundation Collaborative Project
>

--
Sean Paul, Software Engineer, Google / Chromium OS