From: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>
To: Ville Syrjala <ville.syrjala@linux.intel.com>,
dri-devel@lists.freedesktop.org
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 11/14] drm/i915: Fix DP-MST crtc_mask
Date: Fri, 15 Jun 2018 11:33:01 -0700 [thread overview]
Message-ID: <1529087581.7432.118.camel@intel.com> (raw)
In-Reply-To: <20180615164925.28971-12-ville.syrjala@linux.intel.com>
On Fri, 2018-06-15 at 19:49 +0300, Ville Syrjala wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> Each fake MST encoder is tied to a specific pipe. Fix the encoder's
> crtc_mask to reflect that fact.
>
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> ---
> drivers/gpu/drm/i915/intel_dp_mst.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_dp_mst.c
> b/drivers/gpu/drm/i915/intel_dp_mst.c
> index 5890500a3a8b..8e30765402b4 100644
> --- a/drivers/gpu/drm/i915/intel_dp_mst.c
> +++ b/drivers/gpu/drm/i915/intel_dp_mst.c
> @@ -565,7 +565,7 @@ intel_dp_create_fake_mst_encoder(struct
> intel_digital_port *intel_dig_port, enum
> intel_encoder->type = INTEL_OUTPUT_DP_MST;
> intel_encoder->power_domain = intel_dig_port-
> >base.power_domain;
> intel_encoder->port = intel_dig_port->base.port;
> - intel_encoder->crtc_mask = 0x7;
> + intel_encoder->crtc_mask = BIT(pipe);
How did this not cause any problems? Does this mean this field was/is
unused?
Disclaimer: I didn't look at the whole series.
> intel_encoder->cloneable = 0;
>
> intel_encoder->compute_config = intel_dp_mst_compute_config;
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2018-06-15 18:33 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-15 16:49 [PATCH 00/14] drm: Try to fix encoder possible_clones/crtcs Ville Syrjala
2018-06-15 16:49 ` [PATCH 01/14] drm: Add drm_encoder_mask() Ville Syrjala
2018-06-15 16:49 ` [PATCH 02/14] drm: Include the encoder itself in possible_clones Ville Syrjala
2018-06-15 16:49 ` [PATCH 03/14] drm/gma500: Sanitize possible_clones Ville Syrjala
2018-06-15 16:49 ` [PATCH 04/14] drm/sti: Remove pointless casts Ville Syrjala
2018-06-18 7:53 ` Benjamin Gaignard
2018-06-15 16:49 ` [PATCH 05/14] drm/sti: Try to fix up the tvout possible clones Ville Syrjala
2018-06-18 8:16 ` Benjamin Gaignard
2018-06-18 12:38 ` [PATCH v2 " Ville Syrjala
2018-06-20 9:02 ` Benjamin Gaignard
2018-06-15 16:49 ` [PATCH 06/14] drm/exynos: Use drm_encoder_mask() Ville Syrjala
2018-06-15 16:49 ` [PATCH 07/14] drm/imx: Remove the bogus possible_clones setup Ville Syrjala
2018-06-15 16:49 ` [PATCH 08/14] drm: Validate encoder->possible_clones Ville Syrjala
2018-06-15 16:49 ` [PATCH 09/14] drm/i915: Use drm_encoder_mask() Ville Syrjala
2018-06-15 16:49 ` [PATCH 10/14] drm/i915: Populate possible_crtcs correctly Ville Syrjala
2018-06-22 1:26 ` Dhinakaran Pandiyan
2018-06-25 11:10 ` Ville Syrjälä
2018-06-25 18:37 ` Dhinakaran Pandiyan
2018-06-15 16:49 ` [PATCH 11/14] drm/i915: Fix DP-MST crtc_mask Ville Syrjala
2018-06-15 18:33 ` Dhinakaran Pandiyan [this message]
2018-06-15 18:43 ` Ville Syrjälä
2018-06-22 0:36 ` [Intel-gfx] " Dhinakaran Pandiyan
2018-06-15 16:49 ` [PATCH 12/14] drm/i915: Clean up encoder->crtc_mask setup Ville Syrjala
2018-06-18 18:27 ` Jani Nikula
2018-06-15 16:49 ` [PATCH 13/14] drm/i915: Simplfy LVDS crtc_mask setup Ville Syrjala
2018-06-15 16:49 ` [PATCH 14/14] drm: Validate encoder->possible_crtcs Ville Syrjala
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1529087581.7432.118.camel@intel.com \
--to=dhinakaran.pandiyan@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox