From: Philipp Zabel <p.zabel@pengutronix.de>
To: Steve Longerbeam <slongerbeam@gmail.com>, linux-media@vger.kernel.org
Cc: Steve Longerbeam <steve_longerbeam@mentor.com>,
open list <linux-kernel@vger.kernel.org>,
"open list:DRM DRIVERS FOR FREESCALE IMX"
<dri-devel@lists.freedesktop.org>
Subject: Re: [PATCH v3 04/14] gpu: ipu-v3: Fix U/V offset macros for planar 4:2:0
Date: Thu, 02 Aug 2018 11:51:55 +0200 [thread overview]
Message-ID: <1533203515.3516.13.camel@pengutronix.de> (raw)
In-Reply-To: <1533150747-30677-5-git-send-email-steve_longerbeam@mentor.com>
On Wed, 2018-08-01 at 12:12 -0700, Steve Longerbeam wrote:
> The U and V offset macros for planar 4:2:0 (U_OFFSET, V_OFFSET, and
> UV_OFFSET), are not correct. The height component to the offset was
> calculated as:
>
> (pix->width * y / 4)
>
> But this does not produce correct offsets for odd values of y (luma
> line #). The luma line # must be decimated by two to produce the
> correct U/V line #, so the correct formula is:
>
> (pix->width * (y / 2) / 2)
>
> Signed-off-by: Steve Longerbeam <steve_longerbeam@mentor.com>
Thank you this patch is applied to imx-drm/fixes now.
regards
Philipp
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2018-08-02 9:51 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1533150747-30677-1-git-send-email-steve_longerbeam@mentor.com>
2018-08-01 19:12 ` [PATCH v3 02/14] gpu: ipu-csi: Check for field type alternate Steve Longerbeam
2018-08-02 9:42 ` Philipp Zabel
2018-08-04 19:08 ` Steve Longerbeam
2018-08-01 19:12 ` [PATCH v3 03/14] gpu: ipu-csi: Swap fields according to input/output field types Steve Longerbeam
2018-08-01 19:12 ` [PATCH v3 04/14] gpu: ipu-v3: Fix U/V offset macros for planar 4:2:0 Steve Longerbeam
2018-08-02 9:51 ` Philipp Zabel [this message]
2018-08-01 19:12 ` [PATCH v3 05/14] gpu: ipu-v3: Allow negative offsets for interlaced scanning Steve Longerbeam
2018-08-02 9:46 ` Philipp Zabel
2018-08-04 19:25 ` Steve Longerbeam
2018-08-01 19:12 ` [PATCH v3 06/14] gpu: ipu-v3: Add planar support to interlaced scan Steve Longerbeam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1533203515.3516.13.camel@pengutronix.de \
--to=p.zabel@pengutronix.de \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=slongerbeam@gmail.com \
--cc=steve_longerbeam@mentor.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox