From: Ulrich Hecht <uli+renesas@fpond.eu>
To: laurent.pinchart@ideasonboard.com
Cc: Koji Matsuoka <koji.matsuoka.xm@renesas.com>,
dri-devel@lists.freedesktop.org,
linux-renesas-soc@vger.kernel.org,
kieran.bingham+renesas@ideasonboard.com,
jacopo+renesas@jmondi.org, Ulrich Hecht <uli+renesas@fpond.eu>
Subject: [PROTO][PATCH 05/10] drm/bridge: adv7511: Add max-clock, min-vrefresh options
Date: Tue, 14 Aug 2018 15:49:59 +0200 [thread overview]
Message-ID: <1534254604-24204-6-git-send-email-uli+renesas@fpond.eu> (raw)
In-Reply-To: <1534254604-24204-1-git-send-email-uli+renesas@fpond.eu>
From: Koji Matsuoka <koji.matsuoka.xm@renesas.com>
This patch adds the option to specify a maximal clock and a minimal vertical
refresh rate.
Signed-off-by: Koji Matsuoka <koji.matsuoka.xm@renesas.com>
[uli: renamed properties, fixed transposed parsing]
Signed-off-by: Ulrich Hecht <uli+renesas@fpond.eu>
---
drivers/gpu/drm/bridge/adv7511/adv7511.h | 7 +++++++
drivers/gpu/drm/bridge/adv7511/adv7511_drv.c | 22 ++++++++++++++++++++++
2 files changed, 29 insertions(+)
diff --git a/drivers/gpu/drm/bridge/adv7511/adv7511.h b/drivers/gpu/drm/bridge/adv7511/adv7511.h
index 73d8ccb..7f29d4f 100644
--- a/drivers/gpu/drm/bridge/adv7511/adv7511.h
+++ b/drivers/gpu/drm/bridge/adv7511/adv7511.h
@@ -271,6 +271,8 @@ enum adv7511_sync_polarity {
* @sync_pulse: Select the sync pulse
* @vsync_polarity: vsync input signal configuration
* @hsync_polarity: hsync input signal configuration
+ * @min_vrefresh_option: min vrefresh option
+ * @max_freq_option: max frequency option
*/
struct adv7511_link_config {
unsigned int input_color_depth;
@@ -285,6 +287,9 @@ struct adv7511_link_config {
enum adv7511_input_sync_pulse sync_pulse;
enum adv7511_sync_polarity vsync_polarity;
enum adv7511_sync_polarity hsync_polarity;
+
+ unsigned int min_vrefresh_option;
+ unsigned int max_freq_option;
};
/**
@@ -354,6 +359,8 @@ struct adv7511 {
enum adv7511_sync_polarity vsync_polarity;
enum adv7511_sync_polarity hsync_polarity;
bool rgb;
+ unsigned int min_vref;
+ unsigned int max_freq;
struct gpio_desc *gpio_pd;
diff --git a/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c b/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c
index 6437b87..2938b02 100644
--- a/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c
+++ b/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c
@@ -323,6 +323,8 @@ static void adv7511_set_link_config(struct adv7511 *adv7511,
adv7511->hsync_polarity = config->hsync_polarity;
adv7511->vsync_polarity = config->vsync_polarity;
adv7511->rgb = config->input_colorspace == HDMI_COLORSPACE_RGB;
+ adv7511->min_vref = config->min_vrefresh_option;
+ adv7511->max_freq = config->max_freq_option;
}
static void __adv7511_power_on(struct adv7511 *adv7511)
@@ -660,6 +662,16 @@ static enum drm_mode_status adv7511_mode_valid(struct adv7511 *adv7511,
if (mode->clock > 165000)
return MODE_CLOCK_HIGH;
+ if (adv7511->max_freq) {
+ if (mode->clock > (adv7511->max_freq / 1000))
+ return MODE_CLOCK_HIGH;
+ }
+
+ if (adv7511->min_vref) {
+ if (drm_mode_vrefresh(mode) < adv7511->min_vref)
+ return MODE_BAD;
+ }
+
return MODE_OK;
}
@@ -1074,6 +1086,16 @@ static int adv7511_parse_dt(struct device_node *np,
config->vsync_polarity = ADV7511_SYNC_POLARITY_PASSTHROUGH;
config->hsync_polarity = ADV7511_SYNC_POLARITY_PASSTHROUGH;
+ ret = of_property_read_u32(np, "max-clock",
+ &config->max_freq_option);
+ if (ret < 0)
+ config->max_freq_option = 0;
+
+ ret = of_property_read_u32(np, "min-vrefresh",
+ &config->min_vrefresh_option);
+ if (ret < 0)
+ config->min_vrefresh_option = 0;
+
return 0;
}
--
2.7.4
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2018-08-14 13:50 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-14 13:49 [PROTO][PATCH 00/10] R-Car D3 LVDS/HDMI support (with PLL) Ulrich Hecht
2018-08-14 13:49 ` [PROTO][PATCH 01/10] drm: rcar-du: Add clk_set_rate for external clock device Ulrich Hecht
2018-08-20 10:10 ` Laurent Pinchart
2018-08-14 13:49 ` [PROTO][PATCH 02/10] drm: rcar-du: Add r8a77995 device support Ulrich Hecht
2018-08-20 8:39 ` Laurent Pinchart
2018-08-14 13:49 ` [PROTO][PATCH 03/10] drm: rcar-du: Fix digital RGB routing for R8A77995 Ulrich Hecht
2018-08-20 9:25 ` Laurent Pinchart
2018-08-14 13:49 ` [PROTO][PATCH 04/10] drm: rcar-du: lvds: LVDS PLL support Ulrich Hecht
2018-08-20 10:48 ` Laurent Pinchart
2018-08-14 13:49 ` Ulrich Hecht [this message]
2018-08-20 9:28 ` [PROTO][PATCH 05/10] drm/bridge: adv7511: Add max-clock, min-vrefresh options Laurent Pinchart
2018-08-21 8:03 ` Ulrich Hecht
2018-08-21 8:09 ` Laurent Pinchart
2018-08-22 9:13 ` Ulrich Hecht
2018-08-22 14:00 ` Laurent Pinchart
2018-08-14 13:50 ` [PROTO][PATCH 06/10] drm: rcar-du: Fix procedure for extal and dotclkin selection Ulrich Hecht
2018-08-20 9:40 ` Laurent Pinchart
2018-08-14 13:50 ` [PROTO][PATCH 07/10] arm64: dts: r8a77995-draak: set external clock for DU Ulrich Hecht
2018-08-20 10:51 ` Laurent Pinchart
2018-08-14 13:50 ` [PROTO][PATCH 08/10] drm: rcar-du: lvds: Handle LVDS interface reset Ulrich Hecht
2018-08-14 13:50 ` [PROTO][PATCH 09/10] arm64: dts: renesas: r8a77995: Add LVDS support Ulrich Hecht
2018-08-14 13:50 ` [PROTO][PATCH 10/10] arm64: dts: renesas: r8a77995-draak: add HDMI output Ulrich Hecht
2018-08-20 11:01 ` Laurent Pinchart
2018-08-20 9:50 ` [PROTO][PATCH 00/10] R-Car D3 LVDS/HDMI support (with PLL) Laurent Pinchart
2018-08-21 8:02 ` Ulrich Hecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1534254604-24204-6-git-send-email-uli+renesas@fpond.eu \
--to=uli+renesas@fpond.eu \
--cc=dri-devel@lists.freedesktop.org \
--cc=jacopo+renesas@jmondi.org \
--cc=kieran.bingham+renesas@ideasonboard.com \
--cc=koji.matsuoka.xm@renesas.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-renesas-soc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).