From: Huang Rui <ray.huang@amd.com>
To: dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org
Cc: "Huang Rui" <ray.huang@amd.com>,
"Christian König" <christian.koenig@amd.com>
Subject: [PATCH v4 3/5] drm/ttm: add bulk move function on LRU
Date: Fri, 17 Aug 2018 18:07:59 +0800 [thread overview]
Message-ID: <1534500481-15123-4-git-send-email-ray.huang@amd.com> (raw)
In-Reply-To: <1534500481-15123-1-git-send-email-ray.huang@amd.com>
This function allow us to bulk move a group of BOs to the tail of their LRU.
The positions of group of BOs are stored on the (first, last) bulk_move_pos
structure.
Signed-off-by: Christian König <christian.koenig@amd.com>
Signed-off-by: Huang Rui <ray.huang@amd.com>
Tested-by: Mike Lothian <mike@fireburn.co.uk>
Tested-by: Dieter Nützel <Dieter@nuetzel-hh.de>
Acked-by: Chunming Zhou <david1.zhou@amd.com>
Reviewed-by: Junwei Zhang <Jerry.Zhang@amd.com>
---
drivers/gpu/drm/ttm/ttm_bo.c | 52 ++++++++++++++++++++++++++++++++++++++++++++
include/drm/ttm/ttm_bo_api.h | 10 +++++++++
2 files changed, 62 insertions(+)
diff --git a/drivers/gpu/drm/ttm/ttm_bo.c b/drivers/gpu/drm/ttm/ttm_bo.c
index 7117b6b..39d9d55 100644
--- a/drivers/gpu/drm/ttm/ttm_bo.c
+++ b/drivers/gpu/drm/ttm/ttm_bo.c
@@ -247,6 +247,58 @@ void ttm_bo_move_to_lru_tail(struct ttm_buffer_object *bo,
}
EXPORT_SYMBOL(ttm_bo_move_to_lru_tail);
+static void ttm_bo_bulk_move_helper(struct ttm_lru_bulk_move_pos *pos,
+ struct list_head *lru, bool is_swap)
+{
+ struct list_head entries, before;
+ struct list_head *list1, *list2;
+
+ list1 = is_swap ? &pos->last->swap : &pos->last->lru;
+ list2 = is_swap ? pos->first->swap.prev : pos->first->lru.prev;
+
+ list_cut_position(&entries, lru, list1);
+ list_cut_position(&before, &entries, list2);
+ list_splice(&before, lru);
+ list_splice_tail(&entries, lru);
+}
+
+void ttm_bo_bulk_move_lru_tail(struct ttm_lru_bulk_move *bulk)
+{
+ unsigned i;
+
+ for (i = 0; i < TTM_MAX_BO_PRIORITY; ++i) {
+ struct ttm_mem_type_manager *man;
+
+ if (!bulk->tt[i].first)
+ continue;
+
+ man = &bulk->tt[i].first->bdev->man[TTM_PL_TT];
+ ttm_bo_bulk_move_helper(&bulk->tt[i], &man->lru[i], false);
+ }
+
+ for (i = 0; i < TTM_MAX_BO_PRIORITY; ++i) {
+ struct ttm_mem_type_manager *man;
+
+ if (!bulk->vram[i].first)
+ continue;
+
+ man = &bulk->vram[i].first->bdev->man[TTM_PL_VRAM];
+ ttm_bo_bulk_move_helper(&bulk->vram[i], &man->lru[i], false);
+ }
+
+ for (i = 0; i < TTM_MAX_BO_PRIORITY; ++i) {
+ struct ttm_lru_bulk_move_pos *pos = &bulk->swap[i];
+ struct list_head *lru;
+
+ if (!pos->first)
+ continue;
+
+ lru = &pos->first->bdev->glob->swap_lru[i];
+ ttm_bo_bulk_move_helper(&bulk->swap[i], lru, true);
+ }
+}
+EXPORT_SYMBOL(ttm_bo_bulk_move_lru_tail);
+
static int ttm_bo_handle_move_mem(struct ttm_buffer_object *bo,
struct ttm_mem_reg *mem, bool evict,
struct ttm_operation_ctx *ctx)
diff --git a/include/drm/ttm/ttm_bo_api.h b/include/drm/ttm/ttm_bo_api.h
index 0d4eb81..8c19470 100644
--- a/include/drm/ttm/ttm_bo_api.h
+++ b/include/drm/ttm/ttm_bo_api.h
@@ -417,6 +417,16 @@ void ttm_bo_move_to_lru_tail(struct ttm_buffer_object *bo,
struct ttm_lru_bulk_move *bulk);
/**
+ * ttm_bo_bulk_move_lru_tail
+ *
+ * @bulk: bulk move structure
+ *
+ * Bulk move BOs to the LRU tail, only valid to use when driver makes sure that
+ * BO order never changes. Should be called with ttm_bo_global::lru_lock held.
+ */
+void ttm_bo_bulk_move_lru_tail(struct ttm_lru_bulk_move *bulk);
+
+/**
* ttm_bo_lock_delayed_workqueue
*
* Prevent the delayed workqueue from running.
--
2.7.4
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2018-08-17 10:07 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-17 10:07 [PATCH v4 0/5] drm/ttm,amdgpu: Introduce LRU bulk move functionality Huang Rui
2018-08-17 10:07 ` [PATCH v4 1/5] drm/ttm: add helper structures for bulk moves on lru list Huang Rui
2018-08-17 10:07 ` [PATCH v4 2/5] drm/ttm: revise ttm_bo_move_to_lru_tail to support bulk moves Huang Rui
2018-08-17 10:07 ` Huang Rui [this message]
2018-08-17 10:08 ` [PATCH v4 4/5] drm/amdgpu: use bulk moves for efficient VM LRU handling (v4) Huang Rui
2018-08-17 10:38 ` Christian König
[not found] ` <aca4bd35-af39-2b08-545e-38305f2ac000-5C7GfCeVMHo@public.gmane.org>
2018-08-20 6:05 ` Huang Rui
2018-08-20 13:17 ` Christian König
2018-08-21 13:43 ` Huang Rui
2018-08-21 13:54 ` Christian König
[not found] ` <d527210c-33c3-d5e6-ccf7-ac308139d1e2-5C7GfCeVMHo@public.gmane.org>
2018-08-22 3:31 ` Huang Rui
2018-08-22 7:29 ` Huang Rui
[not found] ` <1534500481-15123-1-git-send-email-ray.huang-5C7GfCeVMHo@public.gmane.org>
2018-08-17 10:08 ` [PATCH v4 5/5] drm/amdgpu: move PD/PT bos on LRU again Huang Rui
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1534500481-15123-4-git-send-email-ray.huang@amd.com \
--to=ray.huang@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=christian.koenig@amd.com \
--cc=dri-devel@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).