From mboxrd@z Thu Jan  1 00:00:00 1970
From: Mika Kahola <mika.kahola@intel.com>
Subject: Re: [igt-dev] [PATCH v2 1/3] lib/igt_kms: Add try_prop_enum and
 set_prop_enum for mode objects, v2.
Date: Fri, 24 Aug 2018 10:29:53 +0300
Message-ID: <1535095793.30780.45.camel@intel.com>
References: <20180815100851.22219-1-maarten.lankhorst@linux.intel.com>
Reply-To: mika.kahola@intel.com
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Return-path: <dri-devel-bounces@lists.freedesktop.org>
In-Reply-To: <20180815100851.22219-1-maarten.lankhorst@linux.intel.com>
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/dri-devel>,
 <mailto:dri-devel-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/dri-devel>
List-Post: <mailto:dri-devel@lists.freedesktop.org>
List-Help: <mailto:dri-devel-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/dri-devel>,
 <mailto:dri-devel-request@lists.freedesktop.org?subject=subscribe>
Errors-To: dri-devel-bounces@lists.freedesktop.org
Sender: "dri-devel" <dri-devel-bounces@lists.freedesktop.org>
To: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>, igt-dev@lists.freedesktop.org
Cc: Lowry Li <lowry.li@arm.com>, Liviu Dudau <liviu.dudau@arm.com>, dri-devel@lists.freedesktop.org
List-Id: dri-devel@lists.freedesktop.org

TG9va3Mgb2sgdG8gbWUuCgpSZXZpZXdlZC1ieTogTWlrYSBLYWhvbGEgPG1pa2Eua2Fob2xhQGlu
dGVsLmNvbT4KCk9uIFdlZCwgMjAxOC0wOC0xNSBhdCAxMjowOCArMDIwMCwgTWFhcnRlbiBMYW5r
aG9yc3Qgd3JvdGU6Cj4gVGhpcyBhZGRzIHRoZSBwb3NzaWJpbGl0eSB0byB0ZXN0IGFyYml0cmFy
eSBlbnVtZXJhdGlvbnMgaW4gSUdUCj4gd2l0aG91dAo+IGhhdmluZyB0byBkZWZpbmUgbWFwcGlu
Z3MgZm9yIGVhY2ggYW5kIGV2ZXJ5IG9uZS4KPiAKPiBDaGFuZ2VzIHNpbmNlIHYxOgo+IC0gQWRk
IGNvbW1pdCBkZXNjcmlwdGlvbi4KPiAtIEFkZCB0cnlfcHJvcF9lbnVtLCB0byBhbGxvdyBoYW5k
bGluZyB1bmtub3duIGVudW1lcmF0aW9ucy4KPiAKPiBTaWduZWQtb2ZmLWJ5OiBNYWFydGVuIExh
bmtob3JzdCA8bWFhcnRlbi5sYW5raG9yc3RAbGludXguaW50ZWwuY29tPgo+IC0tLQo+IMKgbGli
L2lndF9rbXMuYyB8IDkwCj4gKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysr
KysrKysrKysrKysrCj4gwqBsaWIvaWd0X2ttcy5oIHwgMzEgKysrKysrKysrKysrKysrKystCj4g
wqAyIGZpbGVzIGNoYW5nZWQsIDEyMCBpbnNlcnRpb25zKCspLCAxIGRlbGV0aW9uKC0pCj4gCj4g
ZGlmZiAtLWdpdCBhL2xpYi9pZ3Rfa21zLmMgYi9saWIvaWd0X2ttcy5jCj4gaW5kZXggYzllMDBj
M2JkNmE3Li5lNTI3MjEwM2UyNDMgMTAwNjQ0Cj4gLS0tIGEvbGliL2lndF9rbXMuYwo+ICsrKyBi
L2xpYi9pZ3Rfa21zLmMKPiBAQCAtMjg5MSw2ICsyODkxLDQ4IEBAIHVpbnQ2NF90IGlndF9wbGFu
ZV9nZXRfcHJvcChpZ3RfcGxhbmVfdAo+ICpwbGFuZSwgZW51bSBpZ3RfYXRvbWljX3BsYW5lX3By
b3BlcnRpZXMKPiDCoAkJCQkJcGxhbmUtPmRybV9wbGFuZS0+cGxhbmVfaWQsCj4gcGxhbmUtPnBy
b3BzW3Byb3BdKTsKPiDCoH0KPiDCoAo+ICtzdGF0aWMgYm9vbCBpZ3RfbW9kZV9vYmplY3RfZ2V0
X3Byb3BfZW51bV92YWx1ZShpbnQgZHJtX2ZkLCB1aW50MzJfdAo+IGlkLCBjb25zdCBjaGFyICpz
dHIsIHVpbnQ2NF90ICp2YWwpCj4gK3sKPiArCWRybU1vZGVQcm9wZXJ0eVB0ciBwcm9wID0gZHJt
TW9kZUdldFByb3BlcnR5KGRybV9mZCwgaWQpOwo+ICsJaW50IGk7Cj4gKwo+ICsJaWd0X2Fzc2Vy
dChpZCk7Cj4gKwlpZ3RfYXNzZXJ0KHByb3ApOwo+ICsKPiArCWZvciAoaSA9IDA7IGkgPCBwcm9w
LT5jb3VudF9lbnVtczsgaSsrKQo+ICsJCWlmICghc3RyY21wKHN0ciwgcHJvcC0+ZW51bXNbaV0u
bmFtZSkpIHsKPiArCQkJKnZhbCA9IHByb3AtPmVudW1zW2ldLnZhbHVlOwo+ICsJCQlkcm1Nb2Rl
RnJlZVByb3BlcnR5KHByb3ApOwo+ICsJCQlyZXR1cm4gdHJ1ZTsKPiArCQl9Cj4gKwo+ICsJcmV0
dXJuIGZhbHNlOwo+ICt9Cj4gKwo+ICtib29sIGlndF9wbGFuZV90cnlfcHJvcF9lbnVtKGlndF9w
bGFuZV90ICpwbGFuZSwKPiArCQkJwqDCoMKgwqDCoGVudW0gaWd0X2F0b21pY19wbGFuZV9wcm9w
ZXJ0aWVzIHByb3AsCj4gKwkJCcKgwqDCoMKgwqBjb25zdCBjaGFyICp2YWwpCj4gK3sKPiArCWln
dF9kaXNwbGF5X3QgKmRpc3BsYXkgPSBwbGFuZS0+cGlwZS0+ZGlzcGxheTsKPiArCXVpbnQ2NF90
IHV2YWw7Cj4gKwo+ICsJaWd0X2Fzc2VydChwbGFuZS0+cHJvcHNbcHJvcF0pOwo+ICsKPiArCWlm
ICghaWd0X21vZGVfb2JqZWN0X2dldF9wcm9wX2VudW1fdmFsdWUoZGlzcGxheS0+ZHJtX2ZkLAo+
ICsJCQkJCQnCoHBsYW5lLT5wcm9wc1twcm9wXSwgCj4gdmFsLCAmdXZhbCkpCj4gKwkJcmV0dXJu
IGZhbHNlOwo+ICsKPiArCWlndF9wbGFuZV9zZXRfcHJvcF92YWx1ZShwbGFuZSwgcHJvcCwgdXZh
bCk7Cj4gKwlyZXR1cm4gdHJ1ZTsKPiArfQo+ICsKPiArdm9pZCBpZ3RfcGxhbmVfc2V0X3Byb3Bf
ZW51bShpZ3RfcGxhbmVfdCAqcGxhbmUsCj4gKwkJCcKgwqDCoMKgwqBlbnVtIGlndF9hdG9taWNf
cGxhbmVfcHJvcGVydGllcyBwcm9wLAo+ICsJCQnCoMKgwqDCoMKgY29uc3QgY2hhciAqdmFsKQo+
ICt7Cj4gKwlpZ3RfYXNzZXJ0KGlndF9wbGFuZV90cnlfcHJvcF9lbnVtKHBsYW5lLCBwcm9wLCB2
YWwpKTsKPiArfQo+ICsKPiDCoC8qKgo+IMKgICogaWd0X3BsYW5lX3JlcGxhY2VfcHJvcF9ibG9i
Ogo+IMKgICogQHBsYW5lOiBwbGFuZSB0byBzZXQgcHJvcGVydHkgb24uCj4gQEAgLTI5NDIsNiAr
Mjk4NCwzMCBAQCB1aW50NjRfdCBpZ3Rfb3V0cHV0X2dldF9wcm9wKGlndF9vdXRwdXRfdAo+ICpv
dXRwdXQsIGVudW0gaWd0X2F0b21pY19jb25uZWN0b3JfcHJvCj4gwqAJCQkJCW91dHB1dC0+aWQs
IG91dHB1dC0KPiA+cHJvcHNbcHJvcF0pOwo+IMKgfQo+IMKgCj4gK2Jvb2wgaWd0X291dHB1dF90
cnlfcHJvcF9lbnVtKGlndF9vdXRwdXRfdCAqb3V0cHV0LAo+ICsJCQnCoMKgwqDCoMKgwqBlbnVt
IGlndF9hdG9taWNfY29ubmVjdG9yX3Byb3BlcnRpZXMKPiBwcm9wLAo+ICsJCQnCoMKgwqDCoMKg
wqBjb25zdCBjaGFyICp2YWwpCj4gK3sKPiArCWlndF9kaXNwbGF5X3QgKmRpc3BsYXkgPSBvdXRw
dXQtPmRpc3BsYXk7Cj4gKwl1aW50NjRfdCB1dmFsOwo+ICsKPiArCWlndF9hc3NlcnQob3V0cHV0
LT5wcm9wc1twcm9wXSk7Cj4gKwo+ICsJaWYgKCFpZ3RfbW9kZV9vYmplY3RfZ2V0X3Byb3BfZW51
bV92YWx1ZShkaXNwbGF5LT5kcm1fZmQsCj4gKwkJCQkJCcKgb3V0cHV0LQo+ID5wcm9wc1twcm9w
XSwgdmFsLCAmdXZhbCkpCj4gKwkJcmV0dXJuIGZhbHNlOwo+ICsKPiArCWlndF9vdXRwdXRfc2V0
X3Byb3BfdmFsdWUob3V0cHV0LCBwcm9wLCB1dmFsKTsKPiArCXJldHVybiB0cnVlOwo+ICt9Cj4g
Kwo+ICt2b2lkIGlndF9vdXRwdXRfc2V0X3Byb3BfZW51bShpZ3Rfb3V0cHV0X3QgKm91dHB1dCwK
PiArCQkJwqDCoMKgwqDCoMKgZW51bSBpZ3RfYXRvbWljX2Nvbm5lY3Rvcl9wcm9wZXJ0aWVzCj4g
cHJvcCwKPiArCQkJwqDCoMKgwqDCoMKgY29uc3QgY2hhciAqdmFsKQo+ICt7Cj4gKwlpZ3RfYXNz
ZXJ0KGlndF9vdXRwdXRfdHJ5X3Byb3BfZW51bShvdXRwdXQsIHByb3AsIHZhbCkpOwo+ICt9Cj4g
Kwo+IMKgLyoqCj4gwqAgKiBpZ3Rfb3V0cHV0X3JlcGxhY2VfcHJvcF9ibG9iOgo+IMKgICogQG91
dHB1dDogb3V0cHV0IHRvIHNldCBwcm9wZXJ0eSBvbi4KPiBAQCAtMjk5Myw2ICszMDU5LDMwIEBA
IHVpbnQ2NF90IGlndF9waXBlX29ial9nZXRfcHJvcChpZ3RfcGlwZV90Cj4gKnBpcGUsIGVudW0g
aWd0X2F0b21pY19jcnRjX3Byb3BlcnRpZXMKPiDCoAkJCQkJcGlwZS0+Y3J0Y19pZCwgcGlwZS0K
PiA+cHJvcHNbcHJvcF0pOwo+IMKgfQo+IMKgCj4gK2Jvb2wgaWd0X3BpcGVfb2JqX3RyeV9wcm9w
X2VudW0oaWd0X3BpcGVfdCAqcGlwZV9vYmosCj4gKwkJCQllbnVtIGlndF9hdG9taWNfY3J0Y19w
cm9wZXJ0aWVzCj4gcHJvcCwKPiArCQkJCWNvbnN0IGNoYXIgKnZhbCkKPiArewo+ICsJaWd0X2Rp
c3BsYXlfdCAqZGlzcGxheSA9IHBpcGVfb2JqLT5kaXNwbGF5Owo+ICsJdWludDY0X3QgdXZhbDsK
PiArCj4gKwlpZ3RfYXNzZXJ0KHBpcGVfb2JqLT5wcm9wc1twcm9wXSk7Cj4gKwo+ICsJaWYgKCFp
Z3RfbW9kZV9vYmplY3RfZ2V0X3Byb3BfZW51bV92YWx1ZShkaXNwbGF5LT5kcm1fZmQsCj4gKwkJ
CQkJCcKgcGlwZV9vYmotCj4gPnByb3BzW3Byb3BdLCB2YWwsICZ1dmFsKSkKPiArCQlyZXR1cm4g
ZmFsc2U7Cj4gKwo+ICsJaWd0X3BpcGVfb2JqX3NldF9wcm9wX3ZhbHVlKHBpcGVfb2JqLCBwcm9w
LCB1dmFsKTsKPiArCXJldHVybiB0cnVlOwo+ICt9Cj4gKwo+ICt2b2lkIGlndF9waXBlX29ial9z
ZXRfcHJvcF9lbnVtKGlndF9waXBlX3QgKnBpcGVfb2JqLAo+ICsJCQkJZW51bSBpZ3RfYXRvbWlj
X2NydGNfcHJvcGVydGllcwo+IHByb3AsCj4gKwkJCQljb25zdCBjaGFyICp2YWwpCj4gK3sKPiAr
CWlndF9hc3NlcnQoaWd0X3BpcGVfb2JqX3RyeV9wcm9wX2VudW0ocGlwZV9vYmosIHByb3AsIHZh
bCkpOwo+ICt9Cj4gKwo+IMKgLyoqCj4gwqAgKiBpZ3RfcGlwZV9vYmpfcmVwbGFjZV9wcm9wX2Js
b2I6Cj4gwqAgKiBAcGlwZTogcGlwZSB0byBzZXQgcHJvcGVydHkgb24uCj4gZGlmZiAtLWdpdCBh
L2xpYi9pZ3Rfa21zLmggYi9saWIvaWd0X2ttcy5oCj4gaW5kZXggNDIyMmEzNDE4MTAzLi4zYTEy
ZjI3ODJlZWQgMTAwNjQ0Cj4gLS0tIGEvbGliL2lndF9rbXMuaAo+ICsrKyBiL2xpYi9pZ3Rfa21z
LmgKPiBAQCAtNTc0LDYgKzU3NCwxNCBAQCB1aW50NjRfdCBpZ3RfcGxhbmVfZ2V0X3Byb3AoaWd0
X3BsYW5lX3QgKnBsYW5lLAo+IGVudW0gaWd0X2F0b21pY19wbGFuZV9wcm9wZXJ0aWVzCj4gwqAJ
CWlndF9wbGFuZV9zZXRfcHJvcF9jaGFuZ2VkKHBsYW5lLCBwcm9wKTsgXAo+IMKgCX0gd2hpbGUg
KDApCj4gwqAKPiArZXh0ZXJuIGJvb2wgaWd0X3BsYW5lX3RyeV9wcm9wX2VudW0oaWd0X3BsYW5l
X3QgKnBsYW5lLAo+ICsJCQkJwqDCoMKgwqBlbnVtIGlndF9hdG9taWNfcGxhbmVfcHJvcGVydGll
cwo+IHByb3AsCj4gKwkJCQnCoMKgwqDCoGNvbnN0IGNoYXIgKnZhbCk7Cj4gKwo+ICtleHRlcm4g
dm9pZCBpZ3RfcGxhbmVfc2V0X3Byb3BfZW51bShpZ3RfcGxhbmVfdCAqcGxhbmUsCj4gKwkJCQnC
oMKgwqDCoGVudW0gaWd0X2F0b21pY19wbGFuZV9wcm9wZXJ0aWVzCj4gcHJvcCwKPiArCQkJCcKg
wqDCoMKgY29uc3QgY2hhciAqdmFsKTsKPiArCj4gwqBleHRlcm4gdm9pZCBpZ3RfcGxhbmVfcmVw
bGFjZV9wcm9wX2Jsb2IoaWd0X3BsYW5lX3QgKnBsYW5lLAo+IMKgCQkJCQllbnVtCj4gaWd0X2F0
b21pY19wbGFuZV9wcm9wZXJ0aWVzIHByb3AsCj4gwqAJCQkJCWNvbnN0IHZvaWQgKnB0ciwgc2l6
ZV90Cj4gbGVuZ3RoKTsKPiBAQCAtNjA5LDEwICs2MTcsMTcgQEAgdWludDY0X3QgaWd0X291dHB1
dF9nZXRfcHJvcChpZ3Rfb3V0cHV0X3QKPiAqb3V0cHV0LCBlbnVtIGlndF9hdG9taWNfY29ubmVj
dG9yX3Bybwo+IMKgCQlpZ3Rfb3V0cHV0X3NldF9wcm9wX2NoYW5nZWQob3V0cHV0LCBwcm9wKTsg
XAo+IMKgCX0gd2hpbGUgKDApCj4gwqAKPiArZXh0ZXJuIGJvb2wgaWd0X291dHB1dF90cnlfcHJv
cF9lbnVtKGlndF9vdXRwdXRfdCAqb3V0cHV0LAo+ICsJCQkJwqDCoMKgwqDCoGVudW0KPiBpZ3Rf
YXRvbWljX2Nvbm5lY3Rvcl9wcm9wZXJ0aWVzIHByb3AsCj4gKwkJCQnCoMKgwqDCoMKgY29uc3Qg
Y2hhciAqdmFsKTsKPiArCj4gK2V4dGVybiB2b2lkIGlndF9vdXRwdXRfc2V0X3Byb3BfZW51bShp
Z3Rfb3V0cHV0X3QgKm91dHB1dCwKPiArCQkJCcKgwqDCoMKgwqBlbnVtCj4gaWd0X2F0b21pY19j
b25uZWN0b3JfcHJvcGVydGllcyBwcm9wLAo+ICsJCQkJwqDCoMKgwqDCoGNvbnN0IGNoYXIgKnZh
bCk7Cj4gKwo+IMKgZXh0ZXJuIHZvaWQgaWd0X291dHB1dF9yZXBsYWNlX3Byb3BfYmxvYihpZ3Rf
b3V0cHV0X3QgKm91dHB1dCwKPiDCoAkJCQkJwqBlbnVtCj4gaWd0X2F0b21pY19jb25uZWN0b3Jf
cHJvcGVydGllcyBwcm9wLAo+IMKgCQkJCQnCoGNvbnN0IHZvaWQgKnB0ciwgc2l6ZV90Cj4gbGVu
Z3RoKTsKPiAtCj4gwqAvKioKPiDCoCAqIGlndF9waXBlX29ial9oYXNfcHJvcDoKPiDCoCAqIEBw
aXBlOiBQaXBlIHRvIGNoZWNrLgo+IEBAIC02OTMsNiArNzA4LDIwIEBAIGlndF9waXBlX2hhc19w
cm9wKGlndF9kaXNwbGF5X3QgKmRpc3BsYXksIGVudW0KPiBwaXBlIHBpcGUsCj4gwqAjZGVmaW5l
IGlndF9waXBlX3NldF9wcm9wX3ZhbHVlKGRpc3BsYXksIHBpcGUsIHByb3AsIHZhbHVlKSBcCj4g
wqAJaWd0X3BpcGVfb2JqX3NldF9wcm9wX3ZhbHVlKCYoZGlzcGxheSktPnBpcGVzWyhwaXBlKV0s
IHByb3AsCj4gdmFsdWUpCj4gwqAKPiArZXh0ZXJuIGJvb2wgaWd0X3BpcGVfb2JqX3RyeV9wcm9w
X2VudW0oaWd0X3BpcGVfdCAqcGlwZSwKPiArCQkJCcKgwqDCoMKgwqDCoMKgZW51bQo+IGlndF9h
dG9taWNfY3J0Y19wcm9wZXJ0aWVzIHByb3AsCj4gKwkJCQnCoMKgwqDCoMKgwqDCoGNvbnN0IGNo
YXIgKnZhbCk7Cj4gKwo+ICtleHRlcm4gdm9pZCBpZ3RfcGlwZV9vYmpfc2V0X3Byb3BfZW51bShp
Z3RfcGlwZV90ICpwaXBlLAo+ICsJCQkJwqDCoMKgwqDCoMKgwqBlbnVtCj4gaWd0X2F0b21pY19j
cnRjX3Byb3BlcnRpZXMgcHJvcCwKPiArCQkJCcKgwqDCoMKgwqDCoMKgY29uc3QgY2hhciAqdmFs
KTsKPiArCj4gKyNkZWZpbmUgaWd0X3BpcGVfdHJ5X3Byb3BfZW51bShkaXNwbGF5LCBwaXBlLCBw
cm9wLCB2YWwpIFwKPiArCWlndF9waXBlX29ial90cnlfcHJvcF9lbnVtKCYoZGlzcGxheSktPnBp
cGVzWyhwaXBlKV0sIHByb3AsCj4gdmFsKQo+ICsKPiArI2RlZmluZSBpZ3RfcGlwZV9zZXRfcHJv
cF9lbnVtKGRpc3BsYXksIHBpcGUsIHByb3AsIHZhbCkgXAo+ICsJaWd0X3BpcGVfb2JqX3NldF9w
cm9wX2VudW0oJihkaXNwbGF5KS0+cGlwZXNbKHBpcGUpXSwgcHJvcCwKPiB2YWwpCj4gKwo+IMKg
ZXh0ZXJuIHZvaWQgaWd0X3BpcGVfb2JqX3JlcGxhY2VfcHJvcF9ibG9iKGlndF9waXBlX3QgKnBp
cGUsCj4gwqAJCQkJCcKgwqDCoGVudW0KPiBpZ3RfYXRvbWljX2NydGNfcHJvcGVydGllcyBwcm9w
LAo+IMKgCQkJCQnCoMKgwqBjb25zdCB2b2lkICpwdHIsIHNpemVfdAo+IGxlbmd0aCk7Ci0tIApN
aWthIEthaG9sYSAtIEludGVsIE9UQwoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f
X19fX19fX19fX19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJl
ZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGlu
Zm8vZHJpLWRldmVsCg==