From mboxrd@z Thu Jan  1 00:00:00 1970
From: Mika Kahola <mika.kahola@intel.com>
Subject: Re: [igt-dev] [PATCH v2 2/3] lib/kms: Remove special enum handling
 and replace with call to igt_plane_set_prop_enum, v2.
Date: Tue, 28 Aug 2018 13:42:16 +0300
Message-ID: <1535452936.20284.3.camel@intel.com>
References: <20180815100851.22219-1-maarten.lankhorst@linux.intel.com>
 <20180815100851.22219-2-maarten.lankhorst@linux.intel.com>
Reply-To: mika.kahola@intel.com
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Return-path: <dri-devel-bounces@lists.freedesktop.org>
In-Reply-To: <20180815100851.22219-2-maarten.lankhorst@linux.intel.com>
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/dri-devel>,
 <mailto:dri-devel-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/dri-devel>
List-Post: <mailto:dri-devel@lists.freedesktop.org>
List-Help: <mailto:dri-devel-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/dri-devel>,
 <mailto:dri-devel-request@lists.freedesktop.org?subject=subscribe>
Errors-To: dri-devel-bounces@lists.freedesktop.org
Sender: "dri-devel" <dri-devel-bounces@lists.freedesktop.org>
To: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>, igt-dev@lists.freedesktop.org
Cc: Lowry Li <lowry.li@arm.com>, Liviu Dudau <liviu.dudau@arm.com>, dri-devel@lists.freedesktop.org
List-Id: dri-devel@lists.freedesktop.org

T24gV2VkLCAyMDE4LTA4LTE1IGF0IDEyOjA4ICswMjAwLCBNYWFydGVuIExhbmtob3JzdCB3cm90
ZToKPiBXZSBub3cgaGF2ZSBpbmZyYXN0cnVjdHVyZSBmb3IgZ2VuZXJpYyBlbnVtIGhhbmRsaW5n
LiBUaGlzIHdpbGwgbWFrZQo+IGl0IGVhc2llcgo+IHRvIHdyaXRlIG5ldyB0ZXN0cyB3aXRob3V0
IGRlZmluaW5nIGFsbCBlbnVtIGNvbnN0YW50cyBiZWZvcmVoYW5kLgo+IAo+IENoYW5nZXMgc2lu
Y2UgdjE6Cj4gLSBGaXggY29tcGlsZSBlcnJvciwgc2VudCBvbGQgdmVyc2lvbiBieSBhY2NpZGVu
dC4KPiAKUmV2aWV3ZWQtYnk6IE1pa2EgS2Fob2xhIDxtaWthLmthaG9sYUBpbnRlbC5jb20+Cgo+
IFNpZ25lZC1vZmYtYnk6IE1hYXJ0ZW4gTGFua2hvcnN0IDxtYWFydGVuLmxhbmtob3JzdEBsaW51
eC5pbnRlbC5jb20+Cj4gLS0tCj4gwqBsaWIvaWd0X2NvbG9yX2VuY29kaW5nLmMgfCAyMCArKysr
KysrKysrKwo+IMKgbGliL2lndF9jb2xvcl9lbmNvZGluZy5oIHzCoMKgMyArKwo+IMKgbGliL2ln
dF9rbXMuY8KgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoHwgNzcgKysrKystLS0tLS0tLS0tLS0tLS0t
LS0tLS0tLS0tLS0tLS0tLS0KPiAtLQo+IMKgMyBmaWxlcyBjaGFuZ2VkLCAzMiBpbnNlcnRpb25z
KCspLCA2OCBkZWxldGlvbnMoLSkKPiAKPiBkaWZmIC0tZ2l0IGEvbGliL2lndF9jb2xvcl9lbmNv
ZGluZy5jIGIvbGliL2lndF9jb2xvcl9lbmNvZGluZy5jCj4gaW5kZXggZjQ0NWRiYmMwMjUwLi4w
M2UxNmUwYzk2NTggMTAwNjQ0Cj4gLS0tIGEvbGliL2lndF9jb2xvcl9lbmNvZGluZy5jCj4gKysr
IGIvbGliL2lndF9jb2xvcl9lbmNvZGluZy5jCj4gQEAgLTIzLDYgKzIzLDcgQEAKPiDCoAo+IMKg
I2luY2x1ZGUgImlndF9jb2xvcl9lbmNvZGluZy5oIgo+IMKgI2luY2x1ZGUgImlndF9tYXRyaXgu
aCIKPiArI2luY2x1ZGUgImlndF9jb3JlLmgiCj4gwqAKPiDCoHN0cnVjdCBjb2xvcl9lbmNvZGlu
ZyB7Cj4gwqAJZmxvYXQga3IsIGtiOwo+IEBAIC0xNDEsMyArMTQyLDIyIEBAIHN0cnVjdCBpZ3Rf
bWF0NCBpZ3RfcmdiX3RvX3ljYmNyX21hdHJpeChlbnVtCj4gaWd0X2NvbG9yX2VuY29kaW5nIGNv
bG9yX2VuY29kaW5nLAo+IMKgCj4gwqAJcmV0dXJuIGlndF9tYXRyaXhfbXVsdGlwbHkoJnIsICZj
KTsKPiDCoH0KPiArCj4gK2NvbnN0IGNoYXIgKmlndF9jb2xvcl9lbmNvZGluZ190b19zdHIoZW51
bSBpZ3RfY29sb3JfZW5jb2RpbmcKPiBlbmNvZGluZykKPiArewo+ICsJc3dpdGNoIChlbmNvZGlu
Zykgewo+ICsJY2FzZSBJR1RfQ09MT1JfWUNCQ1JfQlQ2MDE6IHJldHVybiAiSVRVLVIgQlQuNjAx
IFlDYkNyIjsKPiArCWNhc2UgSUdUX0NPTE9SX1lDQkNSX0JUNzA5OiByZXR1cm4gIklUVS1SIEJU
LjcwOSBZQ2JDciI7Cj4gKwljYXNlIElHVF9DT0xPUl9ZQ0JDUl9CVDIwMjA6IHJldHVybiAiSVRV
LVIgQlQuMjAyMCBZQ2JDciI7Cj4gKwlkZWZhdWx0OiBpZ3RfYXNzZXJ0KDApOyByZXR1cm4gTlVM
TDsKPiArCX0KPiArfQo+ICsKPiArY29uc3QgY2hhciAqaWd0X2NvbG9yX3JhbmdlX3RvX3N0cihl
bnVtIGlndF9jb2xvcl9yYW5nZSByYW5nZSkKPiArewo+ICsJc3dpdGNoIChyYW5nZSkgewo+ICsJ
Y2FzZSBJR1RfQ09MT1JfWUNCQ1JfTElNSVRFRF9SQU5HRTogcmV0dXJuICJZQ2JDciBsaW1pdGVk
Cj4gcmFuZ2UiOwo+ICsJY2FzZSBJR1RfQ09MT1JfWUNCQ1JfRlVMTF9SQU5HRTogcmV0dXJuICJZ
Q2JDciBmdWxsIHJhbmdlIjsKPiArCWRlZmF1bHQ6IGlndF9hc3NlcnQoMCk7IHJldHVybiBOVUxM
Owo+ICsJfQo+ICt9Cj4gZGlmZiAtLWdpdCBhL2xpYi9pZ3RfY29sb3JfZW5jb2RpbmcuaCBiL2xp
Yi9pZ3RfY29sb3JfZW5jb2RpbmcuaAo+IGluZGV4IDBkOGM4MTkzMjJhZi4uMzg4NGU0OTM5ZjRj
IDEwMDY0NAo+IC0tLSBhL2xpYi9pZ3RfY29sb3JfZW5jb2RpbmcuaAo+ICsrKyBiL2xpYi9pZ3Rf
Y29sb3JfZW5jb2RpbmcuaAo+IEBAIC00MSw2ICs0MSw5IEBAIGVudW0gaWd0X2NvbG9yX3Jhbmdl
IHsKPiDCoAlJR1RfTlVNX0NPTE9SX1JBTkdFUywKPiDCoH07Cj4gwqAKPiArY29uc3QgY2hhciAq
aWd0X2NvbG9yX2VuY29kaW5nX3RvX3N0cihlbnVtIGlndF9jb2xvcl9lbmNvZGluZwo+IGVuY29k
aW5nKTsKPiArY29uc3QgY2hhciAqaWd0X2NvbG9yX3JhbmdlX3RvX3N0cihlbnVtIGlndF9jb2xv
cl9yYW5nZSByYW5nZSk7Cj4gKwo+IMKgc3RydWN0IGlndF9tYXQ0IGlndF95Y2Jjcl90b19yZ2Jf
bWF0cml4KGVudW0gaWd0X2NvbG9yX2VuY29kaW5nCj4gY29sb3JfZW5jb2RpbmcsCj4gwqAJCQkJ
CWVudW0gaWd0X2NvbG9yX3JhbmdlCj4gY29sb3JfcmFuZ2UpOwo+IMKgc3RydWN0IGlndF9tYXQ0
IGlndF9yZ2JfdG9feWNiY3JfbWF0cml4KGVudW0gaWd0X2NvbG9yX2VuY29kaW5nCj4gY29sb3Jf
ZW5jb2RpbmcsCj4gZGlmZiAtLWdpdCBhL2xpYi9pZ3Rfa21zLmMgYi9saWIvaWd0X2ttcy5jCj4g
aW5kZXggZTUyNzIxMDNlMjQzLi42MmQ4NDY4NDE1YzYgMTAwNjQ0Cj4gLS0tIGEvbGliL2lndF9r
bXMuYwo+ICsrKyBiL2xpYi9pZ3Rfa21zLmMKPiBAQCAtMTk2LDYxICsxOTYsNiBAQCBjb25zdCBj
aGFyICogY29uc3QKPiBpZ3RfY29ubmVjdG9yX3Byb3BfbmFtZXNbSUdUX05VTV9DT05ORUNUT1Jf
UFJPUFNdID0gewo+IMKgCVtJR1RfQ09OTkVDVE9SX0JST0FEQ0FTVF9SR0JdID0gIkJyb2FkY2Fz
dCBSR0IiLAo+IMKgfTsKPiDCoAo+IC1zdGF0aWMgY29uc3QgY2hhciAqIGNvbnN0Cj4gaWd0X2Nv
bG9yX2VuY29kaW5nX25hbWVzW0lHVF9OVU1fQ09MT1JfRU5DT0RJTkdTXSA9IHsKPiAtCVtJR1Rf
Q09MT1JfWUNCQ1JfQlQ2MDFdID0gIklUVS1SIEJULjYwMSBZQ2JDciIsCj4gLQlbSUdUX0NPTE9S
X1lDQkNSX0JUNzA5XSA9ICJJVFUtUiBCVC43MDkgWUNiQ3IiLAo+IC0JW0lHVF9DT0xPUl9ZQ0JD
Ul9CVDIwMjBdID0gIklUVS1SIEJULjIwMjAgWUNiQ3IiLAo+IC19Owo+IC0KPiAtc3RhdGljIGNv
bnN0IGNoYXIgKiBjb25zdAo+IGlndF9jb2xvcl9yYW5nZV9uYW1lc1tJR1RfTlVNX0NPTE9SX1JB
TkdFU10gPSB7Cj4gLQlbSUdUX0NPTE9SX1lDQkNSX0ZVTExfUkFOR0VdID0gIllDYkNyIGZ1bGwg
cmFuZ2UiLAo+IC0JW0lHVF9DT0xPUl9ZQ0JDUl9MSU1JVEVEX1JBTkdFXSA9ICJZQ2JDciBsaW1p
dGVkIHJhbmdlIiwKPiAtfTsKPiAtCj4gLXN0YXRpYyB2b2lkIHBhcnNlX2VudW1fcHJvcChkcm1N
b2RlUHJvcGVydHlQdHIgcHJvcCwKPiAtCQkJwqDCoMKgwqBpbnQgbnVtX2VudW1zLAo+IC0JCQnC
oMKgwqDCoHVpbnQ2NF90IHZhbHVlc1tdLAo+IC0JCQnCoMKgwqDCoGNvbnN0IGNoYXIgKiBjb25z
dCBlbnVtX25hbWVzW10pCj4gLXsKPiAtCWlndF9hc3NlcnQoKHByb3AtPmZsYWdzICYgfihEUk1f
TU9ERV9QUk9QX0lNTVVUQUJMRSB8Cj4gLQkJCQnCoMKgwqDCoERSTV9NT0RFX1BST1BfQVRPTUlD
KSkgPT0KPiBEUk1fTU9ERV9QUk9QX0VOVU0pOwo+IC0JaWd0X2Fzc2VydChwcm9wLT5jb3VudF9l
bnVtcyA9PSBwcm9wLT5jb3VudF92YWx1ZXMpOwo+IC0JaWd0X2Fzc2VydChwcm9wLT5jb3VudF9l
bnVtcyA+PSAxKTsKPiAtCWlndF9hc3NlcnQoISEocHJvcC0+ZmxhZ3MgJiBEUk1fTU9ERV9QUk9Q
X0lNTVVUQUJMRSkgPT0KPiAocHJvcC0+Y291bnRfZW51bXMgPT0gMSkpOwo+IC0KPiAtCWZvciAo
aW50IGkgPSAwOyBpIDwgcHJvcC0+Y291bnRfZW51bXM7IGkrKykgewo+IC0JCWZvciAoaW50IGog
PSAwOyBqIDwgbnVtX2VudW1zOyBqKyspIHsKPiAtCQkJaWYgKHN0cmNtcChwcm9wLT5lbnVtc1tp
XS5uYW1lLAo+IGVudW1fbmFtZXNbal0pKQo+IC0JCQkJY29udGludWU7Cj4gLQo+IC0JCQl2YWx1
ZXNbal0gPSBwcm9wLT5lbnVtc1tpXS52YWx1ZTsKPiAtCQl9Cj4gLQl9Cj4gLX0KPiAtCj4gLXN0
YXRpYyB2b2lkCj4gLXBhcnNlX2NvbG9yX2VuY29kaW5nX3Byb3AoaWd0X3BsYW5lX3QgKnBsYW5l
LCBkcm1Nb2RlUHJvcGVydHlQdHIKPiBwcm9wKQo+IC17Cj4gLQlwYXJzZV9lbnVtX3Byb3AocHJv
cCwgQVJSQVlfU0laRShpZ3RfY29sb3JfZW5jb2RpbmdfbmFtZXMpLAo+IC0JCQlwbGFuZS0+Y29s
b3JfZW5jb2RpbmcudmFsdWVzLAo+IC0JCQlpZ3RfY29sb3JfZW5jb2RpbmdfbmFtZXMpOwo+IC19
Cj4gLQo+IC1zdGF0aWMgdm9pZAo+IC1wYXJzZV9jb2xvcl9yYW5nZV9wcm9wKGlndF9wbGFuZV90
ICpwbGFuZSwgZHJtTW9kZVByb3BlcnR5UHRyIHByb3ApCj4gLXsKPiAtCXBhcnNlX2VudW1fcHJv
cChwcm9wLCBBUlJBWV9TSVpFKGlndF9jb2xvcl9yYW5nZV9uYW1lcyksCj4gLQkJCXBsYW5lLT5j
b2xvcl9yYW5nZS52YWx1ZXMsCj4gLQkJCWlndF9jb2xvcl9yYW5nZV9uYW1lcyk7Cj4gLX0KPiAt
Cj4gLXR5cGVkZWYgdm9pZCAoKnBhcnNlX3BsYW5lX3Byb3BfdCkoaWd0X3BsYW5lX3QgKnBsYW5l
LAo+IGRybU1vZGVQcm9wZXJ0eVB0ciBwcm9wKTsKPiAtCj4gLXN0YXRpYyBjb25zdCBwYXJzZV9w
bGFuZV9wcm9wX3QKPiBpZ3RfcGFyc2VfcGxhbmVfcHJvcFtJR1RfTlVNX1BMQU5FX1BST1BTXSA9
IHsKPiAtCVtJR1RfUExBTkVfQ09MT1JfRU5DT0RJTkddID0gcGFyc2VfY29sb3JfZW5jb2Rpbmdf
cHJvcCwKPiAtCVtJR1RfUExBTkVfQ09MT1JfUkFOR0VdID0gcGFyc2VfY29sb3JfcmFuZ2VfcHJv
cCwKPiAtfTsKPiAtCj4gwqAvKgo+IMKgICogUmV0cmlldmUgYWxsIHRoZSBwcm9wZXJpZXMgc3Bl
Y2lmaWVkIGluIHByb3BzX25hbWUgYW5kIHN0b3JlIHRoZW0KPiBpbnRvCj4gwqAgKiBwbGFuZS0+
cHJvcHMuCj4gQEAgLTI3NSw5ICsyMjAsNiBAQCBpZ3RfZmlsbF9wbGFuZV9wcm9wcyhpZ3RfZGlz
cGxheV90ICpkaXNwbGF5LAo+IGlndF9wbGFuZV90ICpwbGFuZSwKPiDCoAkJCWlmIChzdHJjbXAo
cHJvcC0+bmFtZSwgcHJvcF9uYW1lc1tqXSkgIT0gMCkKPiDCoAkJCQljb250aW51ZTsKPiDCoAo+
IC0JCQlpZiAoaWd0X3BhcnNlX3BsYW5lX3Byb3Bbal0pCj4gLQkJCQlpZ3RfcGFyc2VfcGxhbmVf
cHJvcFtqXShwbGFuZSwKPiBwcm9wKTsKPiAtCj4gwqAJCQlwbGFuZS0+cHJvcHNbal0gPSBwcm9w
cy0+cHJvcHNbaV07Cj4gwqAJCQlicmVhazsKPiDCoAkJfQo+IEBAIC0xNzk5LDExICsxNzQxLDEy
IEBAIHN0YXRpYyB2b2lkIGlndF9wbGFuZV9yZXNldChpZ3RfcGxhbmVfdAo+ICpwbGFuZSkKPiDC
oAlpZ3RfcGxhbmVfc2V0X3Byb3BfdmFsdWUocGxhbmUsIElHVF9QTEFORV9DUlRDX0lELCAwKTsK
PiDCoAo+IMKgCWlmIChpZ3RfcGxhbmVfaGFzX3Byb3AocGxhbmUsIElHVF9QTEFORV9DT0xPUl9F
TkNPRElORykpCj4gLQkJaWd0X3BsYW5lX3NldF9wcm9wX3ZhbHVlKHBsYW5lLAo+IElHVF9QTEFO
RV9DT0xPUl9FTkNPRElORywKPiAtCQkJCQnCoHBsYW5lLQo+ID5jb2xvcl9lbmNvZGluZy52YWx1
ZXNbSUdUX0NPTE9SX1lDQkNSX0JUNjAxXSk7Cj4gKwkJaWd0X3BsYW5lX3NldF9wcm9wX2VudW0o
cGxhbmUsCj4gSUdUX1BMQU5FX0NPTE9SX0VOQ09ESU5HLAo+ICsJCQlpZ3RfY29sb3JfZW5jb2Rp
bmdfdG9fc3RyKElHVF9DT0xPUl9ZQ0JDUl9CVAo+IDYwMSkpOwo+ICsKPiDCoAlpZiAoaWd0X3Bs
YW5lX2hhc19wcm9wKHBsYW5lLCBJR1RfUExBTkVfQ09MT1JfUkFOR0UpKQo+IC0JCWlndF9wbGFu
ZV9zZXRfcHJvcF92YWx1ZShwbGFuZSwKPiBJR1RfUExBTkVfQ09MT1JfUkFOR0UsCj4gLQkJCQkJ
wqBwbGFuZS0KPiA+Y29sb3JfcmFuZ2UudmFsdWVzW0lHVF9DT0xPUl9ZQ0JDUl9MSU1JVEVEX1JB
TkdFXSk7Cj4gKwkJaWd0X3BsYW5lX3NldF9wcm9wX2VudW0ocGxhbmUsCj4gSUdUX1BMQU5FX0NP
TE9SX1JBTkdFLAo+ICsJCQlpZ3RfY29sb3JfcmFuZ2VfdG9fc3RyKElHVF9DT0xPUl9ZQ0JDUl9M
SU1JVAo+IEVEX1JBTkdFKSk7Cj4gwqAKPiDCoAkvKiBVc2UgZGVmYXVsdCByb3RhdGlvbiAqLwo+
IMKgCWlmIChpZ3RfcGxhbmVfaGFzX3Byb3AocGxhbmUsIElHVF9QTEFORV9ST1RBVElPTikpCj4g
QEAgLTM3MjIsMTMgKzM2NjUsMTEgQEAgdm9pZCBpZ3RfcGxhbmVfc2V0X2ZiKGlndF9wbGFuZV90
ICpwbGFuZSwKPiBzdHJ1Y3QgaWd0X2ZiICpmYikKPiDCoAkJaWd0X2ZiX3NldF9zaXplKGZiLCBw
bGFuZSwgZmItPndpZHRoLCBmYi0+aGVpZ2h0KTsKPiDCoAo+IMKgCQlpZiAoaWd0X3BsYW5lX2hh
c19wcm9wKHBsYW5lLAo+IElHVF9QTEFORV9DT0xPUl9FTkNPRElORykpCj4gLQkJCWlndF9wbGFu
ZV9zZXRfcHJvcF92YWx1ZShwbGFuZSwKPiAtCQkJCQkJwqBJR1RfUExBTkVfQ09MT1JfRU5DCj4g
T0RJTkcsCj4gLQkJCQkJCcKgcGxhbmUtCj4gPmNvbG9yX2VuY29kaW5nLnZhbHVlc1tmYi0+Y29s
b3JfZW5jb2RpbmddKTsKPiArCQkJaWd0X3BsYW5lX3NldF9wcm9wX2VudW0ocGxhbmUsCj4gSUdU
X1BMQU5FX0NPTE9SX0VOQ09ESU5HLAo+ICsJCQkJaWd0X2NvbG9yX2VuY29kaW5nX3RvX3N0cihm
Yi0KPiA+Y29sb3JfZW5jb2RpbmcpKTsKPiDCoAkJaWYgKGlndF9wbGFuZV9oYXNfcHJvcChwbGFu
ZSwKPiBJR1RfUExBTkVfQ09MT1JfUkFOR0UpKQo+IC0JCQlpZ3RfcGxhbmVfc2V0X3Byb3BfdmFs
dWUocGxhbmUsCj4gLQkJCQkJCcKgSUdUX1BMQU5FX0NPTE9SX1JBTgo+IEdFLAo+IC0JCQkJCQnC
oHBsYW5lLQo+ID5jb2xvcl9yYW5nZS52YWx1ZXNbZmItPmNvbG9yX3JhbmdlXSk7Cj4gKwkJCWln
dF9wbGFuZV9zZXRfcHJvcF9lbnVtKHBsYW5lLAo+IElHVF9QTEFORV9DT0xPUl9SQU5HRSwKPiAr
CQkJCWlndF9jb2xvcl9yYW5nZV90b19zdHIoZmItCj4gPmNvbG9yX3JhbmdlKSk7Cj4gwqAJfSBl
bHNlIHsKPiDCoAkJaWd0X3BsYW5lX3NldF9zaXplKHBsYW5lLCAwLCAwKTsKPiDCoAotLSAKTWlr
YSBLYWhvbGEgLSBJbnRlbCBPVEMKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f
X19fX19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVk
ZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZv
L2RyaS1kZXZlbAo=