From mboxrd@z Thu Jan 1 00:00:00 1970 From: Neil Armstrong Subject: [PATCH v2] drm/fb_helper: Allow leaking fbdev smem_start Date: Fri, 28 Sep 2018 14:05:55 +0200 Message-ID: <1538136355-15383-1-git-send-email-narmstrong@baylibre.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wr1-x444.google.com (mail-wr1-x444.google.com [IPv6:2a00:1450:4864:20::444]) by gabe.freedesktop.org (Postfix) with ESMTPS id D55856E0A6 for ; Fri, 28 Sep 2018 12:06:07 +0000 (UTC) Received: by mail-wr1-x444.google.com with SMTP id f10-v6so6149647wrs.0 for ; Fri, 28 Sep 2018 05:06:07 -0700 (PDT) List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: dri-devel@lists.freedesktop.org Cc: Bartlomiej Zolnierkiewicz , Maxime Ripard , Daniel Vetter , Neil Armstrong , =?UTF-8?q?Christian=20K=C3=B6nig?= List-Id: dri-devel@lists.freedesktop.org U2luY2UgImRybS9mYjogU3RvcCBsZWFraW5nIHBoeXNpY2FsIGFkZHJlc3MiLCB0aGUgZGVmYXVs dCBiZWhhdmlvdXIgb2YKdGhlIERSTSBmYmRldiBlbXVsYXRpb24gaXMgdG8gc2V0IHRoZSBzbWVt X2Jhc2UgdG8gMCBhbmQgcGFzcyB0aGUgbmV3CkZCSU5GT19ISURFX1NNRU1fU1RBUlQgZmxhZy4K ClRoZSBtYWluIHJlYXNvbiBpcyB0byBhdm9pZCBsZWFraW5nIHBoeXNpY2FsIGFkZHJlc3NlIHRv IHVzZXItc3BhY2UsIGFuZAppdCBmb2xsb3dzIGEgZ2VuZXJhbCBtb3ZlIG92ZXIgdGhlIGtlcm5l bCBjb2RlIHRvIGF2b2lkIHVzZXItc3BhY2UgdG8KbWFuaXB1bGF0ZSBwaHlzaWNhbCBhZGRyZXNz ZXMgYW5kIHRoZW4gdXNlIHNvbWUgb3RoZXIgbWVjaGFuaXNtcyBsaWtlCmRtYS1idWYgdG8gdHJh bnNmZXIgcGh5c2ljYWwgYnVmZmVyIGhhbmRsZXMgb3ZlciBtdWx0aXBsZSBzdWJzeXN0ZW1zLgoK QnV0LCBhIGxvdCBvZiBkZXZpY2VzIGRlcGVuZHMgb24gY2xvc2VkIHNvdXJjZXMgYmluYXJpZXMg dG8gZW5hYmxlCk9wZW5HTCBoYXJkd2FyZSBhY2NlbGVyYXRpb24gdGhhdCB1c2VzIHRoaXMgc21l bV9zdGFydCB2YWx1ZSB0bwpwYXNzIHBoeXNpY2FsIGFkZHJlc3NlcyB0byBvdXQtb2YtdHJlZSBt b2R1bGVzIGluIG9yZGVyIHRvIHJlbmRlcgppbnRvIHRoZXNlIHBoeXNpY2FsIGFkcmVzc2VzLiBU aGVzZSBzaG91bGQgdXNlIGRtYS1idWYgYnVmZmVycyBhbGxvY2F0ZWQKZnJvbSB0aGUgRFJNIGRp c3BsYXkgZGV2aWNlIGluc3RlYWQgYW5kIHN0b3AgcmVseWluZyBvbiBmYmRldiBvdmVyYWxsb2Nh dGlvbgp0byBnYXRoZXIgRE1BIG1lbW9yeSAoc29tZSBIVyB2ZW5kb3JzIGRlbGl2ZXJzIEdCTSBh bmQgV2F5bGFuZCBjYXBhYmxlCmJpbmFyaWVzLCBidXQgb2xkZXIgdW5zdXBwb3J0ZWQgZGV2aWNl cyB3b24ndCBoYXZlIHRoZXNlIG5ldyBiaW5hcmllcwphbmQgYXJlIGRvb21lZCB1bnRpbCBhbiBP cGVuIFNvdXJjZSBzb2x1dGlvbiBsaWtlIExpbWEgZmluYWxpemVzKS4KClNpbmNlIHRoZXNlIGRl dmljZXMgaGVhdmlseSBkZXBlbmRzIG9uIHRoaXMga2luZCBvZiBzb2Z0d2FyZSBhbmQgYmVjYXVz ZQp0aGUgc21lbV9zdGFydCBwb3B1bGF0aW9uIHdhcyBhdmFpbGFibGUgZm9yIHllYXJzLCBpdCdz IGEgYnJlYWthZ2UgdG8Kc3RvcCBsZWFraW5nIHNtZW1fc3RhcnQgd2l0aG91dCBhbnkgYWx0ZXJu YXRpdmUgc29sdXRpb25zLgoKVGhpcyBwYXRjaCBhZGRzIGEgS2NvbmZpZyBkZXBlbmRpbmcgb24g dGhlIEVYUEVSVCBjb25maWcgYW5kIGFuIHVuc2FmZQprZXJuZWwgbW9kdWxlIHBhcmFtZXRlciB0 YWludGluZyB0aGUga2VybmVsIHdoZW4gZW5hYmxlZC4KCkEgY2xlYXIgY29tbWVudCBhbmQgS2Nv bmZpZyBoZWxwIHRleHQgd2FzIGFkZGVkIHRvIGNsYXJpZnkgd2h5IGFuZCB3aGVuCnRoaXMgcGF0 Y2ggc2hvdWxkIGJlIHJldmVydGVkLCBidXQgaW4gdGhlIG1lYW50aW1lIGl0J3MgYSBuZWNlc3Nh cnkKZmVhdHVyZSB0byBrZWVwLgoKQ2M6IERhdmUgQWlybGllIDxhaXJsaWVkQGdtYWlsLmNvbT4K Q2M6IERhbmllbCBWZXR0ZXIgPGRhbmllbC52ZXR0ZXJAZmZ3bGwuY2g+CkNjOiBCYXJ0bG9taWVq IFpvbG5pZXJraWV3aWN6IDxiLnpvbG5pZXJraWVAc2Ftc3VuZy5jb20+CkNjOiBOb3JhbGYgVHLD uG5uZXMgPG5vcmFsZkB0cm9ubmVzLm9yZz4KQ2M6IE1heGltZSBSaXBhcmQgPG1heGltZS5yaXBh cmRAYm9vdGxpbi5jb20+CkNjOiBFcmljIEFuaG9sdCA8ZXJpY0BhbmhvbHQubmV0PgpDYzogTHVj YXMgU3RhY2ggPGwuc3RhY2hAcGVuZ3V0cm9uaXguZGU+CkNjOiBSb2IgQ2xhcmsgPHJvYmRjbGFy a0BnbWFpbC5jb20+CkNjOiBCZW4gU2tlZ2dzIDxza2VnZ3NiQGdtYWlsLmNvbT4KQ2M6IENocmlz dGlhbiBLw7ZuaWcgPGNocmlzdGlhbi5rb2VuaWdAYW1kLmNvbT4KU2lnbmVkLW9mZi1ieTogTmVp bCBBcm1zdHJvbmcgPG5hcm1zdHJvbmdAYmF5bGlicmUuY29tPgpSZXZpZXdlZC1ieTogTWF4aW1l IFJpcGFyZCA8bWF4aW1lLnJpcGFyZEBib290bGluLmNvbT4KVGVzdGVkLWJ5OiBNYXhpbWUgUmlw YXJkIDxtYXhpbWUucmlwYXJkQGJvb3RsaW4uY29tPgpBY2tlZC1ieTogRGFuaWVsIFZldHRlciA8 ZGFuaWVsLnZldHRlckBmZndsbC5jaD4KLS0tCiBkcml2ZXJzL2dwdS9kcm0vS2NvbmZpZyAgICAg ICAgIHwgMjAgKysrKysrKysrKysrKysrKysrKysKIGRyaXZlcnMvZ3B1L2RybS9kcm1fZmJfaGVs cGVyLmMgfCAzMyArKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrLS0KIDIgZmlsZXMgY2hh bmdlZCwgNTEgaW5zZXJ0aW9ucygrKSwgMiBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9kcml2 ZXJzL2dwdS9kcm0vS2NvbmZpZyBiL2RyaXZlcnMvZ3B1L2RybS9LY29uZmlnCmluZGV4IDg4NzFi M2YuLjBiNDA2N2YgMTAwNjQ0Ci0tLSBhL2RyaXZlcnMvZ3B1L2RybS9LY29uZmlnCisrKyBiL2Ry aXZlcnMvZ3B1L2RybS9LY29uZmlnCkBAIC0xMTAsNiArMTEwLDI2IEBAIGNvbmZpZyBEUk1fRkJE RVZfT1ZFUkFMTE9DCiAJICBpcyAxMDAuIFR5cGljYWwgdmFsdWVzIGZvciBkb3VibGUgYnVmZmVy aW5nIHdpbGwgYmUgMjAwLAogCSAgdHJpcGxlIGJ1ZmZlcmluZyAzMDAuCiAKK2NvbmZpZyBEUk1f RkJERVZfTEVBS19QSFlTX1NNRU0KKwlib29sICJTaGFtZWxlc3NseSBhbGxvdyBsZWFraW5nIG9m IGZiZGV2IHBoeXNpY2FsIGFkZHJlc3MgKERBTkdFUk9VUykiCisJZGVwZW5kcyBvbiBEUk1fRkJE RVZfRU1VTEFUSU9OICYmIEVYUEVSVAorCWRlZmF1bHQgbgorCWhlbHAKKwkgIEluIG9yZGVyIHRv IGtlZXAgdXNlci1zcGFjZSBjb21wYXRpYmlsaXR5LCB3ZSB3YW50IGluIGNlcnRhaW4KKwkgIHVz ZS1jYXNlcyB0byBrZWVwIGxlYWtpbmcgdGhlIGZiZGV2IHBoeXNpY2FsIGFkZHJlc3MgdG8gdGhl CisJICB1c2VyLXNwYWNlIHByb2dyYW0gaGFuZGxpbmcgdGhlIGZiZGV2IGJ1ZmZlci4KKwkgIFRo aXMgYWZmZWN0cywgbm90IG9ubHksIEFtbG9naWMsIEFsbHdpbm5lciBvciBSb2NrY2hpcCBkZXZp Y2VzCisJICB3aXRoIEFSTSBNYWxpIEdQVXMgdXNpbmcgYW4gdXNlcnNwYWNlIEJsb2IuCisJICBU aGlzIG9wdGlvbiBpcyBub3Qgc3VwcG9ydGVkIGJ5IHVwc3RyZWFtIGRldmVsb3BlcnMgYW5kIHNo b3VsZCBiZQorCSAgcmVtb3ZlZCBhcyBzb29uIGFzIHBvc3NpYmxlIGFuZCBiZSBjb25zaWRlcmVk IGFzIGEgYnJva2VuIGFuZAorCSAgbGVnYWN5IGJlaGF2aW91ciBmcm9tIGEgbW9kZXJuIGZiZGV2 IGRldmljZSBkcml2ZXIuCisKKwkgIFBsZWFzZSBzZW5kIGFueSBidWcgcmVwb3J0cyB3aGVuIHVz aW5nIHRoaXMgdG8geW91ciBwcm9wcmlldGFyeQorCSAgc29mdHdhcmUgdmVuZG9yIHRoYXQgcmVx dWlyZXMgdGhpcy4KKworCSAgSWYgaW4gZG91YnQsIHNheSAiTiIgb3Igc3ByZWFkIHRoZSB3b3Jk IHRvIHlvdXIgY2xvc2VkIHNvdXJjZQorCSAgbGlicmFyeSB2ZW5kb3IuCisKIGNvbmZpZyBEUk1f TE9BRF9FRElEX0ZJUk1XQVJFCiAJYm9vbCAiQWxsb3cgdG8gc3BlY2lmeSBhbiBFRElEIGRhdGEg c2V0IGluc3RlYWQgb2YgcHJvYmluZyBmb3IgaXQiCiAJZGVwZW5kcyBvbiBEUk0KZGlmZiAtLWdp dCBhL2RyaXZlcnMvZ3B1L2RybS9kcm1fZmJfaGVscGVyLmMgYi9kcml2ZXJzL2dwdS9kcm0vZHJt X2ZiX2hlbHBlci5jCmluZGV4IGJmMjE5MGMuLjYxYTBkMmIgMTAwNjQ0Ci0tLSBhL2RyaXZlcnMv Z3B1L2RybS9kcm1fZmJfaGVscGVyLmMKKysrIGIvZHJpdmVycy9ncHUvZHJtL2RybV9mYl9oZWxw ZXIuYwpAQCAtNTYsNiArNTYsMjUgQEAgTU9EVUxFX1BBUk1fREVTQyhkcm1fZmJkZXZfb3ZlcmFs bG9jLAogCQkgIk92ZXJhbGxvY2F0aW9uIG9mIHRoZSBmYmRldiBidWZmZXIgKCUpIFtkZWZhdWx0 PSIKIAkJIF9fTU9EVUxFX1NUUklORyhDT05GSUdfRFJNX0ZCREVWX09WRVJBTExPQykgIl0iKTsK IAorLyoKKyAqIEluIG9yZGVyIHRvIGtlZXAgdXNlci1zcGFjZSBjb21wYXRpYmlsaXR5LCB3ZSB3 YW50IGluIGNlcnRhaW4gdXNlLWNhc2VzCisgKiB0byBrZWVwIGxlYWtpbmcgdGhlIGZiZGV2IHBo eXNpY2FsIGFkZHJlc3MgdG8gdGhlIHVzZXItc3BhY2UgcHJvZ3JhbQorICogaGFuZGxpbmcgdGhl IGZiZGV2IGJ1ZmZlci4KKyAqIFRoaXMgaXMgYSBiYWQgaGFiaXQgZXNzZW50aWFsbHkga2VwdCBp bnRvIGNsb3NlZCBzb3VyY2Ugb3BlbmdsIGRyaXZlcgorICogdGhhdCBzaG91bGQgcmVhbGx5IGJl IG1vdmVkIGludG8gb3Blbi1zb3VyY2UgdXBzdHJlYW0gcHJvamVjdHMgaW5zdGVhZAorICogb2Yg dXNpbmcgbGVnYWN5IHBoeXNpY2FsIGFkZHJlc3NlcyBpbiB1c2VyIHNwYWNlIHRvIGNvbW11bmlj YXRlIHdpdGgKKyAqIG90aGVyIG91dC1vZi10cmVlIGtlcm5lbCBtb2R1bGVzLgorICoKKyAqIFRo aXMgbW9kdWxlX3BhcmFtICpzaG91bGQqIGJlIHJlbW92ZWQgYXMgc29vbiBhcyBwb3NzaWJsZSBh bmQgYmUKKyAqIGNvbnNpZGVyZWQgYXMgYSBicm9rZW4gYW5kIGxlZ2FjeSBiZWhhdmlvdXIgZnJv bSBhIG1vZGVybiBmYmRldiBkZXZpY2UuCisgKi8KKyNpZiBJU19FTkFCTEVEKENPTkZJR19EUk1f RkJERVZfTEVBS19QSFlTX1NNRU0pCitzdGF0aWMgYm9vbCBkcm1fbGVha19mYmRldl9zbWVtID0g ZmFsc2U7Cittb2R1bGVfcGFyYW1fdW5zYWZlKGRybV9sZWFrX2ZiZGV2X3NtZW0sIGJvb2wsIDA2 MDApOworTU9EVUxFX1BBUk1fREVTQyhmYmRldl9lbXVsYXRpb24sCisJCSAiQWxsb3cgdW5zYWZl IGxlYWtpbmcgZmJkZXYgcGh5c2ljYWwgc21lbSBhZGRyZXNzIFtkZWZhdWx0PWZhbHNlXSIpOwor I2VuZGlmCisKIHN0YXRpYyBMSVNUX0hFQUQoa2VybmVsX2ZiX2hlbHBlcl9saXN0KTsKIHN0YXRp YyBERUZJTkVfTVVURVgoa2VybmVsX2ZiX2hlbHBlcl9sb2NrKTsKIApAQCAtMjY3Myw4ICsyNjky LDEyIEBAIF9fZHJtX2ZiX2hlbHBlcl9pbml0aWFsX2NvbmZpZ19hbmRfdW5sb2NrKHN0cnVjdCBk cm1fZmJfaGVscGVyICpmYl9oZWxwZXIsCiAKIAlpbmZvID0gZmJfaGVscGVyLT5mYmRldjsKIAlp bmZvLT52YXIucGl4Y2xvY2sgPSAwOwotCS8qIGRvbid0IGxlYWsgYW55IHBoeXNpY2FsIGFkZHJl c3NlcyB0byB1c2Vyc3BhY2UgKi8KLQlpbmZvLT5mbGFncyB8PSBGQklORk9fSElERV9TTUVNX1NU QVJUOworCS8qIFNoYW1lbGVzc2x5IGFsbG93IHBoeXNpY2FsIGFkZHJlc3MgbGVha2luZyB0byB1 c2Vyc3BhY2UgKi8KKyNpZiBJU19FTkFCTEVEKENPTkZJR19EUk1fRkJERVZfTEVBS19QSFlTX1NN RU0pCisJaWYgKCFkcm1fbGVha19mYmRldl9zbWVtKQorI2VuZGlmCisJCS8qIGRvbid0IGxlYWsg YW55IHBoeXNpY2FsIGFkZHJlc3NlcyB0byB1c2Vyc3BhY2UgKi8KKwkJaW5mby0+ZmxhZ3MgfD0g RkJJTkZPX0hJREVfU01FTV9TVEFSVDsKIAogCS8qIE5lZWQgdG8gZHJvcCBsb2NrcyB0byBhdm9p ZCByZWN1cnNpdmUgZGVhZGxvY2sgaW4KIAkgKiByZWdpc3Rlcl9mcmFtZWJ1ZmZlci4gVGhpcyBp cyBvayBiZWNhdXNlIHRoZSBvbmx5IHRoaW5nIGxlZnQgdG8gZG8gaXMKQEAgLTMwODQsNiArMzEw NywxMiBAQCBpbnQgZHJtX2ZiX2hlbHBlcl9nZW5lcmljX3Byb2JlKHN0cnVjdCBkcm1fZmJfaGVs cGVyICpmYl9oZWxwZXIsCiAJZmJpLT5zY3JlZW5fc2l6ZSA9IGZiLT5oZWlnaHQgKiBmYi0+cGl0 Y2hlc1swXTsKIAlmYmktPmZpeC5zbWVtX2xlbiA9IGZiaS0+c2NyZWVuX3NpemU7CiAJZmJpLT5z Y3JlZW5fYnVmZmVyID0gYnVmZmVyLT52YWRkcjsKKwkvKiBTaGFtZWxlc3NseSBsZWFrIHRoZSBw aHlzaWNhbCBhZGRyZXNzIHRvIHVzZXItc3BhY2UgKi8KKyNpZiBJU19FTkFCTEVEKENPTkZJR19E Uk1fRkJERVZfTEVBS19QSFlTX1NNRU0pCisJaWYgKGRybV9sZWFrX2ZiZGV2X3NtZW0gJiYgZmJp LT5maXguc21lbV9zdGFydCA9PSAwKQorCQlmYmktPmZpeC5zbWVtX3N0YXJ0ID0KKwkJCXBhZ2Vf dG9fcGh5cyh2aXJ0X3RvX3BhZ2UoZmJpLT5zY3JlZW5fYnVmZmVyKSk7CisjZW5kaWYKIAlzdHJj cHkoZmJpLT5maXguaWQsICJEUk0gZW11bGF0ZWQiKTsKIAogCWRybV9mYl9oZWxwZXJfZmlsbF9m aXgoZmJpLCBmYi0+cGl0Y2hlc1swXSwgZmItPmZvcm1hdC0+ZGVwdGgpOwotLSAKMi43LjQKCl9f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBt YWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3Rz LmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo=