From: Philipp Zabel <p.zabel@pengutronix.de>
To: Lucas Stach <l.stach@pengutronix.de>
Cc: kernel@pengutronix.de, dri-devel@lists.freedesktop.org,
patchwork-lst@pengutronix.de
Subject: Re: [PATCH 1/4] gpu: ipu-v3: pre: add double buffer status readback
Date: Fri, 05 Oct 2018 16:16:03 +0200 [thread overview]
Message-ID: <1538748963.3545.32.camel@pengutronix.de> (raw)
In-Reply-To: <20180914165917.8464-1-l.stach@pengutronix.de>
Hi Lucas,
On Fri, 2018-09-14 at 18:59 +0200, Lucas Stach wrote:
> This allows the upper layers to check if a double buffer update has
> been applied by the PRE or is still pending.
>
> Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
> ---
> drivers/gpu/ipu-v3/ipu-pre.c | 6 ++++++
> drivers/gpu/ipu-v3/ipu-prv.h | 1 +
> 2 files changed, 7 insertions(+)
>
> diff --git a/drivers/gpu/ipu-v3/ipu-pre.c b/drivers/gpu/ipu-v3/ipu-pre.c
> index 2f8db9d62551..7389ad157fd6 100644
> --- a/drivers/gpu/ipu-v3/ipu-pre.c
> +++ b/drivers/gpu/ipu-v3/ipu-pre.c
> @@ -259,6 +259,12 @@ void ipu_pre_update(struct ipu_pre *pre, unsigned int bufaddr)
> writel(IPU_PRE_CTRL_SDW_UPDATE, pre->regs + IPU_PRE_CTRL_SET);
> }
>
> +bool ipu_pre_update_done(struct ipu_pre *pre)
Nitpick, can we invert the return value and call this
ipu_pre_update_pending? That way we don't return
update_done == true if no update has been issued at all.
The same goes for patches 2 and 3.
regards
Philipp
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
prev parent reply other threads:[~2018-10-05 14:16 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-14 16:59 [PATCH 1/4] gpu: ipu-v3: pre: add double buffer status readback Lucas Stach
2018-09-14 16:59 ` [PATCH 2/4] gpu: ipu-v3: prg: add function to get channel configure status Lucas Stach
2018-10-05 14:16 ` Philipp Zabel
2018-09-14 16:59 ` [PATCH 3/4] drm/imx: ipuv3-plane: add function to query atomic update status Lucas Stach
2018-10-05 14:16 ` Philipp Zabel
2018-09-14 16:59 ` [PATCH 4/4] drm/imx: only send commit done event when all state has been applied Lucas Stach
2018-10-05 15:11 ` Philipp Zabel
2019-01-23 11:35 ` Philipp Zabel
2019-01-23 13:04 ` Daniel Vetter
2018-10-05 14:16 ` Philipp Zabel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1538748963.3545.32.camel@pengutronix.de \
--to=p.zabel@pengutronix.de \
--cc=dri-devel@lists.freedesktop.org \
--cc=kernel@pengutronix.de \
--cc=l.stach@pengutronix.de \
--cc=patchwork-lst@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox