From mboxrd@z Thu Jan 1 00:00:00 1970 From: Philipp Zabel Subject: Re: [PATCH 4/4] drm/imx: only send commit done event when all state has been applied Date: Fri, 05 Oct 2018 17:11:13 +0200 Message-ID: <1538752273.3545.36.camel@pengutronix.de> References: <20180914165917.8464-1-l.stach@pengutronix.de> <20180914165917.8464-4-l.stach@pengutronix.de> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by gabe.freedesktop.org (Postfix) with ESMTPS id 7E9586E849 for ; Fri, 5 Oct 2018 15:11:15 +0000 (UTC) In-Reply-To: <20180914165917.8464-4-l.stach@pengutronix.de> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Lucas Stach Cc: kernel@pengutronix.de, dri-devel@lists.freedesktop.org, patchwork-lst@pengutronix.de List-Id: dri-devel@lists.freedesktop.org T24gRnJpLCAyMDE4LTA5LTE0IGF0IDE4OjU5ICswMjAwLCBMdWNhcyBTdGFjaCB3cm90ZToKPiBD dXJyZW50bHkgdGhlcmUgaXMgYSBzbWFsbCByYWNlIHdpbmRvdyB3aGVyZSB3ZSBjb3VsZCBtYW5h Z2UgdG8gYXJtIHRoZQo+IHZibGFuayBldmVudCBmcm9tIGF0b21pYyBmbHVzaCwgYnV0IHByb2dy YW1taW5nIHRoZSBoYXJkd2FyZSB3YXMgdG9vIGNsb3NlCj4gdG8gdGhlIGZyYW1lIGVuZCwgc28g dGhlIGhhcmR3YXJlIHdpbGwgb25seSBhcHBseSB0aGUgY3VycmVudCBzdGF0ZSBvbiB0aGUKPiBu ZXh0IHZibGFuay4gSW4gdGhpcyBjYXNlIHdlIHdpbGwgc2VuZCBvdXQgdGhlIGNvbW1pdCBkb25l IGV2ZW50IHRvbyBlYXJseQo+IGNhdXNpbmcgdXNlcnNwYWNlIHRvIHJldXNlIGZyYW1lYnVmZmVz IHRoYXQgYXJlIHN0aWxsIGluIHVzZS4KPiAKPiBJbnN0ZWFkIG9mIHVzaW5nIHRoZSBldmVudCBh cm1pbmcgbWVjaG5pc20sIGp1c3QgcmVtZW1iZXIgdGhlIHBlbmRpbmcgZXZlbnQKPiBhbmQgc2Vu ZCBpdCBmcm9tIHRoZSB2YmxhbmsgSVJRIGhhbmRsZXIsIG9uY2Ugd2UgYXJlIHN1cmUgdGhhdCBh bGwgc3RhdGUKPiBoYXMgYmVlbiBhcHBsaWVkIHN1Y2Vzc2Z1bGx5Lgo+IAo+IFNpZ25lZC1vZmYt Ynk6IEx1Y2FzIFN0YWNoIDxsLnN0YWNoQHBlbmd1dHJvbml4LmRlPgo+IC0tLQo+ICBkcml2ZXJz L2dwdS9kcm0vaW14L2lwdXYzLWNydGMuYyB8IDMyICsrKysrKysrKysrKysrKysrKysrKysrKysr KystLS0tCj4gIDEgZmlsZSBjaGFuZ2VkLCAyOCBpbnNlcnRpb25zKCspLCA0IGRlbGV0aW9ucygt KQo+IAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaW14L2lwdXYzLWNydGMuYyBiL2Ry aXZlcnMvZ3B1L2RybS9pbXgvaXB1djMtY3J0Yy5jCj4gaW5kZXggN2Q0YjcxMGI4MzdhLi5iMGM5 NTU2NWEyOGQgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2lteC9pcHV2My1jcnRjLmMK PiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaW14L2lwdXYzLWNydGMuYwo+IEBAIC00Miw2ICs0Miw3 IEBAIHN0cnVjdCBpcHVfY3J0YyB7Cj4gIAlzdHJ1Y3QgaXB1X2RjCQkqZGM7Cj4gIAlzdHJ1Y3Qg aXB1X2RpCQkqZGk7Cj4gIAlpbnQJCQlpcnE7Cj4gKwlzdHJ1Y3QgZHJtX3BlbmRpbmdfdmJsYW5r X2V2ZW50ICpldmVudDsKPiAgfTsKPiAgCj4gIHN0YXRpYyBpbmxpbmUgc3RydWN0IGlwdV9jcnRj ICp0b19pcHVfY3J0YyhzdHJ1Y3QgZHJtX2NydGMgKmNydGMpCj4gQEAgLTE4MSw4ICsxODIsMzEg QEAgc3RhdGljIGNvbnN0IHN0cnVjdCBkcm1fY3J0Y19mdW5jcyBpcHVfY3J0Y19mdW5jcyA9IHsK PiAgc3RhdGljIGlycXJldHVybl90IGlwdV9pcnFfaGFuZGxlcihpbnQgaXJxLCB2b2lkICpkZXZf aWQpCj4gIHsKPiAgCXN0cnVjdCBpcHVfY3J0YyAqaXB1X2NydGMgPSBkZXZfaWQ7Cj4gKwlzdHJ1 Y3QgZHJtX2NydGMgKmNydGMgPSAmaXB1X2NydGMtPmJhc2U7Cj4gKwl1bnNpZ25lZCBsb25nIGZs YWdzOwo+ICsJaW50IGk7Cj4gKwo+ICsJZHJtX2NydGNfaGFuZGxlX3ZibGFuayhjcnRjKTsKPiAr Cj4gKwlpZiAoaXB1X2NydGMtPmV2ZW50KSB7Cj4gKwkJZm9yIChpID0gMDsgaSA8IEFSUkFZX1NJ WkUoaXB1X2NydGMtPnBsYW5lKTsgaSsrKSB7Cj4gKwkJCXN0cnVjdCBpcHVfcGxhbmUgKnBsYW5l ID0gaXB1X2NydGMtPnBsYW5lW2ldOwo+ICsKPiArCQkJaWYgKCFwbGFuZSkKPiArCQkJCWNvbnRp bnVlOwo+ICsKPiArCQkJaWYgKCFpcHVfcGxhbmVfYXRvbWljX3VwZGF0ZV9kb25lKCZwbGFuZS0+ YmFzZSkpCgoJCQlpZiAoaXB1X3BsYW5lX2F0b21pY191cGRhdGVfcGVuZGluZygmcGxhbmUtPmJh c2UpKQoKPiArCQkJCWJyZWFrOwo+ICsJCX0KPiAgCj4gLQlkcm1fY3J0Y19oYW5kbGVfdmJsYW5r KCZpcHVfY3J0Yy0+YmFzZSk7Cj4gKwkJaWYgKGkgPT0gQVJSQVlfU0laRShpcHVfY3J0Yy0+cGxh bmUpKSB7Cj4gKwkJCXNwaW5fbG9ja19pcnFzYXZlKCZjcnRjLT5kZXYtPmV2ZW50X2xvY2ssIGZs YWdzKTsKPiArCQkJZHJtX2NydGNfc2VuZF92YmxhbmtfZXZlbnQoY3J0YywgaXB1X2NydGMtPmV2 ZW50KTsKPiArCQkJaXB1X2NydGMtPmV2ZW50ID0gTlVMTDsKClRoZXNlIHR3byBoYXBwZW4gdW5k ZXIgdGhlIGV2ZW50IHNwaW5sb2NrLCBidXQgd2hlcmUgZXZlbnQgaXMgc2V0IGluCmlwdV9jcnRj X2F0b21pY19mbHVzaCwgdGhlIGxvY2tpbmcgaXMgcmVtb3ZlZC4KCj4gKwkJCWRybV9jcnRjX3Zi bGFua19wdXQoY3J0Yyk7Cj4gKwkJCXNwaW5fdW5sb2NrX2lycXJlc3RvcmUoJmNydGMtPmRldi0+ ZXZlbnRfbG9jaywgZmxhZ3MpOwo+ICsJCX0KPiArCX0KPiAgCj4gIAlyZXR1cm4gSVJRX0hBTkRM RUQ7Cj4gIH0KPiBAQCAtMjI5LDEzICsyNTMsMTMgQEAgc3RhdGljIHZvaWQgaXB1X2NydGNfYXRv bWljX2JlZ2luKHN0cnVjdCBkcm1fY3J0YyAqY3J0YywKPiAgc3RhdGljIHZvaWQgaXB1X2NydGNf YXRvbWljX2ZsdXNoKHN0cnVjdCBkcm1fY3J0YyAqY3J0YywKPiAgCQkJCSAgc3RydWN0IGRybV9j cnRjX3N0YXRlICpvbGRfY3J0Y19zdGF0ZSkKPiAgewo+IC0Jc3Bpbl9sb2NrX2lycSgmY3J0Yy0+ ZGV2LT5ldmVudF9sb2NrKTsKPiArCXN0cnVjdCBpcHVfY3J0YyAqaXB1X2NydGMgPSB0b19pcHVf Y3J0YyhjcnRjKTsKPiArCj4gIAlpZiAoY3J0Yy0+c3RhdGUtPmV2ZW50KSB7Cj4gIAkJV0FSTl9P Tihkcm1fY3J0Y192YmxhbmtfZ2V0KGNydGMpKTsKPiAtCQlkcm1fY3J0Y19hcm1fdmJsYW5rX2V2 ZW50KGNydGMsIGNydGMtPnN0YXRlLT5ldmVudCk7Cj4gKwkJaXB1X2NydGMtPmV2ZW50ID0gY3J0 Yy0+c3RhdGUtPmV2ZW50OwoKV2UgYXNzdW1lIGhlcmUgdGhhdCBpcHVfY3J0Yy0+ZXZlbnQgaXMg TlVMTCBhbmQgdGhlIGlycSBoYW5kbGVyIGlzIG5ldmVyCnJ1bm5pbmcgYXQgdGhlIHNhbWUgdGlt ZSwgb3RoZXJ3aXNlIHdlIHdvdWxkIGRyb3AgYW4gZXZlbnQuIFRoaXMgaXMgbm9uLQpvYnZpb3Vz IHRvIG1lLCBhbmQgSSB0aGluayBpdCB3YXJyYW50cyBhIGNvbW1lbnQuCgpNeSB1bmRlcnN0YW5k aW5nIGlzIHRoZSBmb2xsb3dpbmc6CgotIEl0IGlzIHZpcnR1YWxseSBpbXBvc3NpYmxlIGZvciBh dG9taWNfZmx1c2ggdG8gcmFjZSBhZ2FpbnN0IGEgZGVsYXllZAogIHByZXZpb3VzIGlwdV9pcnFf aGFuZGxlciBiZWNhdXNlIHRoZSBwcmV2aW91cyBjb21taXQncyBjb21taXRfdGFpbAogIHdvdWxk IHN0aWxsIGJlIHdhaXRpbmcgZm9yIHRoZSB2YmxhbmsgZXZlbnQgdG8gcmVsZWFzZSBpdCBmcm9t CiAgZHJtX2F0b21pY19oZWxwZXJfd2FpdF9mb3JfZmxpcF9kb25lLgoKICBIb3dldmVyLCBpZiB0 aGUgbGFzdCBjb21taXQncyB0YWlsIGZpbmlzaGVzwqBhZnRlciB0aGUgaXJxX2hhbmRsZXIKICBj YWxscyBkcm1fY3J0Y19zZW5kX3ZibGFua19ldmVudCgpLCBhbmQgdGhlwqBuZXcgY29tbWl0IGlz IGlzc3VlZCwgYW5kCiAgaXRzIHRhaWwgd29yayBzY2hlZHVsZWQsIGFsbCBiZWZvcmUgdGhlIG5l eHQgbGluZSBpbiB0aGUgaXJxX2hhbmRsZXIsCiAgaXB1X2NydGMtPmV2ZW50ID0gTlVMTCwgdGhl biB0aGUgbmV3IGNvbW1pdCdzIHRhaWwgY291bGQgY2FsbAogIGRybV9hdG9taWNfaGVscGVyX2Nv bW1pdF9wbGFuZXMgYW5kIHRoZXJlZm9yZSBpcHVfY3J0Y19hdG9taWNfZmx1c2gKICBhbmQgaXB1 X2NydGMtPmV2ZW50IHdvdWxkIGJlIG92ZXJ3cml0dGVuLgoKLSBJdCBpcyB1bnByb2JsZW1hdGlj IGZvciBhIGRlbGF5ZWQgYXRvbWljX2ZsdXNoIHRvIHJhY2UgYWdhaW5zdCB0aGUKICBuZXh0IGlw dV9pcnFfaGFuZGxlciBiZWNhdXNlIGlwdV9jcnRjLT5ldmVudCB3aWxsIGp1c3Qgbm90IGJlIHNl dAogIHdoZW4gdGhlIGlycSBoYW5kbGVyIGNoZWNrcyBpdCwgYW5kIHRoZSB2YmxhbmsgZXZlbnQg d2lsbCBiZSBkZWZlcnJlZAogIHRvIHRoZSBuZXh0IGludGVycnVwdC4KCnJlZ2FyZHMKUGhpbGlw cApfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2 ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9s aXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK