From mboxrd@z Thu Jan 1 00:00:00 1970 From: Philipp Zabel Subject: Re: [PATCH v6 1/7] gpu: ipu-v3: ipu-ic: Fix saturation bit offset in TPMEM Date: Fri, 08 Mar 2019 11:24:02 +0100 Message-ID: <1552040642.4009.2.camel@pengutronix.de> References: <20190307233356.23748-1-slongerbeam@gmail.com> <20190307233356.23748-2-slongerbeam@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20190307233356.23748-2-slongerbeam@gmail.com> Sender: stable-owner@vger.kernel.org To: Steve Longerbeam , linux-media@vger.kernel.org Cc: Tim Harvey , stable@vger.kernel.org, "open list:DRM DRIVERS FOR FREESCALE IMX" , open list List-Id: dri-devel@lists.freedesktop.org On Thu, 2019-03-07 at 15:33 -0800, Steve Longerbeam wrote: > The saturation bit was being set at bit 9 in the second 32-bit word > of the TPMEM CSC. This isn't correct, the saturation bit is bit 42, > which is bit 10 of the second word. > > Fixes: 1aa8ea0d2bd5d ("gpu: ipu-v3: Add Image Converter unit") > > Signed-off-by: Steve Longerbeam > Cc: stable@vger.kernel.org > --- > drivers/gpu/ipu-v3/ipu-ic.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/ipu-v3/ipu-ic.c b/drivers/gpu/ipu-v3/ipu-ic.c > index 594c3cbc8291..18816ccf600e 100644 > --- a/drivers/gpu/ipu-v3/ipu-ic.c > +++ b/drivers/gpu/ipu-v3/ipu-ic.c > @@ -257,7 +257,7 @@ static int init_csc(struct ipu_ic *ic, > writel(param, base++); > > param = ((a[0] & 0x1fe0) >> 5) | (params->scale << 8) | > - (params->sat << 9); > + (params->sat << 10); > writel(param, base++); > > param = ((a[1] & 0x1f) << 27) | ((c[0][1] & 0x1ff) << 18) | Reviewed-by: Philipp Zabel regards Philipp