* [RFC PATCH v2] drm/komeda: Creates plane alpha and blend mode properties
@ 2019-04-04 10:10 Lowry Li (Arm Technology China)
2019-04-08 7:33 ` [RFC,v2] " james qian wang (Arm Technology China)
0 siblings, 1 reply; 2+ messages in thread
From: Lowry Li (Arm Technology China) @ 2019-04-04 10:10 UTC (permalink / raw)
To: Liviu Dudau, james qian wang (Arm Technology China),
maarten.lankhorst@linux.intel.com, seanpaul@chromium.org,
airlied@linux.ie, Brian Starkey
Cc: Julien Yin (Arm Technology China),
Jonathan Chai (Arm Technology China), Ayan Halder,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, nd
Creates plane alpha and blend mode properties attached to plane.
This patch depends on:
- https://patchwork.freedesktop.org/series/54448/
- https://patchwork.freedesktop.org/series/54449/
- https://patchwork.freedesktop.org/series/54450/
Changes since v1:
- Adds patch denpendency in the comment
Signed-off-by: Lowry Li (Arm Technology China) <lowry.li@arm.com>
---
drivers/gpu/drm/arm/display/komeda/komeda_plane.c | 11 +++++++++++
1 file changed, 11 insertions(+)
diff --git a/drivers/gpu/drm/arm/display/komeda/komeda_plane.c b/drivers/gpu/drm/arm/display/komeda/komeda_plane.c
index 68cd2c9e..aae5e80 100644
--- a/drivers/gpu/drm/arm/display/komeda/komeda_plane.c
+++ b/drivers/gpu/drm/arm/display/komeda/komeda_plane.c
@@ -220,6 +220,17 @@ static int komeda_plane_add(struct komeda_kms_dev *kms,
drm_plane_helper_add(plane, &komeda_plane_helper_funcs);
+ err = drm_plane_create_alpha_property(plane);
+ if (err)
+ goto cleanup;
+
+ err = drm_plane_create_blend_mode_property(plane,
+ BIT(DRM_MODE_BLEND_PIXEL_NONE) |
+ BIT(DRM_MODE_BLEND_PREMULTI) |
+ BIT(DRM_MODE_BLEND_COVERAGE));
+ if (err)
+ goto cleanup;
+
return 0;
cleanup:
komeda_plane_destroy(plane);
--
1.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [RFC,v2] drm/komeda: Creates plane alpha and blend mode properties
2019-04-04 10:10 [RFC PATCH v2] drm/komeda: Creates plane alpha and blend mode properties Lowry Li (Arm Technology China)
@ 2019-04-08 7:33 ` james qian wang (Arm Technology China)
0 siblings, 0 replies; 2+ messages in thread
From: james qian wang (Arm Technology China) @ 2019-04-08 7:33 UTC (permalink / raw)
To: Lowry Li (Arm Technology China)
Cc: Liviu Dudau, maarten.lankhorst@linux.intel.com,
seanpaul@chromium.org, airlied@linux.ie, Brian Starkey,
Ayan Halder, Jonathan Chai (Arm Technology China),
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
Julien Yin (Arm Technology China), nd
On Thu, Apr 04, 2019 at 10:10:36AM +0000, Lowry Li (Arm Technology China) wrote:
> Creates plane alpha and blend mode properties attached to plane.
>
> This patch depends on:
> - https://patchwork.freedesktop.org/series/54448/
> - https://patchwork.freedesktop.org/series/54449/
> - https://patchwork.freedesktop.org/series/54450/
>
> Changes since v1:
> - Adds patch denpendency in the comment
>
> Signed-off-by: Lowry Li (Arm Technology China) <lowry.li@arm.com>
> ---
> drivers/gpu/drm/arm/display/komeda/komeda_plane.c | 11 +++++++++++
> 1 file changed, 11 insertions(+)
>
> diff --git a/drivers/gpu/drm/arm/display/komeda/komeda_plane.c b/drivers/gpu/drm/arm/display/komeda/komeda_plane.c
> index 68cd2c9e..aae5e80 100644
> --- a/drivers/gpu/drm/arm/display/komeda/komeda_plane.c
> +++ b/drivers/gpu/drm/arm/display/komeda/komeda_plane.c
> @@ -220,6 +220,17 @@ static int komeda_plane_add(struct komeda_kms_dev *kms,
>
> drm_plane_helper_add(plane, &komeda_plane_helper_funcs);
>
> + err = drm_plane_create_alpha_property(plane);
> + if (err)
> + goto cleanup;
> +
> + err = drm_plane_create_blend_mode_property(plane,
> + BIT(DRM_MODE_BLEND_PIXEL_NONE) |
> + BIT(DRM_MODE_BLEND_PREMULTI) |
> + BIT(DRM_MODE_BLEND_COVERAGE));
> + if (err)
> + goto cleanup;
> +
> return 0;
> cleanup:
> komeda_plane_destroy(plane);
Looks good to me.
Reviewed-by: James Qian Wang (Arm Technology China) <james.qian.wang@arm.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-04-08 7:33 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-04-04 10:10 [RFC PATCH v2] drm/komeda: Creates plane alpha and blend mode properties Lowry Li (Arm Technology China)
2019-04-08 7:33 ` [RFC,v2] " james qian wang (Arm Technology China)
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).