From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wen Yang Subject: [PATCH v2] drm/omap: fix possible object reference leak Date: Mon, 8 Apr 2019 10:58:32 +0800 Message-ID: <1554692313-28882-2-git-send-email-wen.yang99@zte.com.cn> References: <1554692313-28882-1-git-send-email-wen.yang99@zte.com.cn> Return-path: In-Reply-To: <1554692313-28882-1-git-send-email-wen.yang99@zte.com.cn> Sender: linux-kernel-owner@vger.kernel.org To: linux-kernel@vger.kernel.org Cc: wang.yi59@zte.com.cn, Wen Yang , Tomi Valkeinen , David Airlie , Daniel Vetter , Sebastian Reichel , Laurent Pinchart , dri-devel@lists.freedesktop.org, Markus Elfring List-Id: dri-devel@lists.freedesktop.org The call to of_find_matching_node returns a node pointer with refcount incremented thus it must be explicitly decremented after the last usage. Detected by coccinelle with the following warnings: drivers/gpu/drm/omapdrm/dss/omapdss-boot-init.c:212:2-8: ERROR: missing of_node_put; acquired a node pointer with refcount incremented on line 209, but without a corresponding object release within this function. drivers/gpu/drm/omapdrm/dss/omapdss-boot-init.c:237:1-7: ERROR: missing of_node_put; acquired a node pointer with refcount incremented on line 209, but without a corresponding object release within this function. Signed-off-by: Wen Yang Reviewed-by: Laurent Pinchart Cc: Tomi Valkeinen Cc: David Airlie Cc: Daniel Vetter Cc: Sebastian Reichel Cc: Laurent Pinchart Cc: dri-devel@lists.freedesktop.org Cc: linux-kernel@vger.kernel.org Cc: Markus Elfring --- v2->v1: add a jump target. drivers/gpu/drm/omapdrm/dss/omapdss-boot-init.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/omapdrm/dss/omapdss-boot-init.c b/drivers/gpu/drm/omapdrm/dss/omapdss-boot-init.c index 2b41c75..13b3b4a 100644 --- a/drivers/gpu/drm/omapdrm/dss/omapdss-boot-init.c +++ b/drivers/gpu/drm/omapdrm/dss/omapdss-boot-init.c @@ -209,7 +209,7 @@ static int __init omapdss_boot_init(void) dss = of_find_matching_node(NULL, omapdss_of_match); if (dss == NULL || !of_device_is_available(dss)) - return 0; + goto put_node; omapdss_walk_device(dss, true); @@ -234,6 +234,8 @@ static int __init omapdss_boot_init(void) kfree(n); } +put_node: + of_node_put(dss); return 0; } -- 2.9.5