dri-devel.lists.freedesktop.org archive mirror
 help / color / mirror / Atom feed
From: Philipp Zabel <p.zabel@pengutronix.de>
To: Andrzej Pietrasiewicz <andrzej.p@collabora.com>,
	dri-devel@lists.freedesktop.org
Cc: Sam Ravnborg <sam@ravnborg.org>,
	Neil Armstrong <narmstrong@baylibre.com>,
	David Airlie <airlied@linux.ie>,
	Douglas Anderson <dianders@chromium.org>,
	Thierry Reding <thierry.reding@gmail.com>,
	Laurent Pinchart <Laurent.pinchart@ideasonboard.com>,
	kernel@collabora.com, linux-samsung-soc@vger.kernel.org,
	Jyri Sarha <jsarha@ti.com>,
	Vincent Abriou <vincent.abriou@st.com>,
	Krzysztof Kozlowski <krzk@kernel.org>,
	Jonathan Hunter <jonathanh@nvidia.com>,
	linux-rockchip@lists.infradead.org, Chen-Yu Tsai <wens@csie.org>,
	Kukjin Kim <kgene@kernel.org>, NXP Linux Team <linux-imx@nxp.com>,
	Dave Airlie <airlied@redhat.com>,
	intel-gfx@lists.freedesktop.org, freedreno@lists.freedesktop.org,
	linux-tegra@vger.kernel.org,
	Pengutronix Kernel Team <kernel@pengutronix.de>,
	Jonas Karlman <jonas@kwiboo.se>,
	linux-arm-msm@vger.kernel.org,
	Alexios Zavras <alexios.zavras@intel.com>
Subject: Re: [PATCH v6 11/24] drm/imx: imx-tve: Provide ddc symlink in connector's sysfs
Date: Mon, 29 Jul 2019 11:20:42 +0200	[thread overview]
Message-ID: <1564392042.7633.1.camel@pengutronix.de> (raw)
In-Reply-To: <1c660776741760b8094484268b670a09da8a9042.1564161140.git.andrzej.p@collabora.com>

On Fri, 2019-07-26 at 19:23 +0200, Andrzej Pietrasiewicz wrote:
> Use the ddc pointer provided by the generic connector.
> 
> Signed-off-by: Andrzej Pietrasiewicz <andrzej.p@collabora.com>

Acked-by: Philipp Zabel <p.zabel@pengutronix.de>

regards
Philipp

> ---
>  drivers/gpu/drm/imx/imx-tve.c | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/imx/imx-tve.c b/drivers/gpu/drm/imx/imx-tve.c
> index 649515868f86..5bbfaa2cd0f4 100644
> --- a/drivers/gpu/drm/imx/imx-tve.c
> +++ b/drivers/gpu/drm/imx/imx-tve.c
> @@ -484,8 +484,10 @@ static int imx_tve_register(struct drm_device *drm, struct imx_tve *tve)
>  
>  	drm_connector_helper_add(&tve->connector,
>  			&imx_tve_connector_helper_funcs);
> -	drm_connector_init(drm, &tve->connector, &imx_tve_connector_funcs,
> -			   DRM_MODE_CONNECTOR_VGA);
> +	drm_connector_init_with_ddc(drm, &tve->connector,
> +				    &imx_tve_connector_funcs,
> +				    DRM_MODE_CONNECTOR_VGA,
> +				    tve->ddc);
>  
>  	drm_connector_attach_encoder(&tve->connector, &tve->encoder);
>  
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

  reply	other threads:[~2019-07-29  9:20 UTC|newest]

Thread overview: 72+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-26 17:22 [PATCH v6 00/24] Associate ddc adapters with connectors Andrzej Pietrasiewicz
2019-07-26 17:22 ` [PATCH v6 02/24] drm: Add drm_connector_init() variant with ddc Andrzej Pietrasiewicz
2019-07-26 17:22 ` [PATCH v6 04/24] drm: rockchip: Provide ddc symlink in rk3066_hdmi sysfs directory Andrzej Pietrasiewicz
2019-07-26 17:22 ` [PATCH v6 05/24] drm: rockchip: Provide ddc symlink in inno_hdmi " Andrzej Pietrasiewicz
2019-07-26 17:23 ` [PATCH v6 06/24] drm/msm/hdmi: Provide ddc symlink in hdmi connector " Andrzej Pietrasiewicz
2019-07-26 17:23 ` [PATCH v6 08/24] drm/mediatek: " Andrzej Pietrasiewicz
2019-07-26 17:23 ` [PATCH v6 09/24] drm/tegra: Provide ddc symlink in output " Andrzej Pietrasiewicz
2019-07-26 17:23 ` [PATCH v6 12/24] drm/vc4: Provide ddc symlink in " Andrzej Pietrasiewicz
2019-07-26 17:23 ` [PATCH v6 13/24] drm: zte: Provide ddc symlink in hdmi " Andrzej Pietrasiewicz
2019-07-26 17:23 ` [PATCH v6 15/24] drm/tilcdc: Provide ddc symlink in " Andrzej Pietrasiewicz
2019-07-26 17:23 ` [PATCH v6 16/24] drm: sti: Provide ddc symlink in hdmi " Andrzej Pietrasiewicz
     [not found]   ` <510765aff8ef99683aa2da48bd08004376b1980a.1564161140.git.andrzej.p-ZGY8ohtN/8qB+jHODAdFcQ@public.gmane.org>
2019-07-30 12:36     ` Benjamin Gaignard
2019-07-26 17:23 ` [PATCH v6 17/24] drm/mgag200: Provide ddc symlink in " Andrzej Pietrasiewicz
2019-07-26 17:23 ` [PATCH v6 19/24] drm/bridge: dumb-vga-dac: " Andrzej Pietrasiewicz
     [not found]   ` <ebb75e71b8b7c8d65d54a947a03fd21b8969fb3a.1564161140.git.andrzej.p-ZGY8ohtN/8qB+jHODAdFcQ@public.gmane.org>
2019-07-30 12:28     ` Neil Armstrong
2019-08-08  3:42     ` Guenter Roeck
2019-08-13  9:33       ` Geert Uytterhoeven
2019-07-26 17:23 ` [PATCH v6 21/24] drm/bridge: ti-tfp410: " Andrzej Pietrasiewicz
     [not found]   ` <3b61da77a6456805db0deffe6d1a2343dd784730.1564161140.git.andrzej.p-ZGY8ohtN/8qB+jHODAdFcQ@public.gmane.org>
2019-07-30 12:30     ` Neil Armstrong
2019-07-26 17:23 ` [PATCH v6 22/24] drm/amdgpu: " Andrzej Pietrasiewicz
2019-07-26 19:28   ` Alex Deucher
     [not found]     ` <CADnq5_O1B59Q+68fJgtf_bn_=WQ9yrVPq-V5tL1VQ3+vzgf1Zw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2019-07-26 19:42       ` Andrzej Pietrasiewicz
     [not found]         ` <038809c7-e664-e365-a778-03bc11299193-ZGY8ohtN/8qB+jHODAdFcQ@public.gmane.org>
2019-07-26 20:00           ` Alex Deucher
2019-07-26 17:23 ` [PATCH v6 23/24] drm/radeon: " Andrzej Pietrasiewicz
2019-07-26 19:26   ` Alex Deucher
2019-07-26 18:35 ` [PATCH v6 00/24] Associate ddc adapters with connectors Sam Ravnborg
2019-07-26 18:55   ` Review required [Was: Associate ddc adapters with connectors] Sam Ravnborg
     [not found]     ` <20190726185538.GD14981-uyr5N9Q2VtJg9hUCZPvPmw@public.gmane.org>
2019-07-31  8:00       ` Neil Armstrong
2019-07-31 10:40         ` Sam Ravnborg
2019-07-31 13:10           ` Andrzej Pietrasiewicz
     [not found]             ` <959cf323-c6b9-895b-592c-81c52aacae6e-ZGY8ohtN/8qB+jHODAdFcQ@public.gmane.org>
2019-07-31 14:22               ` Neil Armstrong
     [not found]                 ` <ce68a0df-1719-7b53-b0ed-89caa9afc4a0-rdvid1DuHRBWk0Htik3J/w@public.gmane.org>
2019-07-31 15:32                   ` Neil Armstrong
2019-07-31 16:58                     ` [PATCH 00/13] Next round of associating ddc adapters with connectors Andrzej Pietrasiewicz
2019-07-31 16:58                       ` [PATCH 02/13] drm/radeon: Eliminate possible use of an uninitialized variable Andrzej Pietrasiewicz
     [not found]                         ` <cfff357a07bfa572baad058947f281b7095e1794.1564591626.git.andrzej.p-ZGY8ohtN/8qB+jHODAdFcQ@public.gmane.org>
2019-08-01 12:15                           ` Neil Armstrong
     [not found]                             ` <7cacac43-737e-1ddb-2951-394fcf9ad0b2-rdvid1DuHRBWk0Htik3J/w@public.gmane.org>
2019-08-01 16:36                               ` [PATCH] drm/radeon: Provide ddc symlink in connector sysfs directory Andrzej Pietrasiewicz
     [not found]                       ` <cover.1564591626.git.andrzej.p-ZGY8ohtN/8qB+jHODAdFcQ@public.gmane.org>
2019-07-31 16:58                         ` [PATCH 01/13] drm/amdgpu: Provide ddc symlink in dm connector's " Andrzej Pietrasiewicz
2019-07-31 16:58                         ` [PATCH 03/13] drm/exynos: Provide ddc symlink in connector's sysfs Andrzej Pietrasiewicz
     [not found]                           ` <613c1c09ff7db5be60ef86f930b45b3f56b4838d.1564591626.git.andrzej.p-ZGY8ohtN/8qB+jHODAdFcQ@public.gmane.org>
2019-11-08  0:22                             ` Inki Dae
2019-11-08  0:22                               ` Inki Dae
2019-07-31 16:58                         ` [PATCH 04/13] drm: rockchip: Provide ddc symlink in rk3066_hdmi sysfs directory Andrzej Pietrasiewicz
2019-08-06  8:36                           ` Heiko Stuebner
2019-07-31 16:58                         ` [PATCH 05/13] drm: rockchip: Provide ddc symlink in inno_hdmi " Andrzej Pietrasiewicz
2019-08-06  8:36                           ` Heiko Stuebner
2019-07-31 16:58                         ` [PATCH 06/13] drm/msm/hdmi: Provide ddc symlink in hdmi connector " Andrzej Pietrasiewicz
2019-07-31 16:58                         ` [PATCH 07/13] drm/mediatek: " Andrzej Pietrasiewicz
2019-08-01  9:06                           ` Philipp Zabel
2019-07-31 16:58                         ` [PATCH 08/13] drm/tegra: Provide ddc symlink in output " Andrzej Pietrasiewicz
2019-07-31 16:58                         ` [PATCH 09/13] drm/vc4: Provide ddc symlink in " Andrzej Pietrasiewicz
2019-07-31 16:58                         ` [PATCH 11/13] drm: zte: Provide ddc symlink in vga " Andrzej Pietrasiewicz
2019-07-31 16:58                         ` [PATCH 12/13] drm/tilcdc: Provide ddc symlink in " Andrzej Pietrasiewicz
     [not found]                           ` <b8faad34102a91698b55dfc1ce02b1a90fda5e44.1564591626.git.andrzej.p-ZGY8ohtN/8qB+jHODAdFcQ@public.gmane.org>
2019-08-05  8:32                             ` Jyri Sarha
2019-07-31 16:58                       ` [PATCH 10/13] drm: zte: Provide ddc symlink in hdmi " Andrzej Pietrasiewicz
2019-07-31 16:58                       ` [PATCH 13/13] drm/i915: " Andrzej Pietrasiewicz
     [not found] ` <cover.1564161140.git.andrzej.p-ZGY8ohtN/8qB+jHODAdFcQ@public.gmane.org>
2019-07-26 17:22   ` [PATCH v6 01/24] drm: Add ddc link in sysfs created by drm_connector Andrzej Pietrasiewicz
     [not found]     ` <d470def6cd661b777faeee67b5838a4623c4010e.1564161140.git.andrzej.p-ZGY8ohtN/8qB+jHODAdFcQ@public.gmane.org>
2019-08-04 12:04       ` Laurent Pinchart
2019-08-04 12:27         ` Laurent Pinchart
2019-07-26 17:22   ` [PATCH v6 03/24] drm/exynos: Provide ddc symlink in connector's sysfs Andrzej Pietrasiewicz
2019-07-26 17:23   ` [PATCH v6 07/24] drm/sun4i: hdmi: Provide ddc symlink in sun4i hdmi connector sysfs directory Andrzej Pietrasiewicz
2019-07-27 10:37     ` Maxime Ripard
2019-07-26 17:23   ` [PATCH v6 10/24] drm/imx: imx-ldb: Provide ddc symlink in connector's sysfs Andrzej Pietrasiewicz
2019-07-29  9:20     ` Philipp Zabel
2019-07-26 17:23   ` [PATCH v6 11/24] drm/imx: imx-tve: " Andrzej Pietrasiewicz
2019-07-29  9:20     ` Philipp Zabel [this message]
2019-07-26 17:23   ` [PATCH v6 14/24] drm: zte: Provide ddc symlink in vga connector sysfs directory Andrzej Pietrasiewicz
2019-07-26 17:23   ` [PATCH v6 18/24] drm/ast: Provide ddc symlink in " Andrzej Pietrasiewicz
2019-07-26 17:23   ` [PATCH v6 20/24] drm/bridge: dw-hdmi: " Andrzej Pietrasiewicz
     [not found]     ` <4bcf0f154c683c9787fa34f911ebc52de6b4a7a1.1564161140.git.andrzej.p-ZGY8ohtN/8qB+jHODAdFcQ@public.gmane.org>
2019-07-26 19:18       ` Jernej Škrabec
2019-07-26 17:23   ` [PATCH v6 24/24] drm/i915: Provide ddc symlink in hdmi " Andrzej Pietrasiewicz
2019-07-30 15:01   ` [PATCH v6 00/24] Associate ddc adapters with connectors Emil Velikov
2019-08-04 12:36     ` Laurent Pinchart
2019-08-04 12:33 ` Laurent Pinchart

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1564392042.7633.1.camel@pengutronix.de \
    --to=p.zabel@pengutronix.de \
    --cc=Laurent.pinchart@ideasonboard.com \
    --cc=airlied@linux.ie \
    --cc=airlied@redhat.com \
    --cc=alexios.zavras@intel.com \
    --cc=andrzej.p@collabora.com \
    --cc=dianders@chromium.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=freedreno@lists.freedesktop.org \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=jonas@kwiboo.se \
    --cc=jonathanh@nvidia.com \
    --cc=jsarha@ti.com \
    --cc=kernel@collabora.com \
    --cc=kernel@pengutronix.de \
    --cc=kgene@kernel.org \
    --cc=krzk@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-imx@nxp.com \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=linux-tegra@vger.kernel.org \
    --cc=narmstrong@baylibre.com \
    --cc=sam@ravnborg.org \
    --cc=thierry.reding@gmail.com \
    --cc=vincent.abriou@st.com \
    --cc=wens@csie.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).