From: Philipp Zabel <p.zabel@pengutronix.de>
To: Marco Felsch <m.felsch@pengutronix.de>
Cc: kernel@pengutronix.de, dri-devel@lists.freedesktop.org,
Steve Longerbeam <slongerbeam@gmail.com>
Subject: Re: [PATCH 1/2] gpu: ipu-v3: enable remaining 32-bit RGB V4L2 pixel formats
Date: Thu, 15 Aug 2019 11:01:30 +0200 [thread overview]
Message-ID: <1565859690.3011.4.camel@pengutronix.de> (raw)
In-Reply-To: <20190815063653.rxo7werudf4nxngj@pengutronix.de>
Hi Marco,
On Thu, 2019-08-15 at 08:36 +0200, Marco Felsch wrote:
> Hi Philipp,
>
> On 19-08-14 17:10, Philipp Zabel wrote:
> > Support is already implemented for the corresponding DRM formats,
> > just hook up the remaining V4L2 pixel formats.
> >
> > Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
> > ---
> > drivers/gpu/ipu-v3/ipu-common.c | 16 ++++++++++------
> > drivers/gpu/ipu-v3/ipu-cpmem.c | 26 +++++++++++++++++++++++++-
> > 2 files changed, 35 insertions(+), 7 deletions(-)
> >
> > diff --git a/drivers/gpu/ipu-v3/ipu-common.c b/drivers/gpu/ipu-v3/ipu-common.c
> > index 6386e2fe2ff7..ee2a025e54cf 100644
> > --- a/drivers/gpu/ipu-v3/ipu-common.c
> > +++ b/drivers/gpu/ipu-v3/ipu-common.c
> > @@ -113,13 +113,17 @@ enum ipu_color_space ipu_pixelformat_to_colorspace(u32 pixelformat)
> > case V4L2_PIX_FMT_NV16:
> > case V4L2_PIX_FMT_NV61:
> > return IPUV3_COLORSPACE_YUV;
> > - case V4L2_PIX_FMT_XRGB32:
> > - case V4L2_PIX_FMT_XBGR32:
> > - case V4L2_PIX_FMT_RGB32:
> > - case V4L2_PIX_FMT_BGR32:
> > - case V4L2_PIX_FMT_RGB24:
> > - case V4L2_PIX_FMT_BGR24:
> > case V4L2_PIX_FMT_RGB565:
> > + case V4L2_PIX_FMT_BGR24:
>
> Nitpick:
> Should we add '/* fall through */' comments?
Not for this. -Wimplicit-fallthrough only requires annotation if there
are statements between two cases.
> Feel free to add my
> Reviewed-by: Marco Felsch <m.felsch@pengutronix.de>
Thanks!
regards
Philipp
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
prev parent reply other threads:[~2019-08-15 9:01 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-14 15:10 [PATCH 1/2] gpu: ipu-v3: enable remaining 32-bit RGB V4L2 pixel formats Philipp Zabel
2019-08-14 15:10 ` [PATCH 2/2] gpu: ipu-v3: image-convert: enable V4L2_PIX_FMT_BGRX32 and _RGBX32 Philipp Zabel
2019-08-15 6:36 ` [PATCH 1/2] gpu: ipu-v3: enable remaining 32-bit RGB V4L2 pixel formats Marco Felsch
2019-08-15 9:01 ` Philipp Zabel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1565859690.3011.4.camel@pengutronix.de \
--to=p.zabel@pengutronix.de \
--cc=dri-devel@lists.freedesktop.org \
--cc=kernel@pengutronix.de \
--cc=m.felsch@pengutronix.de \
--cc=slongerbeam@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox