From mboxrd@z Thu Jan 1 00:00:00 1970 From: CK Hu Subject: Re: [PATCH] drm/mediatek: Check return value of mtk_drm_ddp_comp_for_plane. Date: Fri, 22 Nov 2019 15:58:41 +0800 Message-ID: <1574409521.12825.0.camel@mtksdaap41> References: <20191118061806.52781-1-pihsun@chromium.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mailgw01.mediatek.com (unknown [210.61.82.183]) by gabe.freedesktop.org (Postfix) with ESMTP id 9D4DF6F4E1 for ; Fri, 22 Nov 2019 07:58:46 +0000 (UTC) In-Reply-To: <20191118061806.52781-1-pihsun@chromium.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Pi-Hsun Shih Cc: David Airlie , open list , "open list:DRM DRIVERS FOR MEDIATEK" , Sean Paul , Matthias Brugger , "moderated list:ARM/Mediatek SoC support" , "moderated list:ARM/Mediatek SoC support" List-Id: dri-devel@lists.freedesktop.org SGksIFBpLUhzdW46DQoNCk9uIE1vbiwgMjAxOS0xMS0xOCBhdCAxNDoxOCArMDgwMCwgUGktSHN1 biBTaGloIHdyb3RlOg0KPiBUaGUgbXRrX2RybV9kZHBfY29tcF9mb3JfcGxhbmUgY2FuIHJldHVy biBOVUxMLCBidXQgdGhlIHVzYWdlIGRvZXNuJ3QNCj4gY2hlY2sgZm9yIGl0LiBBZGQgY2hlY2sg Zm9yIGl0Lg0KDQpSZXZpZXdlZC1ieTogQ0sgSHUgPGNrLmh1QG1lZGlhdGVrLmNvbT4NCg0KPiAN Cj4gRml4ZXM6IGQ2YjUzZjY4MzU2ZiAoImRybS9tZWRpYXRlazogQWRkIGhlbHBlciB0byBnZXQg Y29tcG9uZW50IGZvciBhIHBsYW5lIikNCj4gU2lnbmVkLW9mZi1ieTogUGktSHN1biBTaGloIDxw aWhzdW5AY2hyb21pdW0ub3JnPg0KPiAtLS0NCj4gIGRyaXZlcnMvZ3B1L2RybS9tZWRpYXRlay9t dGtfZHJtX2NydGMuYyB8IDEzICsrKysrKysrKy0tLS0NCj4gIDEgZmlsZSBjaGFuZ2VkLCA5IGlu c2VydGlvbnMoKyksIDQgZGVsZXRpb25zKC0pDQo+IA0KPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9n cHUvZHJtL21lZGlhdGVrL210a19kcm1fY3J0Yy5jIGIvZHJpdmVycy9ncHUvZHJtL21lZGlhdGVr L210a19kcm1fY3J0Yy5jDQo+IGluZGV4IGY4MGE4YmE3NTk3Ny4uNGM0Zjk3NmM5OTRlIDEwMDY0 NA0KPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vbWVkaWF0ZWsvbXRrX2RybV9jcnRjLmMNCj4gKysr IGIvZHJpdmVycy9ncHUvZHJtL21lZGlhdGVrL210a19kcm1fY3J0Yy5jDQo+IEBAIC0zMTAsNyAr MzEwLDkgQEAgc3RhdGljIGludCBtdGtfY3J0Y19kZHBfaHdfaW5pdChzdHJ1Y3QgbXRrX2RybV9j cnRjICptdGtfY3J0YykNCj4gIA0KPiAgCQlwbGFuZV9zdGF0ZSA9IHRvX210a19wbGFuZV9zdGF0 ZShwbGFuZS0+c3RhdGUpOw0KPiAgCQljb21wID0gbXRrX2RybV9kZHBfY29tcF9mb3JfcGxhbmUo Y3J0YywgcGxhbmUsICZsb2NhbF9sYXllcik7DQo+IC0JCW10a19kZHBfY29tcF9sYXllcl9jb25m aWcoY29tcCwgbG9jYWxfbGF5ZXIsIHBsYW5lX3N0YXRlKTsNCj4gKwkJaWYgKGNvbXApDQo+ICsJ CQltdGtfZGRwX2NvbXBfbGF5ZXJfY29uZmlnKGNvbXAsIGxvY2FsX2xheWVyLA0KPiArCQkJCQkJ ICBwbGFuZV9zdGF0ZSk7DQo+ICAJfQ0KPiAgDQo+ICAJcmV0dXJuIDA7DQo+IEBAIC0zODYsOCAr Mzg4LDkgQEAgc3RhdGljIHZvaWQgbXRrX2NydGNfZGRwX2NvbmZpZyhzdHJ1Y3QgZHJtX2NydGMg KmNydGMpDQo+ICAJCQljb21wID0gbXRrX2RybV9kZHBfY29tcF9mb3JfcGxhbmUoY3J0YywgcGxh bmUsDQo+ICAJCQkJCQkJICAmbG9jYWxfbGF5ZXIpOw0KPiAgDQo+IC0JCQltdGtfZGRwX2NvbXBf bGF5ZXJfY29uZmlnKGNvbXAsIGxvY2FsX2xheWVyLA0KPiAtCQkJCQkJICBwbGFuZV9zdGF0ZSk7 DQo+ICsJCQlpZiAoY29tcCkNCj4gKwkJCQltdGtfZGRwX2NvbXBfbGF5ZXJfY29uZmlnKGNvbXAs IGxvY2FsX2xheWVyLA0KPiArCQkJCQkJCSAgcGxhbmVfc3RhdGUpOw0KPiAgCQkJcGxhbmVfc3Rh dGUtPnBlbmRpbmcuY29uZmlnID0gZmFsc2U7DQo+ICAJCX0NCj4gIAkJbXRrX2NydGMtPnBlbmRp bmdfcGxhbmVzID0gZmFsc2U7DQo+IEBAIC00MDEsNyArNDA0LDkgQEAgaW50IG10a19kcm1fY3J0 Y19wbGFuZV9jaGVjayhzdHJ1Y3QgZHJtX2NydGMgKmNydGMsIHN0cnVjdCBkcm1fcGxhbmUgKnBs YW5lLA0KPiAgCXN0cnVjdCBtdGtfZGRwX2NvbXAgKmNvbXA7DQo+ICANCj4gIAljb21wID0gbXRr X2RybV9kZHBfY29tcF9mb3JfcGxhbmUoY3J0YywgcGxhbmUsICZsb2NhbF9sYXllcik7DQo+IC0J cmV0dXJuIG10a19kZHBfY29tcF9sYXllcl9jaGVjayhjb21wLCBsb2NhbF9sYXllciwgc3RhdGUp Ow0KPiArCWlmIChjb21wKQ0KPiArCQlyZXR1cm4gbXRrX2RkcF9jb21wX2xheWVyX2NoZWNrKGNv bXAsIGxvY2FsX2xheWVyLCBzdGF0ZSk7DQo+ICsJcmV0dXJuIDA7DQo+ICB9DQo+ICANCj4gIHN0 YXRpYyB2b2lkIG10a19kcm1fY3J0Y19hdG9taWNfZW5hYmxlKHN0cnVjdCBkcm1fY3J0YyAqY3J0 YywNCj4gDQo+IGJhc2UtY29tbWl0OiA1YTZmY2JlYWJlM2UyMDQ1OWVkODUwNDY5MGIyNTE1ZGFj YzUyNDZmDQoNCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f CmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpo dHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbA==