From mboxrd@z Thu Jan  1 00:00:00 1970
From: CK Hu <ck.hu@mediatek.com>
Subject: Re: [PATCH v1 2/6] drm/mediatek: use DRM core's atomic commit helper
Date: Mon, 2 Dec 2019 14:07:18 +0800
Message-ID: <1575266838.26513.0.camel@mtksdaap41>
References: <20191128024238.9399-1-bibby.hsieh@mediatek.com>
 <20191128024238.9399-3-bibby.hsieh@mediatek.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Return-path: <dri-devel-bounces@lists.freedesktop.org>
Received: from mailgw01.mediatek.com (unknown [210.61.82.183])
 by gabe.freedesktop.org (Postfix) with ESMTP id 5A5B789F3C
 for <dri-devel@lists.freedesktop.org>; Mon,  2 Dec 2019 06:07:25 +0000 (UTC)
In-Reply-To: <20191128024238.9399-3-bibby.hsieh@mediatek.com>
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/dri-devel>,
 <mailto:dri-devel-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/dri-devel>
List-Post: <mailto:dri-devel@lists.freedesktop.org>
List-Help: <mailto:dri-devel-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/dri-devel>,
 <mailto:dri-devel-request@lists.freedesktop.org?subject=subscribe>
Errors-To: dri-devel-bounces@lists.freedesktop.org
Sender: "dri-devel" <dri-devel-bounces@lists.freedesktop.org>
To: Bibby Hsieh <bibby.hsieh@mediatek.com>
Cc: drinkcat@chromium.org, srv_heupstream@mediatek.com, David Airlie <airlied@linux.ie>, Daniel Vetter <daniel.vetter@ffwll.ch>, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, tfiga@chromium.org, Thierry Reding <thierry.reding@gmail.com>, linux-mediatek@lists.infradead.org, Matthias Brugger <matthias.bgg@gmail.com>, linux-arm-kernel@lists.infradead.org
List-Id: dri-devel@lists.freedesktop.org

SGksIEJpYmJ5Og0KDQpPbiBUaHUsIDIwMTktMTEtMjggYXQgMTA6NDIgKzA4MDAsIEJpYmJ5IEhz
aWVoIHdyb3RlOg0KPiBUaGUgRFJNIGNvcmUgYXRvbWljIGhlbHBlciBub3cgc3VwcG9ydHMgYXN5
bmNocm9ub3VzIGNvbW1pdHMgbmF0aXZlbHkuDQo+IFRoZSBjdXN0b20gZHJtIGltcGxlbWVudGF0
aW9uIGlzbid0IG5lZWRlZCBhbnltb3JlLCByZW1vdmUgaXQuDQoNClJldmlld2VkLWJ5OiBDSyBI
dSA8Y2suaHVAbWVkaWF0ZWsuY29tPg0KDQpSZWdhcmRzLA0KQ0sNCg0KPiANCj4gU2lnbmVkLW9m
Zi1ieTogQmliYnkgSHNpZWggPGJpYmJ5LmhzaWVoQG1lZGlhdGVrLmNvbT4NCj4gLS0tDQo+ICBk
cml2ZXJzL2dwdS9kcm0vbWVkaWF0ZWsvbXRrX2RybV9kcnYuYyB8IDg2ICsrLS0tLS0tLS0tLS0t
LS0tLS0tLS0tLS0tDQo+ICBkcml2ZXJzL2dwdS9kcm0vbWVkaWF0ZWsvbXRrX2RybV9kcnYuaCB8
ICA3IC0tLQ0KPiAgMiBmaWxlcyBjaGFuZ2VkLCA1IGluc2VydGlvbnMoKyksIDg4IGRlbGV0aW9u
cygtKQ0KPiANCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9tZWRpYXRlay9tdGtfZHJt
X2Rydi5jIGIvZHJpdmVycy9ncHUvZHJtL21lZGlhdGVrL210a19kcm1fZHJ2LmMNCj4gaW5kZXgg
NjU4OGRjNmRkNWUzLi4xNmU1NzcxZDE4MmUgMTAwNjQ0DQo+IC0tLSBhL2RyaXZlcnMvZ3B1L2Ry
bS9tZWRpYXRlay9tdGtfZHJtX2Rydi5jDQo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9tZWRpYXRl
ay9tdGtfZHJtX2Rydi5jDQo+IEBAIC0zNiw4OSArMzYsMTQgQEANCj4gICNkZWZpbmUgRFJJVkVS
X01BSk9SIDENCj4gICNkZWZpbmUgRFJJVkVSX01JTk9SIDANCj4gIA0KPiAtc3RhdGljIHZvaWQg
bXRrX2F0b21pY19zY2hlZHVsZShzdHJ1Y3QgbXRrX2RybV9wcml2YXRlICpwcml2YXRlLA0KPiAt
CQkJCXN0cnVjdCBkcm1fYXRvbWljX3N0YXRlICpzdGF0ZSkNCj4gLXsNCj4gLQlwcml2YXRlLT5j
b21taXQuc3RhdGUgPSBzdGF0ZTsNCj4gLQlzY2hlZHVsZV93b3JrKCZwcml2YXRlLT5jb21taXQu
d29yayk7DQo+IC19DQo+IC0NCj4gLXN0YXRpYyB2b2lkIG10a19hdG9taWNfY29tcGxldGUoc3Ry
dWN0IG10a19kcm1fcHJpdmF0ZSAqcHJpdmF0ZSwNCj4gLQkJCQlzdHJ1Y3QgZHJtX2F0b21pY19z
dGF0ZSAqc3RhdGUpDQo+IC17DQo+IC0Jc3RydWN0IGRybV9kZXZpY2UgKmRybSA9IHByaXZhdGUt
PmRybTsNCj4gLQ0KPiAtCWRybV9hdG9taWNfaGVscGVyX3dhaXRfZm9yX2ZlbmNlcyhkcm0sIHN0
YXRlLCBmYWxzZSk7DQo+IC0NCj4gLQkvKg0KPiAtCSAqIE1lZGlhdGVrIGRybSBzdXBwb3J0cyBy
dW50aW1lIFBNLCBzbyBwbGFuZSByZWdpc3RlcnMgY2Fubm90IGJlDQo+IC0JICogd3JpdHRlbiB3
aGVuIHRoZWlyIGNydGMgaXMgZGlzYWJsZWQuDQo+IC0JICoNCj4gLQkgKiBUaGUgY29tbWVudCBm
b3IgZHJtX2F0b21pY19oZWxwZXJfY29tbWl0IHN0YXRlczoNCj4gLQkgKiAgICAgRm9yIGRyaXZl
cnMgc3VwcG9ydGluZyBydW50aW1lIFBNIHRoZSByZWNvbW1lbmRlZCBzZXF1ZW5jZSBpcw0KPiAt
CSAqDQo+IC0JICogICAgIGRybV9hdG9taWNfaGVscGVyX2NvbW1pdF9tb2Rlc2V0X2Rpc2FibGVz
KGRldiwgc3RhdGUpOw0KPiAtCSAqICAgICBkcm1fYXRvbWljX2hlbHBlcl9jb21taXRfbW9kZXNl
dF9lbmFibGVzKGRldiwgc3RhdGUpOw0KPiAtCSAqICAgICBkcm1fYXRvbWljX2hlbHBlcl9jb21t
aXRfcGxhbmVzKGRldiwgc3RhdGUsDQo+IC0JICogICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgRFJNX1BMQU5FX0NPTU1JVF9BQ1RJVkVfT05MWSk7DQo+IC0JICoNCj4gLQkgKiBT
ZWUgdGhlIGtlcm5lbGRvYyBlbnRyaWVzIGZvciB0aGVzZSB0aHJlZSBmdW5jdGlvbnMgZm9yIG1v
cmUgZGV0YWlscy4NCj4gLQkgKi8NCj4gLQlkcm1fYXRvbWljX2hlbHBlcl9jb21taXRfbW9kZXNl
dF9kaXNhYmxlcyhkcm0sIHN0YXRlKTsNCj4gLQlkcm1fYXRvbWljX2hlbHBlcl9jb21taXRfbW9k
ZXNldF9lbmFibGVzKGRybSwgc3RhdGUpOw0KPiAtCWRybV9hdG9taWNfaGVscGVyX2NvbW1pdF9w
bGFuZXMoZHJtLCBzdGF0ZSwNCj4gLQkJCQkJRFJNX1BMQU5FX0NPTU1JVF9BQ1RJVkVfT05MWSk7
DQo+IC0NCj4gLQlkcm1fYXRvbWljX2hlbHBlcl93YWl0X2Zvcl92YmxhbmtzKGRybSwgc3RhdGUp
Ow0KPiAtDQo+IC0JZHJtX2F0b21pY19oZWxwZXJfY2xlYW51cF9wbGFuZXMoZHJtLCBzdGF0ZSk7
DQo+IC0JZHJtX2F0b21pY19zdGF0ZV9wdXQoc3RhdGUpOw0KPiAtfQ0KPiAtDQo+IC1zdGF0aWMg
dm9pZCBtdGtfYXRvbWljX3dvcmsoc3RydWN0IHdvcmtfc3RydWN0ICp3b3JrKQ0KPiAtew0KPiAt
CXN0cnVjdCBtdGtfZHJtX3ByaXZhdGUgKnByaXZhdGUgPSBjb250YWluZXJfb2Yod29yaywNCj4g
LQkJCXN0cnVjdCBtdGtfZHJtX3ByaXZhdGUsIGNvbW1pdC53b3JrKTsNCj4gLQ0KPiAtCW10a19h
dG9taWNfY29tcGxldGUocHJpdmF0ZSwgcHJpdmF0ZS0+Y29tbWl0LnN0YXRlKTsNCj4gLX0NCj4g
LQ0KPiAtc3RhdGljIGludCBtdGtfYXRvbWljX2NvbW1pdChzdHJ1Y3QgZHJtX2RldmljZSAqZHJt
LA0KPiAtCQkJICAgICBzdHJ1Y3QgZHJtX2F0b21pY19zdGF0ZSAqc3RhdGUsDQo+IC0JCQkgICAg
IGJvb2wgYXN5bmMpDQo+IC17DQo+IC0Jc3RydWN0IG10a19kcm1fcHJpdmF0ZSAqcHJpdmF0ZSA9
IGRybS0+ZGV2X3ByaXZhdGU7DQo+IC0JaW50IHJldDsNCj4gLQ0KPiAtCXJldCA9IGRybV9hdG9t
aWNfaGVscGVyX3ByZXBhcmVfcGxhbmVzKGRybSwgc3RhdGUpOw0KPiAtCWlmIChyZXQpDQo+IC0J
CXJldHVybiByZXQ7DQo+IC0NCj4gLQltdXRleF9sb2NrKCZwcml2YXRlLT5jb21taXQubG9jayk7
DQo+IC0JZmx1c2hfd29yaygmcHJpdmF0ZS0+Y29tbWl0LndvcmspOw0KPiAtDQo+IC0JcmV0ID0g
ZHJtX2F0b21pY19oZWxwZXJfc3dhcF9zdGF0ZShzdGF0ZSwgdHJ1ZSk7DQo+IC0JaWYgKHJldCkg
ew0KPiAtCQltdXRleF91bmxvY2soJnByaXZhdGUtPmNvbW1pdC5sb2NrKTsNCj4gLQkJZHJtX2F0
b21pY19oZWxwZXJfY2xlYW51cF9wbGFuZXMoZHJtLCBzdGF0ZSk7DQo+IC0JCXJldHVybiByZXQ7
DQo+IC0JfQ0KPiAtDQo+IC0JZHJtX2F0b21pY19zdGF0ZV9nZXQoc3RhdGUpOw0KPiAtCWlmIChh
c3luYykNCj4gLQkJbXRrX2F0b21pY19zY2hlZHVsZShwcml2YXRlLCBzdGF0ZSk7DQo+IC0JZWxz
ZQ0KPiAtCQltdGtfYXRvbWljX2NvbXBsZXRlKHByaXZhdGUsIHN0YXRlKTsNCj4gLQ0KPiAtCW11
dGV4X3VubG9jaygmcHJpdmF0ZS0+Y29tbWl0LmxvY2spOw0KPiAtDQo+IC0JcmV0dXJuIDA7DQo+
IC19DQo+ICtzdGF0aWMgY29uc3Qgc3RydWN0IGRybV9tb2RlX2NvbmZpZ19oZWxwZXJfZnVuY3Mg
bXRrX2RybV9tb2RlX2NvbmZpZ19oZWxwZXJzID0gew0KPiArCS5hdG9taWNfY29tbWl0X3RhaWwg
PSBkcm1fYXRvbWljX2hlbHBlcl9jb21taXRfdGFpbF9ycG0sDQo+ICt9Ow0KPiAgDQo+ICBzdGF0
aWMgY29uc3Qgc3RydWN0IGRybV9tb2RlX2NvbmZpZ19mdW5jcyBtdGtfZHJtX21vZGVfY29uZmln
X2Z1bmNzID0gew0KPiAgCS5mYl9jcmVhdGUgPSBtdGtfZHJtX21vZGVfZmJfY3JlYXRlLA0KPiAg
CS5hdG9taWNfY2hlY2sgPSBkcm1fYXRvbWljX2hlbHBlcl9jaGVjaywNCj4gLQkuYXRvbWljX2Nv
bW1pdCA9IG10a19hdG9taWNfY29tbWl0LA0KPiArCS5hdG9taWNfY29tbWl0ID0gZHJtX2F0b21p
Y19oZWxwZXJfY29tbWl0LA0KPiAgfTsNCj4gIA0KPiAgc3RhdGljIGNvbnN0IGVudW0gbXRrX2Rk
cF9jb21wX2lkIG10MjcwMV9tdGtfZGRwX21haW5bXSA9IHsNCj4gQEAgLTI2NSw2ICsxOTAsNyBA
QCBzdGF0aWMgaW50IG10a19kcm1fa21zX2luaXQoc3RydWN0IGRybV9kZXZpY2UgKmRybSkNCj4g
IAlkcm0tPm1vZGVfY29uZmlnLm1heF93aWR0aCA9IDQwOTY7DQo+ICAJZHJtLT5tb2RlX2NvbmZp
Zy5tYXhfaGVpZ2h0ID0gNDA5NjsNCj4gIAlkcm0tPm1vZGVfY29uZmlnLmZ1bmNzID0gJm10a19k
cm1fbW9kZV9jb25maWdfZnVuY3M7DQo+ICsJZHJtLT5tb2RlX2NvbmZpZy5oZWxwZXJfcHJpdmF0
ZSA9ICZtdGtfZHJtX21vZGVfY29uZmlnX2hlbHBlcnM7DQo+ICANCj4gIAlyZXQgPSBjb21wb25l
bnRfYmluZF9hbGwoZHJtLT5kZXYsIGRybSk7DQo+ICAJaWYgKHJldCkNCj4gQEAgLTU0MCw4ICs0
NjYsNiBAQCBzdGF0aWMgaW50IG10a19kcm1fcHJvYmUoc3RydWN0IHBsYXRmb3JtX2RldmljZSAq
cGRldikNCj4gIAlpZiAoIXByaXZhdGUpDQo+ICAJCXJldHVybiAtRU5PTUVNOw0KPiAgDQo+IC0J
bXV0ZXhfaW5pdCgmcHJpdmF0ZS0+Y29tbWl0LmxvY2spOw0KPiAtCUlOSVRfV09SSygmcHJpdmF0
ZS0+Y29tbWl0LndvcmssIG10a19hdG9taWNfd29yayk7DQo+ICAJcHJpdmF0ZS0+ZGF0YSA9IG9m
X2RldmljZV9nZXRfbWF0Y2hfZGF0YShkZXYpOw0KPiAgDQo+ICAJbWVtID0gcGxhdGZvcm1fZ2V0
X3Jlc291cmNlKHBkZXYsIElPUkVTT1VSQ0VfTUVNLCAwKTsNCj4gZGlmZiAtLWdpdCBhL2RyaXZl
cnMvZ3B1L2RybS9tZWRpYXRlay9tdGtfZHJtX2Rydi5oIGIvZHJpdmVycy9ncHUvZHJtL21lZGlh
dGVrL210a19kcm1fZHJ2LmgNCj4gaW5kZXggYjZhODI3MjhkNTYzLi45ZjRjZTYwMTc0ZjYgMTAw
NjQ0DQo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9tZWRpYXRlay9tdGtfZHJtX2Rydi5oDQo+ICsr
KyBiL2RyaXZlcnMvZ3B1L2RybS9tZWRpYXRlay9tdGtfZHJtX2Rydi5oDQo+IEBAIC00NiwxMyAr
NDYsNiBAQCBzdHJ1Y3QgbXRrX2RybV9wcml2YXRlIHsNCj4gIAlzdHJ1Y3QgZGV2aWNlX25vZGUg
KmNvbXBfbm9kZVtERFBfQ09NUE9ORU5UX0lEX01BWF07DQo+ICAJc3RydWN0IG10a19kZHBfY29t
cCAqZGRwX2NvbXBbRERQX0NPTVBPTkVOVF9JRF9NQVhdOw0KPiAgCWNvbnN0IHN0cnVjdCBtdGtf
bW1zeXNfZHJpdmVyX2RhdGEgKmRhdGE7DQo+IC0NCj4gLQlzdHJ1Y3Qgew0KPiAtCQlzdHJ1Y3Qg
ZHJtX2F0b21pY19zdGF0ZSAqc3RhdGU7DQo+IC0JCXN0cnVjdCB3b3JrX3N0cnVjdCB3b3JrOw0K
PiAtCQlzdHJ1Y3QgbXV0ZXggbG9jazsNCj4gLQl9IGNvbW1pdDsNCj4gLQ0KPiAgCXN0cnVjdCBk
cm1fYXRvbWljX3N0YXRlICpzdXNwZW5kX3N0YXRlOw0KPiAgDQo+ICAJYm9vbCBkbWFfcGFybXNf
YWxsb2NhdGVkOw0KDQpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f
X19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5v
cmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2
ZWw=